From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alexander Graf" <agraf@csgraf.de>
Subject: [RFC PATCH v3 27/28] arm/Kconfig: Always select SEMIHOSTING when TCG is present
Date: Fri, 13 Jan 2023 11:04:18 -0300 [thread overview]
Message-ID: <20230113140419.4013-28-farosas@suse.de> (raw)
In-Reply-To: <20230113140419.4013-1-farosas@suse.de>
We are about to enable the build without TCG, so CONFIG_SEMIHOSTING
and CONFIG_ARM_COMPATIBLE_SEMIHOSTING cannot be unconditionally set in
default.mak anymore. So reflect the change in a Kconfig.
Instead of using semihosting/Kconfig, use a target-specific file, so
that the change doesn't affect other architectures which might
implement semihosting in a way compatible with KVM.
The selection from ARM_v7M needs to be removed to avoid a cycle during
parsing.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
configs/devices/arm-softmmu/default.mak | 2 --
hw/arm/Kconfig | 1 -
target/arm/Kconfig | 7 +++++++
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/configs/devices/arm-softmmu/default.mak b/configs/devices/arm-softmmu/default.mak
index 6985a25377..24fb5f0366 100644
--- a/configs/devices/arm-softmmu/default.mak
+++ b/configs/devices/arm-softmmu/default.mak
@@ -39,6 +39,4 @@ CONFIG_MICROBIT=y
CONFIG_FSL_IMX25=y
CONFIG_FSL_IMX7=y
CONFIG_FSL_IMX6UL=y
-CONFIG_SEMIHOSTING=y
-CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y
CONFIG_ALLWINNER_H3=y
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 17fcde8e1c..e6f984fea8 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -312,7 +312,6 @@ config ARM_V7M
# currently v7M must be included in a TCG build due to translate.c
default y if TCG && (ARM || AARCH64)
select PTIMER
- select ARM_COMPATIBLE_SEMIHOSTING
config ALLWINNER_A10
bool
diff --git a/target/arm/Kconfig b/target/arm/Kconfig
index 3f3394a22b..60278ea9f7 100644
--- a/target/arm/Kconfig
+++ b/target/arm/Kconfig
@@ -4,3 +4,10 @@ config ARM
config AARCH64
bool
select ARM
+
+# This config exists just so we can make SEMIHOSTING default when TCG
+# is selected without also changing it for other architectures.
+config ARM_SEMIHOSTING
+ bool
+ default y if TCG && (ARM || AARCH64)
+ select ARM_COMPATIBLE_SEMIHOSTING
--
2.35.3
next prev parent reply other threads:[~2023-01-13 16:49 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 14:03 [RFC PATCH v3 00/28] target/arm: Allow CONFIG_TCG=n builds Fabiano Rosas
2023-01-13 14:03 ` [RFC PATCH v3 01/28] target/arm: rename handle_semihosting to tcg_handle_semihosting Fabiano Rosas
2023-01-13 14:03 ` [RFC PATCH v3 02/28] target/arm: wrap psci call with tcg_enabled Fabiano Rosas
2023-01-13 14:03 ` [RFC PATCH v3 03/28] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled() Fabiano Rosas
2023-01-13 14:03 ` [RFC PATCH v3 04/28] target/arm: Move PC alignment check Fabiano Rosas
2023-01-17 16:11 ` Philippe Mathieu-Daudé
2023-01-13 14:03 ` [RFC PATCH v3 05/28] target/arm: Move cpregs code out of cpu.h Fabiano Rosas
2023-01-13 21:48 ` Richard Henderson
2023-01-17 16:12 ` Philippe Mathieu-Daudé
2023-01-13 14:03 ` [RFC PATCH v3 06/28] target/arm: Move cpregs code into cpregs.c Fabiano Rosas
2023-01-17 16:16 ` Philippe Mathieu-Daudé
2023-01-13 14:03 ` [RFC PATCH v3 07/28] target/arm: Move define_debug_regs() to cpregs.c Fabiano Rosas
2023-01-13 14:03 ` [RFC PATCH v3 08/28] target/arm: Wrap breakpoint/watchpoint updates with tcg_enabled Fabiano Rosas
2023-01-13 21:53 ` Richard Henderson
2023-01-13 14:04 ` [RFC PATCH v3 09/28] target/arm: move translate modules to tcg/ Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 10/28] target/arm: move helpers " Fabiano Rosas
2023-01-17 16:22 ` Philippe Mathieu-Daudé
2023-01-17 18:55 ` Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 11/28] target/arm: Move psci.c into the tcg directory Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 12/28] target/arm: Wrap arm_rebuild_hflags calls with tcg_enabled Fabiano Rosas
2023-01-13 21:56 ` Richard Henderson
2023-01-17 16:27 ` Philippe Mathieu-Daudé
2023-01-17 19:00 ` Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 13/28] target/arm: Move hflags code into the tcg directory Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 14/28] target/arm: Move regime_using_lpae_format into internal.h Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 15/28] target/arm: Don't access TCG code when debugging with KVM Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 16/28] cpu-defs.h: Expose CPUTLBEntryFull to non-TCG code Fabiano Rosas
2023-01-17 16:29 ` Philippe Mathieu-Daudé
2023-01-13 14:04 ` [RFC PATCH v3 17/28] target/arm: Move cortex sysregs into cpregs.c Fabiano Rosas
2023-01-13 21:58 ` Richard Henderson
2023-01-13 14:04 ` [RFC PATCH v3 18/28] target/arm: Move common cpu code into cpu.c Fabiano Rosas
2023-01-13 22:01 ` Richard Henderson
2023-01-18 12:46 ` Fabiano Rosas
2023-01-17 16:36 ` Philippe Mathieu-Daudé
2023-01-17 19:01 ` Fabiano Rosas
2023-01-18 10:45 ` Philippe Mathieu-Daudé
2023-01-18 11:33 ` Claudio Fontana
2023-01-18 12:10 ` Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 19/28] target/arm: move cpu_tcg to tcg/cpu32.c Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 20/28] target/arm: Set cortex-a57 as default cpu for KVM-only build Fabiano Rosas
2023-01-13 14:33 ` Claudio Fontana
2023-01-13 16:22 ` Fabiano Rosas
2023-01-13 22:06 ` Richard Henderson
2023-01-13 22:05 ` Richard Henderson
2023-01-16 13:45 ` Fabiano Rosas
2023-01-16 13:50 ` Peter Maydell
2023-01-16 14:08 ` Fabiano Rosas
2023-01-16 13:49 ` Peter Maydell
2023-01-13 14:04 ` [RFC PATCH v3 21/28] tests/qtest: Skip tests that depend on TCG when CONFIG_TCG=n Fabiano Rosas
2023-01-13 14:22 ` Thomas Huth
2023-01-13 15:16 ` Fabiano Rosas
2023-01-13 22:09 ` Richard Henderson
2023-01-16 13:48 ` Fabiano Rosas
2023-01-17 14:32 ` Cornelia Huck
2023-01-17 19:04 ` Fabiano Rosas
2023-01-13 14:04 ` [RFC PATCH v3 22/28] tests/qtest: Restrict bcm2835-dma-test to CONFIG_RASPI Fabiano Rosas
2023-01-13 14:23 ` Thomas Huth
2023-01-13 22:10 ` Richard Henderson
2023-01-16 8:39 ` Philippe Mathieu-Daudé
2023-01-13 14:04 ` [RFC PATCH v3 23/28] tests/tcg: Do not build/run TCG tests if TCG is disabled Fabiano Rosas
2023-01-13 14:27 ` Thomas Huth
2023-01-13 14:04 ` [RFC PATCH v3 24/28] tests/avocado: Skip tests that require a missing accelerator Fabiano Rosas
2023-01-13 22:14 ` Richard Henderson
2023-01-13 14:04 ` [RFC PATCH v3 25/28] tests/avocado: Tag TCG tests with accel:tcg Fabiano Rosas
2023-01-13 22:14 ` Richard Henderson
2023-01-13 14:04 ` [RFC PATCH v3 26/28] target/avocado: Pass parameters to migration test on aarch64 Fabiano Rosas
2023-01-13 14:04 ` Fabiano Rosas [this message]
2023-01-13 22:39 ` [RFC PATCH v3 27/28] arm/Kconfig: Always select SEMIHOSTING when TCG is present Richard Henderson
2023-01-13 14:04 ` [RFC PATCH v3 28/28] arm/Kconfig: Do not build TCG-only boards on a KVM-only build Fabiano Rosas
2023-01-13 22:42 ` Richard Henderson
2023-01-18 10:47 ` [RFC PATCH v3 00/28] target/arm: Allow CONFIG_TCG=n builds Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113140419.4013-28-farosas@suse.de \
--to=farosas@suse.de \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).