* [PATCH] target/arm: Fix in_debug path in S1_ptw_translate
@ 2023-01-14 5:46 Richard Henderson
2023-01-17 16:35 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Richard Henderson @ 2023-01-14 5:46 UTC (permalink / raw)
To: qemu-devel; +Cc: idan.horowitz, qemu-arm, qemu-stable
During the conversion, the test against get_phys_addr_lpae got inverted,
meaning that successful translations went to the 'failed' label.
Cc: qemu-stable@nongnu.org
Fixes: f3639a64f60 ("target/arm: Use softmmu tlbs for page table walking")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1417
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/ptw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
index 4bda0590c7..57f3615a66 100644
--- a/target/arm/ptw.c
+++ b/target/arm/ptw.c
@@ -238,8 +238,8 @@ static bool S1_ptw_translate(CPUARMState *env, S1Translate *ptw,
};
GetPhysAddrResult s2 = { };
- if (!get_phys_addr_lpae(env, &s2ptw, addr, MMU_DATA_LOAD,
- false, &s2, fi)) {
+ if (get_phys_addr_lpae(env, &s2ptw, addr, MMU_DATA_LOAD,
+ false, &s2, fi)) {
goto fail;
}
ptw->out_phys = s2.f.phys_addr;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/arm: Fix in_debug path in S1_ptw_translate
2023-01-14 5:46 [PATCH] target/arm: Fix in_debug path in S1_ptw_translate Richard Henderson
@ 2023-01-17 16:35 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2023-01-17 16:35 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, idan.horowitz, qemu-arm, qemu-stable
On Sat, 14 Jan 2023 at 05:47, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> During the conversion, the test against get_phys_addr_lpae got inverted,
> meaning that successful translations went to the 'failed' label.
>
> Cc: qemu-stable@nongnu.org
> Fixes: f3639a64f60 ("target/arm: Use softmmu tlbs for page table walking")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1417
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/ptw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-17 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-14 5:46 [PATCH] target/arm: Fix in_debug path in S1_ptw_translate Richard Henderson
2023-01-17 16:35 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).