* [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check
@ 2023-01-17 10:53 Eugenio Pérez
2023-01-23 13:17 ` Laurent Vivier
2023-01-23 14:39 ` Michael S. Tsirkin
0 siblings, 2 replies; 4+ messages in thread
From: Eugenio Pérez @ 2023-01-17 10:53 UTC (permalink / raw)
To: mst
Cc: elic, Zhu Lingshan, Si-Wei Liu, qemu-devel, Jason Wang, Cindy Lu,
Gautam Dawar, leiyang
VHOST_BACKEND_F_IOTLB_ASID is the feature bit, not the bitmask. Since
the device under test also provided VHOST_BACKEND_F_IOTLB_MSG_V2 and
VHOST_BACKEND_F_IOTLB_BATCH, this went unnoticed.
Fixes: c1a1008685 ("vdpa: always start CVQ in SVQ mode if possible")
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
---
Originally on SUSPEND series, but it is a fix that it is worth to send
and apply individually:
https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg02574.html
---
net/vhost-vdpa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 1a13a34d35..de5ed8ff22 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -384,7 +384,7 @@ static int vhost_vdpa_net_cvq_start(NetClientState *nc)
g_strerror(errno), errno);
return -1;
}
- if (!(backend_features & VHOST_BACKEND_F_IOTLB_ASID) ||
+ if (!(backend_features & BIT_ULL(VHOST_BACKEND_F_IOTLB_ASID)) ||
!vhost_vdpa_net_valid_svq_features(v->dev->features, NULL)) {
return 0;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check
2023-01-17 10:53 [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check Eugenio Pérez
@ 2023-01-23 13:17 ` Laurent Vivier
2023-01-23 14:39 ` Michael S. Tsirkin
1 sibling, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2023-01-23 13:17 UTC (permalink / raw)
To: Eugenio Pérez, mst
Cc: elic, Zhu Lingshan, Si-Wei Liu, qemu-devel, Jason Wang, Cindy Lu,
Gautam Dawar, leiyang
On 1/17/23 11:53, Eugenio Pérez wrote:
> VHOST_BACKEND_F_IOTLB_ASID is the feature bit, not the bitmask. Since
> the device under test also provided VHOST_BACKEND_F_IOTLB_MSG_V2 and
> VHOST_BACKEND_F_IOTLB_BATCH, this went unnoticed.
>
> Fixes: c1a1008685 ("vdpa: always start CVQ in SVQ mode if possible")
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> Originally on SUSPEND series, but it is a fix that it is worth to send
> and apply individually:
> https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg02574.html
>
> ---
> net/vhost-vdpa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 1a13a34d35..de5ed8ff22 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -384,7 +384,7 @@ static int vhost_vdpa_net_cvq_start(NetClientState *nc)
> g_strerror(errno), errno);
> return -1;
> }
> - if (!(backend_features & VHOST_BACKEND_F_IOTLB_ASID) ||
> + if (!(backend_features & BIT_ULL(VHOST_BACKEND_F_IOTLB_ASID)) ||
> !vhost_vdpa_net_valid_svq_features(v->dev->features, NULL)) {
> return 0;
> }
> --
> 2.31.1
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check
2023-01-17 10:53 [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check Eugenio Pérez
2023-01-23 13:17 ` Laurent Vivier
@ 2023-01-23 14:39 ` Michael S. Tsirkin
2023-01-29 5:43 ` Jason Wang
1 sibling, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2023-01-23 14:39 UTC (permalink / raw)
To: Eugenio Pérez
Cc: elic, Zhu Lingshan, Si-Wei Liu, qemu-devel, Jason Wang, Cindy Lu,
Gautam Dawar, leiyang
On Tue, Jan 17, 2023 at 11:53:08AM +0100, Eugenio Pérez wrote:
> VHOST_BACKEND_F_IOTLB_ASID is the feature bit, not the bitmask. Since
> the device under test also provided VHOST_BACKEND_F_IOTLB_MSG_V2 and
> VHOST_BACKEND_F_IOTLB_BATCH, this went unnoticed.
>
> Fixes: c1a1008685 ("vdpa: always start CVQ in SVQ mode if possible")
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Jason are you merging this?
> ---
> Originally on SUSPEND series, but it is a fix that it is worth to send
> and apply individually:
> https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg02574.html
>
> ---
> net/vhost-vdpa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 1a13a34d35..de5ed8ff22 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -384,7 +384,7 @@ static int vhost_vdpa_net_cvq_start(NetClientState *nc)
> g_strerror(errno), errno);
> return -1;
> }
> - if (!(backend_features & VHOST_BACKEND_F_IOTLB_ASID) ||
> + if (!(backend_features & BIT_ULL(VHOST_BACKEND_F_IOTLB_ASID)) ||
> !vhost_vdpa_net_valid_svq_features(v->dev->features, NULL)) {
> return 0;
> }
> --
> 2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check
2023-01-23 14:39 ` Michael S. Tsirkin
@ 2023-01-29 5:43 ` Jason Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2023-01-29 5:43 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Eugenio Pérez, elic, Zhu Lingshan, Si-Wei Liu, qemu-devel,
Cindy Lu, Gautam Dawar, leiyang
On Mon, Jan 23, 2023 at 10:39 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Tue, Jan 17, 2023 at 11:53:08AM +0100, Eugenio Pérez wrote:
> > VHOST_BACKEND_F_IOTLB_ASID is the feature bit, not the bitmask. Since
> > the device under test also provided VHOST_BACKEND_F_IOTLB_MSG_V2 and
> > VHOST_BACKEND_F_IOTLB_BATCH, this went unnoticed.
> >
> > Fixes: c1a1008685 ("vdpa: always start CVQ in SVQ mode if possible")
> > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > Acked-by: Jason Wang <jasowang@redhat.com>
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Jason are you merging this?
Queued.
Thanks
>
> > ---
> > Originally on SUSPEND series, but it is a fix that it is worth to send
> > and apply individually:
> > https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg02574.html
> >
> > ---
> > net/vhost-vdpa.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> > index 1a13a34d35..de5ed8ff22 100644
> > --- a/net/vhost-vdpa.c
> > +++ b/net/vhost-vdpa.c
> > @@ -384,7 +384,7 @@ static int vhost_vdpa_net_cvq_start(NetClientState *nc)
> > g_strerror(errno), errno);
> > return -1;
> > }
> > - if (!(backend_features & VHOST_BACKEND_F_IOTLB_ASID) ||
> > + if (!(backend_features & BIT_ULL(VHOST_BACKEND_F_IOTLB_ASID)) ||
> > !vhost_vdpa_net_valid_svq_features(v->dev->features, NULL)) {
> > return 0;
> > }
> > --
> > 2.31.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-29 5:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-17 10:53 [PATCH] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check Eugenio Pérez
2023-01-23 13:17 ` Laurent Vivier
2023-01-23 14:39 ` Michael S. Tsirkin
2023-01-29 5:43 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).