From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Warner Losh" <imp@bsdimp.com>, "Kyle Evans" <kevans@freebsd.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Emanuele Giuseppe Esposito" <eesposit@redhat.com>
Subject: [PATCH 0/3] TSA: make sure QEMU compiles when using clang TSA
Date: Tue, 17 Jan 2023 08:52:00 -0500 [thread overview]
Message-ID: <20230117135203.3049709-1-eesposit@redhat.com> (raw)
This serie aims to enable clang Thread Safety Analysis (TSA) in QEMU.
The goal is to use it for our multiqueue project aiming to replace the
block layer AioContext lock with a rwlock and make sure the lock is taken
correctly everywhere [1].
By default, TSA covers pthread mutexes, therefore when added in QEMU it
immediately detects some wrappers using pthread_mutex_lock/unlock without
using the proper TSA macros. Since adding such macro requires scanning all
possible callers of the affected wrapper, simply use TSA_NO_TSA to suppress
the warnings.
[1] = https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg00903.html
Emanuele Giuseppe Esposito (2):
util/qemu-thread-posix: use TSA_NO_TSA to suppress clang TSA warnings
bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings
Kevin Wolf (1):
configure: Enable -Wthread-safety if present
configure | 1 +
bsd-user/qemu.h | 5 +++--
include/exec/exec-all.h | 5 +++--
include/qemu/thread.h | 14 +++++++++-----
util/qemu-thread-posix.c | 2 +-
5 files changed, 17 insertions(+), 10 deletions(-)
--
2.39.0
next reply other threads:[~2023-01-17 13:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 13:52 Emanuele Giuseppe Esposito [this message]
2023-01-17 13:52 ` [PATCH 1/3] util/qemu-thread-posix: use TSA_NO_TSA to suppress clang TSA warnings Emanuele Giuseppe Esposito
2023-01-17 14:33 ` Philippe Mathieu-Daudé
2023-01-17 14:43 ` Emanuele Giuseppe Esposito
2023-01-17 15:49 ` Philippe Mathieu-Daudé
2023-01-17 13:52 ` [PATCH 2/3] bsd-user/mmap: " Emanuele Giuseppe Esposito
2023-01-17 16:16 ` Warner Losh
2023-01-17 16:21 ` Emanuele Giuseppe Esposito
2023-01-17 16:25 ` Kevin Wolf
2023-01-17 16:43 ` Warner Losh
2023-01-17 17:17 ` Kevin Wolf
2023-01-17 20:43 ` Stefan Hajnoczi
2023-01-18 9:14 ` Kevin Wolf
2023-01-18 12:31 ` Stefan Hajnoczi
2023-01-18 15:12 ` Emanuele Giuseppe Esposito
2023-01-18 15:24 ` Stefan Hajnoczi
2023-01-18 17:35 ` Warner Losh
2023-01-17 16:32 ` Stefan Hajnoczi
2023-01-17 13:52 ` [PATCH 3/3] configure: Enable -Wthread-safety if present Emanuele Giuseppe Esposito
2023-01-17 14:02 ` Daniel P. Berrangé
2023-01-17 14:41 ` Emanuele Giuseppe Esposito
2023-01-17 15:01 ` Daniel P. Berrangé
2023-01-17 15:59 ` Kevin Wolf
2023-01-17 16:22 ` [PATCH 0/3] TSA: make sure QEMU compiles when using clang TSA Stefan Hajnoczi
2023-02-13 10:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117135203.3049709-1-eesposit@redhat.com \
--to=eesposit@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).