From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: [PULL 2/9] Makefile: allow 'make uninstall'
Date: Wed, 18 Jan 2023 12:34:11 +0100 [thread overview]
Message-ID: <20230118113418.1650416-3-thuth@redhat.com> (raw)
In-Reply-To: <20230118113418.1650416-1-thuth@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Meson supports an "uninstall", so we can easily allow it to work by
not suppressing the forwarding of it from Make to meson.
We originally suppressed this because Meson's 'uninstall' has a hole
in it: it will remove everything that is installed by a mechanism
meson knows about, but not things installed by "custom install
scripts", and there is no "custom uninstall script" mechanism.
For QEMU, though, the only thing that was being installed by a custom
install script was the LC_MESSAGES files handled by Meson's i18n
module, and that code was fixed in Meson commit 487d45c1e5bfff0fbdb4,
which is present in Meson 0.60.0 and later. Since we already require
a Meson version newer than that, we're now safe to enable
'uninstall', as it will now correctly uninstall everything that was
installed.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/109
Message-Id: <20230110151250.24434-1-peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index a48103cc8a..ce2f83a684 100644
--- a/Makefile
+++ b/Makefile
@@ -150,7 +150,7 @@ NINJAFLAGS = $(if $V,-v) $(if $(MAKE.n), -n) $(if $(MAKE.k), -k0) \
ninja-cmd-goals = $(or $(MAKECMDGOALS), all)
ninja-cmd-goals += $(foreach g, $(MAKECMDGOALS), $(.ninja-goals.$g))
-makefile-targets := build.ninja ctags TAGS cscope dist clean uninstall
+makefile-targets := build.ninja ctags TAGS cscope dist clean
# "ninja -t targets" also lists all prerequisites. If build system
# files are marked as PHONY, however, Make will always try to execute
# "ninja build.ninja".
--
2.31.1
next prev parent reply other threads:[~2023-01-18 11:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 11:34 [PULL 0/9] Testing, s390x and misc patches Thomas Huth
2023-01-18 11:34 ` [PULL 1/9] Upgrade all packages in the FreeBSD VMs to ensure the freshness Thomas Huth
2023-01-18 11:34 ` Thomas Huth [this message]
2023-01-18 11:34 ` [PULL 3/9] bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx Thomas Huth
2023-01-18 11:34 ` [PULL 4/9] MAINTAINERS: Remove bouncing mail address from Kamil Rytarowski Thomas Huth
2023-01-21 4:54 ` Brad Smith
2023-01-18 11:34 ` [PULL 5/9] tests/qtest: Restrict bcm2835-dma-test to CONFIG_RASPI Thomas Huth
2023-01-18 11:34 ` [PULL 6/9] tests/qtest/e1000e-test: Fix the code style Thomas Huth
2023-01-18 11:34 ` [PULL 7/9] tests/qtest/libqos/e1000e: Remove duplicate register definitions Thomas Huth
2023-01-18 11:34 ` [PULL 8/9] tests/vm/haiku.x86_64: Update the Haiku VM to Beta 4 Thomas Huth
2023-01-18 11:34 ` [PULL 9/9] s390x/pv: Implement a CGS check helper Thomas Huth
2023-01-19 11:56 ` [PULL 0/9] Testing, s390x and misc patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118113418.1650416-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).