From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Fabiano Rosas" <farosas@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Akihiko Odaki" <akihiko.odaki@gmail.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [RFC PATCH 3/3] tests/qtest/vnc-display-test: Disable on Darwin
Date: Thu, 19 Jan 2023 13:05:14 +0100 [thread overview]
Message-ID: <20230119120514.28778-4-philmd@linaro.org> (raw)
In-Reply-To: <20230119120514.28778-1-philmd@linaro.org>
This test is failing in gtk-vnc on Darwin:
$ make check-qtest-aarch64
...
19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test
ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672
While QEMU picks the sigaltstack coroutine backend, gtk-vnc uses
the ucontext coroutine backend, which might be broken on Darwin.
Disable this test (current problem being investigated in this thread:
https://lore.kernel.org/qemu-devel/Y8kw6X6keB5l53nl@redhat.com/).
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
tests/qtest/vnc-display-test.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c
index df468c7b22..e52a4326ec 100644
--- a/tests/qtest/vnc-display-test.c
+++ b/tests/qtest/vnc-display-test.c
@@ -19,7 +19,7 @@ typedef struct Test {
GMainLoop *loop;
} Test;
-#if !defined(WIN32)
+#if !defined(WIN32) && !defined(CONFIG_DARWIN)
static void on_vnc_error(VncConnection* self,
const char* msg)
@@ -41,6 +41,9 @@ test_setup(Test *test)
#ifdef WIN32
g_test_skip("Not supported on Windows yet");
return false;
+#elif defined(CONFIG_DARWIN)
+ g_test_skip("Broken on Darwin");
+ return false;
#else
int pair[2];
--
2.38.1
next prev parent reply other threads:[~2023-01-19 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 12:05 [PATCH 0/3] tests/qtest/vnc-display-test: Silent warnings & explicit machine Philippe Mathieu-Daudé
2023-01-19 12:05 ` [PATCH 1/3] tests/qtest/vnc-display-test: Suppress build warnings on Windows Philippe Mathieu-Daudé
2023-01-19 20:22 ` Richard Henderson
2023-01-19 12:05 ` [PATCH 2/3] tests/qtest/vnc-display-test: Use the 'none' machine Philippe Mathieu-Daudé
2023-01-19 12:27 ` Fabiano Rosas
2023-01-19 20:23 ` Richard Henderson
2023-01-19 12:05 ` Philippe Mathieu-Daudé [this message]
2023-01-20 9:09 ` [RFC PATCH 3/3] tests/qtest/vnc-display-test: Disable on Darwin Daniel P. Berrangé
2023-01-19 12:31 ` [PATCH 0/3] tests/qtest/vnc-display-test: Silent warnings & explicit machine Marc-André Lureau
2023-01-26 12:45 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119120514.28778-4-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=akihiko.odaki@gmail.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).