qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH 02/25] aspeed: Add Supermicro X11 SPI machine type
Date: Thu, 19 Jan 2023 13:34:26 +0100	[thread overview]
Message-ID: <20230119123449.531826-3-clg@kaod.org> (raw)
In-Reply-To: <20230119123449.531826-1-clg@kaod.org>

From: Guenter Roeck <linux@roeck-us.net>

supermicrox11-bmc is configured with ast2400-a1 SoC. This does not match
the Supermicro documentation for X11 BMCs, and it does not match the
devicetree file in the Linux kernel.

As it turns out, some Supermicro X11 motherboards use AST2400 SoCs,
while others use AST2500.

Introduce new machine type supermicrox11-spi-bmc with AST2500 SoC
to match the devicetree description in the Linux kernel. Hardware
configuration details for this machine type are guesswork and taken
from defaults as well as from the Linux kernel devicetree file.

The new machine type was tested with aspeed-bmc-supermicro-x11spi.dts
from the Linux kernel and with Linux versions 6.0.3 and 6.1-rc2.
Linux booted successfully from initrd and from both SPI interfaces.
Ethernet interfaces were confirmed to be operational.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Link: https://lore.kernel.org/r/20221025165109.1226001-1-linux@roeck-us.net
Message-Id: <20221025165109.1226001-1-linux@roeck-us.net>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/arm/aspeed.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 55f114ef72..4919a1fe9e 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -71,6 +71,16 @@ struct AspeedMachineState {
         SCU_HW_STRAP_VGA_SIZE_SET(VGA_16M_DRAM) |                       \
         SCU_AST2400_HW_STRAP_BOOT_MODE(AST2400_SPI_BOOT))
 
+/* TODO: Find the actual hardware value */
+#define SUPERMICROX11_SPI_BMC_HW_STRAP1 (                               \
+        AST2500_HW_STRAP1_DEFAULTS |                                    \
+        SCU_AST2500_HW_STRAP_SPI_AUTOFETCH_ENABLE |                     \
+        SCU_AST2500_HW_STRAP_GPIO_STRAP_ENABLE |                        \
+        SCU_AST2500_HW_STRAP_UART_DEBUG |                               \
+        SCU_AST2500_HW_STRAP_DDR4_ENABLE |                              \
+        SCU_HW_STRAP_SPI_WIDTH |                                        \
+        SCU_HW_STRAP_SPI_MODE(SCU_HW_STRAP_SPI_M_S_EN))
+
 /* AST2500 evb hardware value: 0xF100C2E6 */
 #define AST2500_EVB_HW_STRAP1 ((                                        \
         AST2500_HW_STRAP1_DEFAULTS |                                    \
@@ -1141,6 +1151,25 @@ static void aspeed_machine_supermicrox11_bmc_class_init(ObjectClass *oc,
     mc->default_ram_size = 256 * MiB;
 }
 
+static void aspeed_machine_supermicrox11_spi_bmc_class_init(ObjectClass *oc,
+                                                            void *data)
+{
+    MachineClass *mc = MACHINE_CLASS(oc);
+    AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc);
+
+    mc->desc       = "Supermicro X11 SPI BMC (ARM1176)";
+    amc->soc_name  = "ast2500-a1";
+    amc->hw_strap1 = SUPERMICROX11_SPI_BMC_HW_STRAP1;
+    amc->fmc_model = "mx25l25635e";
+    amc->spi_model = "mx25l25635e";
+    amc->num_cs    = 1;
+    amc->macs_mask = ASPEED_MAC0_ON | ASPEED_MAC1_ON;
+    amc->i2c_init  = palmetto_bmc_i2c_init;
+    mc->default_ram_size = 512 * MiB;
+    mc->default_cpus = mc->min_cpus = mc->max_cpus =
+        aspeed_soc_num_cpus(amc->soc_name);
+}
+
 static void aspeed_machine_ast2500_evb_class_init(ObjectClass *oc, void *data)
 {
     MachineClass *mc = MACHINE_CLASS(oc);
@@ -1522,6 +1551,10 @@ static const TypeInfo aspeed_machine_types[] = {
         .name          = MACHINE_TYPE_NAME("supermicrox11-bmc"),
         .parent        = TYPE_ASPEED_MACHINE,
         .class_init    = aspeed_machine_supermicrox11_bmc_class_init,
+    }, {
+        .name          = MACHINE_TYPE_NAME("supermicrox11-spi-bmc"),
+        .parent        = TYPE_ASPEED_MACHINE,
+        .class_init    = aspeed_machine_supermicrox11_spi_bmc_class_init,
     }, {
         .name          = MACHINE_TYPE_NAME("ast2500-evb"),
         .parent        = TYPE_ASPEED_MACHINE,
-- 
2.39.0



  parent reply	other threads:[~2023-01-19 12:40 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 12:34 [PATCH 00/25] aspeed: Various extensions, fixes and cleanups Cédric Le Goater
2023-01-19 12:34 ` [PATCH 01/25] m25p80: Improve error when the backend file size does not match the device Cédric Le Goater
2023-01-19 12:34 ` Cédric Le Goater [this message]
2023-02-01  5:39   ` [PATCH 02/25] aspeed: Add Supermicro X11 SPI machine type Joel Stanley
2023-02-01  7:49     ` Cédric Le Goater
2023-02-01 15:01       ` Guenter Roeck
2023-01-19 12:34 ` [PATCH 03/25] hw/net: Fix read of uninitialized memory in ftgmac100 Cédric Le Goater
2023-02-01  5:41   ` Joel Stanley
2023-01-19 12:34 ` [PATCH 04/25] avocado/boot_linux_console.py: Update ast2600 test Cédric Le Goater
2023-02-01  5:46   ` Joel Stanley
2023-02-01  7:51     ` Cédric Le Goater
2023-01-19 12:34 ` [PATCH 05/25] m25p80: Add the is25wp256 SFPD table Cédric Le Goater
2023-02-01  5:40   ` Joel Stanley
2023-01-19 12:34 ` [PATCH 06/25] tests/avocado/machine_aspeed.py: update buildroot tests Cédric Le Goater
2023-02-01  5:47   ` Joel Stanley
2023-01-19 12:34 ` [PATCH 07/25] tests/avocado/machine_aspeed.py: Mask systemd services to speed up SDK boot Cédric Le Goater
2023-02-01  5:42   ` Joel Stanley
2023-01-19 12:34 ` [PATCH 08/25] hw/arm/boot: Export write_bootloader for Aspeed machines Cédric Le Goater
2023-02-01  5:45   ` Joel Stanley
2023-02-01  7:58     ` Cédric Le Goater
2023-02-01 12:20       ` Philippe Mathieu-Daudé
2023-01-19 12:34 ` [PATCH 09/25] hw/core/loader: Remove declarations of option_rom_has_mr/rom_file_has_mr Cédric Le Goater
2023-02-01  5:45   ` Joel Stanley
2023-01-19 12:34 ` [PATCH 10/25] hw/arm: Extract at24c_eeprom_init helper from Aspeed and Nuvoton boards Cédric Le Goater
2023-01-19 12:34 ` [PATCH 11/25] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init Cédric Le Goater
2023-01-19 12:34 ` [PATCH 12/25] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper Cédric Le Goater
2023-01-19 12:34 ` [PATCH 13/25] hw/arm/aspeed: Add aspeed_eeprom.c Cédric Le Goater
2023-01-19 12:34 ` [PATCH 14/25] hw/nvram/eeprom_at24c: Make reset behavior more like hardware Cédric Le Goater
2023-01-19 12:34 ` [PATCH 15/25] target/arm: Allow users to set the number of VFP registers Cédric Le Goater
2023-01-20  8:40   ` Cédric Le Goater
2023-01-20 17:25     ` Peter Maydell
2023-01-19 12:34 ` [PATCH 16/25] hw/watchdog/wdt_aspeed: Rename MMIO region size as 'iosize' Cédric Le Goater
2023-01-19 12:34 ` [PATCH 17/25] hw/watchdog/wdt_aspeed: Extend MMIO range to cover more registers Cédric Le Goater
2023-01-19 12:34 ` [PATCH 18/25] hw/watchdog/wdt_aspeed: Log unimplemented registers as UNIMP level Cédric Le Goater
2023-01-19 12:34 ` [PATCH 19/25] hw/misc/aspeed_hace: Do not crash if address_space_map() failed Cédric Le Goater
2023-01-19 12:34 ` [PATCH 20/25] hw/arm/aspeed_ast10x0: Add various unimplemented peripherals Cédric Le Goater
2023-02-01  5:54   ` Joel Stanley
2023-01-19 12:34 ` [PATCH 21/25] hw/arm/aspeed_ast10x0: Map I3C peripheral Cédric Le Goater
2023-01-19 12:34 ` [PATCH 22/25] hw/arm/aspeed_ast10x0: Map the secure SRAM Cédric Le Goater
2023-01-19 12:34 ` [PATCH 23/25] hw/arm/aspeed_ast10x0: Map HACE peripheral Cédric Le Goater
2023-01-19 12:34 ` [PATCH 24/25] hw/arm/aspeed_ast10x0: Add TODO comment to use Cortex-M4F Cédric Le Goater
2023-01-19 12:34 ` [PATCH 25/25] tests/avocado: Test Aspeed Zephyr SDK v00.01.08 on AST1030 board Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230119123449.531826-3-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=linux@roeck-us.net \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).