From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-arm@nongnu.org, "Fabiano Rosas" <farosas@suse.de>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 05/11] tests/qtest/migration-test: Inverse #ifdef'ry ladders
Date: Thu, 19 Jan 2023 15:58:32 +0100 [thread overview]
Message-ID: <20230119145838.41835-6-philmd@linaro.org> (raw)
In-Reply-To: <20230119145838.41835-1-philmd@linaro.org>
This slighly simplify the logic, and eases the following conversion.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
tests/qtest/migration-test.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index dbde726adf..8beeda4686 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -647,15 +647,15 @@ static int test_migrate_start(QTestState **from, QTestState **to,
}
if (!getenv("QTEST_LOG") && args->hide_stderr) {
-#ifndef _WIN32
- ignore_stderr = "2>/dev/null";
-#else
+#ifdef _WIN32
/*
* On Windows the QEMU executable is created via CreateProcess() and
* IO redirection does not work, so don't bother adding IO redirection
* to the command line.
*/
ignore_stderr = "";
+#else
+ ignore_stderr = "2>/dev/null";
#endif
} else {
ignore_stderr = "";
--
2.38.1
next prev parent reply other threads:[~2023-01-19 14:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 14:58 [PATCH v2 00/11] tests/qtest: Allow running boot-serial / migration with TCG disabled Philippe Mathieu-Daudé
2023-01-19 14:58 ` [PATCH v2 01/11] tests/qtest/boot-serial-test: Constify tests[] array Philippe Mathieu-Daudé
2023-01-19 20:54 ` Richard Henderson
2023-01-19 14:58 ` [PATCH v2 02/11] tests/qtest/boot-serial-test: Simplify test_machine() a bit Philippe Mathieu-Daudé
2023-01-19 20:59 ` Richard Henderson
2023-01-20 8:54 ` Thomas Huth
2023-01-19 14:58 ` [PATCH v2 03/11] tests/qtest/boot-serial-test: Build command line using GString API Philippe Mathieu-Daudé
2023-01-19 21:03 ` Richard Henderson
2023-01-20 8:59 ` Thomas Huth
2023-01-20 11:04 ` Philippe Mathieu-Daudé
2023-01-19 14:58 ` [PATCH v2 04/11] tests/qtest/boot-serial-test: Only use available accelerators Philippe Mathieu-Daudé
2023-01-19 15:18 ` Fabiano Rosas
2023-01-19 21:05 ` Richard Henderson
2023-01-19 14:58 ` Philippe Mathieu-Daudé [this message]
2023-01-19 21:06 ` [PATCH v2 05/11] tests/qtest/migration-test: Inverse #ifdef'ry ladders Richard Henderson
2023-01-19 14:58 ` [PATCH v2 06/11] tests/qtest/migration-test: Reduce 'cmd_source' string scope Philippe Mathieu-Daudé
2023-01-19 21:08 ` Richard Henderson
2023-01-20 9:02 ` Thomas Huth
2023-01-20 10:58 ` Philippe Mathieu-Daudé
2023-01-19 14:58 ` [PATCH v2 07/11] tests/qtest/migration-test: Build command line using GString API (1/4) Philippe Mathieu-Daudé
2023-01-19 21:10 ` Richard Henderson
2023-01-20 7:32 ` Philippe Mathieu-Daudé
2023-01-19 14:58 ` [PATCH v2 08/11] tests/qtest/migration-test: Build command line using GString API (2/4) Philippe Mathieu-Daudé
2023-01-19 21:13 ` Richard Henderson
2023-01-19 14:58 ` [PATCH v2 09/11] tests/qtest/migration-test: Build command line using GString API (3/4) Philippe Mathieu-Daudé
2023-01-19 21:17 ` Richard Henderson
2023-01-20 7:05 ` Philippe Mathieu-Daudé
2023-01-19 14:58 ` [PATCH v2 10/11] tests/qtest/migration-test: Build command line using GString API (4/4) Philippe Mathieu-Daudé
2023-01-19 21:19 ` Richard Henderson
2023-01-19 14:58 ` [PATCH v2 11/11] tests/qtest/migration-test: Only use available accelerators Philippe Mathieu-Daudé
2023-01-19 21:19 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119145838.41835-6-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=dgilbert@redhat.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).