* [PATCH 2/2] log: remove unneeded new line
@ 2023-01-19 21:40 BALATON Zoltan
2023-01-20 7:01 ` Philippe Mathieu-Daudé
2023-02-28 22:16 ` BALATON Zoltan
0 siblings, 2 replies; 4+ messages in thread
From: BALATON Zoltan @ 2023-01-19 21:40 UTC (permalink / raw)
To: qemu-devel; +Cc: philmd
The help text of the -d plugin option has a new line at the end which
is not needed as one is added automatically. Fixing it removes the
unexpected empty line in -d help output.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
util/log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/log.c b/util/log.c
index a3c097f320..3fe74481da 100644
--- a/util/log.c
+++ b/util/log.c
@@ -489,7 +489,7 @@ const QEMULogItem qemu_log_items[] = {
"do not chain compiled TBs so that \"exec\" and \"cpu\" show\n"
"complete traces" },
#ifdef CONFIG_PLUGIN
- { CPU_LOG_PLUGIN, "plugin", "output from TCG plugins\n"},
+ { CPU_LOG_PLUGIN, "plugin", "output from TCG plugins"},
#endif
{ LOG_STRACE, "strace",
"log every user-mode syscall, its input, and its result" },
--
2.30.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] log: remove unneeded new line
2023-01-19 21:40 [PATCH 2/2] log: remove unneeded new line BALATON Zoltan
@ 2023-01-20 7:01 ` Philippe Mathieu-Daudé
2023-02-28 22:16 ` BALATON Zoltan
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-20 7:01 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, QEMU Trivial
On 19/1/23 22:40, BALATON Zoltan wrote:
> The help text of the -d plugin option has a new line at the end which
> is not needed as one is added automatically. Fixing it removes the
> unexpected empty line in -d help output.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> util/log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] log: remove unneeded new line
2023-01-19 21:40 [PATCH 2/2] log: remove unneeded new line BALATON Zoltan
2023-01-20 7:01 ` Philippe Mathieu-Daudé
@ 2023-02-28 22:16 ` BALATON Zoltan
2023-03-09 13:32 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: BALATON Zoltan @ 2023-02-28 22:16 UTC (permalink / raw)
To: qemu-devel; +Cc: philmd
On Thu, 19 Jan 2023, BALATON Zoltan wrote:
> The help text of the -d plugin option has a new line at the end which
> is not needed as one is added automatically. Fixing it removes the
> unexpected empty line in -d help output.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Ping?
> ---
> util/log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/log.c b/util/log.c
> index a3c097f320..3fe74481da 100644
> --- a/util/log.c
> +++ b/util/log.c
> @@ -489,7 +489,7 @@ const QEMULogItem qemu_log_items[] = {
> "do not chain compiled TBs so that \"exec\" and \"cpu\" show\n"
> "complete traces" },
> #ifdef CONFIG_PLUGIN
> - { CPU_LOG_PLUGIN, "plugin", "output from TCG plugins\n"},
> + { CPU_LOG_PLUGIN, "plugin", "output from TCG plugins"},
> #endif
> { LOG_STRACE, "strace",
> "log every user-mode syscall, its input, and its result" },
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] log: remove unneeded new line
2023-02-28 22:16 ` BALATON Zoltan
@ 2023-03-09 13:32 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-03-09 13:32 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel
On 28/2/23 23:16, BALATON Zoltan wrote:
> On Thu, 19 Jan 2023, BALATON Zoltan wrote:
>> The help text of the -d plugin option has a new line at the end which
>> is not needed as one is added automatically. Fixing it removes the
>> unexpected empty line in -d help output.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> Ping?
Merged as commit cb9291e550.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-09 13:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-19 21:40 [PATCH 2/2] log: remove unneeded new line BALATON Zoltan
2023-01-20 7:01 ` Philippe Mathieu-Daudé
2023-02-28 22:16 ` BALATON Zoltan
2023-03-09 13:32 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).