From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37700C05027 for ; Fri, 20 Jan 2023 23:07:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJ0T1-0000M9-4B; Fri, 20 Jan 2023 18:06:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ0Sz-0000Kv-P3 for qemu-devel@nongnu.org; Fri, 20 Jan 2023 18:06:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ0Sx-0006zW-5V for qemu-devel@nongnu.org; Fri, 20 Jan 2023 18:06:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674255994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nmrvtv3XHQfVNaEYhvgzsGO16+TgmKtQQ/6wJkcGaDg=; b=Ekfu3USGoOrAYACftNABQA2wD0Y4VD7FsR+Rt+YrbZO/Uh7AGUUO6oECd050QB7seuwvK7 SOHAgNzNOxFyfmtKYZ+Ced/NZy0JkIbnfD1tWY2IUabo+23uGwFnABL0XaeiU0+aeeicOB sRUuBwxQYo3I2kEEGT7iBQ5aybTe6K8= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-444--axc_a6ePxO5CVO15d6Sng-1; Fri, 20 Jan 2023 18:06:33 -0500 X-MC-Unique: -axc_a6ePxO5CVO15d6Sng-1 Received: by mail-io1-f70.google.com with SMTP id 4-20020a6b1404000000b00704700d919cso3723108iou.11 for ; Fri, 20 Jan 2023 15:06:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nmrvtv3XHQfVNaEYhvgzsGO16+TgmKtQQ/6wJkcGaDg=; b=t8iIcs9bcQ535NhXo1neEbCi0qm1QZgwzUMH2Ybw9Yi3nS0shv89wdr7iVEMrwT8A4 RKhOVqeJHhPhHmTNS9x89aD1HKekogmQB956xcikC8yUhR4PBm+42QyGNMw3tw5rbxGs NAzerWT35qhZwK0kcJlQ0eFRS7ZWTGcErF2M2geEbTY7EQniJb+WBpC44rVYlLCgcv2y 43uk9d2PVMDhyo0spSKOsdyBjzoOoFmnx2RAsoD9YIkuR97ZgfMvM+yhWP7p2pvuqFA8 krmgukXJInSrEAoX59CMDxmRav77CbxFYiCDPFP1Y6s4xNaN3GNu742znbSKRqe+mEwo 55+w== X-Gm-Message-State: AFqh2kqaqf39BDVVg//Ee8ZCDmhTr3Dn6tLl6fZX8dtCbN80etveivLt 4fakywPwFXu9GEkaZWMymhRfd6V6o96zXp1gX6V3irWrBfmoECBgNcYwteVIy+5CE2mbKAD172J BS7CDczzpBig1Qps= X-Received: by 2002:a92:c261:0:b0:30f:641b:d12c with SMTP id h1-20020a92c261000000b0030f641bd12cmr1552407ild.9.1674255992422; Fri, 20 Jan 2023 15:06:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXu9AjfY1bM8V0xSZuKVtxTtzPgiXPHHkKnOKEAtrkbA7k2qw2ypAIrDOYnkwmu7uA0u6hX/8g== X-Received: by 2002:a92:c261:0:b0:30f:641b:d12c with SMTP id h1-20020a92c261000000b0030f641bd12cmr1552392ild.9.1674255992209; Fri, 20 Jan 2023 15:06:32 -0800 (PST) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id p16-20020a92d290000000b00302632f0d20sm731447ilp.67.2023.01.20.15.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 15:06:31 -0800 (PST) Date: Fri, 20 Jan 2023 16:06:30 -0700 From: Alex Williamson To: Avihai Horon Cc: , Halil Pasic , Christian Borntraeger , Eric Farman , Richard Henderson , David Hildenbrand , "Ilya Leoshkevich" , Thomas Huth , "Juan Quintela" , "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , Cornelia Huck , Paolo Bonzini , Stefan Hajnoczi , Fam Zheng , Eric Blake , Vladimir Sementsov-Ogievskiy , John Snow , =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , , , Yishai Hadas , Jason Gunthorpe , Maor Gottlieb , Kirti Wankhede , Tarun Gupta , Joao Martins Subject: Re: [PATCH v8 05/13] migration/qemu-file: Add qemu_file_get_to_fd() Message-ID: <20230120160630.21e08d05.alex.williamson@redhat.com> In-Reply-To: <20230116141135.12021-6-avihaih@nvidia.com> References: <20230116141135.12021-1-avihaih@nvidia.com> <20230116141135.12021-6-avihaih@nvidia.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=alex.williamson@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 16 Jan 2023 16:11:27 +0200 Avihai Horon wrote: > Add new function qemu_file_get_to_fd() that allows reading data from > QEMUFile and writing it straight into a given fd. >=20 > This will be used later in VFIO migration code. >=20 > Signed-off-by: Avihai Horon > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: C=C3=A9dric Le Goater > --- > migration/qemu-file.h | 1 + > migration/qemu-file.c | 34 ++++++++++++++++++++++++++++++++++ > 2 files changed, 35 insertions(+) quintela, dgilbert, Ping for ack. Thanks, Alex =20 > diff --git a/migration/qemu-file.h b/migration/qemu-file.h > index fa13d04d78..9d0155a2a1 100644 > --- a/migration/qemu-file.h > +++ b/migration/qemu-file.h > @@ -148,6 +148,7 @@ int qemu_file_shutdown(QEMUFile *f); > QEMUFile *qemu_file_get_return_path(QEMUFile *f); > void qemu_fflush(QEMUFile *f); > void qemu_file_set_blocking(QEMUFile *f, bool block); > +int qemu_file_get_to_fd(QEMUFile *f, int fd, size_t size); > =20 > void ram_control_before_iterate(QEMUFile *f, uint64_t flags); > void ram_control_after_iterate(QEMUFile *f, uint64_t flags); > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > index 2d5f74ffc2..102ab3b439 100644 > --- a/migration/qemu-file.c > +++ b/migration/qemu-file.c > @@ -940,3 +940,37 @@ QIOChannel *qemu_file_get_ioc(QEMUFile *file) > { > return file->ioc; > } > + > +/* > + * Read size bytes from QEMUFile f and write them to fd. > + */ > +int qemu_file_get_to_fd(QEMUFile *f, int fd, size_t size) > +{ > + while (size) { > + size_t pending =3D f->buf_size - f->buf_index; > + ssize_t rc; > + > + if (!pending) { > + rc =3D qemu_fill_buffer(f); > + if (rc < 0) { > + return rc; > + } > + if (rc =3D=3D 0) { > + return -EIO; > + } > + continue; > + } > + > + rc =3D write(fd, f->buf + f->buf_index, MIN(pending, size)); > + if (rc < 0) { > + return -errno; > + } > + if (rc =3D=3D 0) { > + return -EIO; > + } > + f->buf_index +=3D rc; > + size -=3D rc; > + } > + > + return 0; > +}