From: "Volker Rümelin" <vr_qemu@t-online.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org
Subject: [PATCH v2 05/11] audio/mixeng: use g_new0() instead of audio_calloc()
Date: Sat, 21 Jan 2023 10:47:29 +0100 [thread overview]
Message-ID: <20230121094735.11644-5-vr_qemu@t-online.de> (raw)
In-Reply-To: <0a4007dc-e11c-f16e-0e21-dbc4e60caa59@t-online.de>
Replace audio_calloc() with the equivalent g_new0().
With a n_structs argument of 1, g_new0() never returns NULL.
Also remove the unnecessary NULL checks.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
audio/audio.c | 5 -----
audio/audio_template.h | 6 +-----
audio/mixeng.c | 7 +------
3 files changed, 2 insertions(+), 16 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index f6b420688d..ac5434a13c 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -507,11 +507,6 @@ static int audio_attach_capture (HWVoiceOut *hw)
sw->ratio = ((int64_t) hw_cap->info.freq << 32) / sw->info.freq;
sw->vol = nominal_volume;
sw->rate = st_rate_start (sw->info.freq, hw_cap->info.freq);
- if (!sw->rate) {
- dolog ("Could not start rate conversion for `%s'\n", SW_NAME (sw));
- g_free (sw);
- return -1;
- }
QLIST_INSERT_HEAD (&hw_cap->sw_head, sw, entries);
QLIST_INSERT_HEAD (&hw->cap_head, sc, entries);
#ifdef DEBUG_CAPTURE
diff --git a/audio/audio_template.h b/audio/audio_template.h
index ac744d3484..d343a1dcb3 100644
--- a/audio/audio_template.h
+++ b/audio/audio_template.h
@@ -141,11 +141,7 @@ static int glue (audio_pcm_sw_alloc_resources_, TYPE) (SW *sw)
#else
sw->rate = st_rate_start (sw->hw->info.freq, sw->info.freq);
#endif
- if (!sw->rate) {
- g_free (sw->buf);
- sw->buf = NULL;
- return -1;
- }
+
return 0;
}
diff --git a/audio/mixeng.c b/audio/mixeng.c
index 100a306d6f..fe454e0725 100644
--- a/audio/mixeng.c
+++ b/audio/mixeng.c
@@ -414,12 +414,7 @@ struct rate {
*/
void *st_rate_start (int inrate, int outrate)
{
- struct rate *rate = audio_calloc(__func__, 1, sizeof(*rate));
-
- if (!rate) {
- dolog ("Could not allocate resampler (%zu bytes)\n", sizeof (*rate));
- return NULL;
- }
+ struct rate *rate = g_new0(struct rate, 1);
rate->opos = 0;
--
2.35.3
next prev parent reply other threads:[~2023-01-21 9:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 9:45 [PATCH v2 00/11] audio: more improvements Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 01/11] audio: log unimplemented audio device sample rates Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 02/11] audio: don't show unnecessary error messages Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 03/11] audio: rename hardware store to backend Volker Rümelin
2023-01-23 7:33 ` Philippe Mathieu-Daudé
2023-01-21 9:47 ` [PATCH v2 04/11] audio: remove unused #define AUDIO_STRINGIFY Volker Rümelin
2023-01-21 9:47 ` Volker Rümelin [this message]
2023-01-21 9:47 ` [PATCH v2 06/11] audio/alsaaudio: use g_new0() instead of audio_calloc() Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 07/11] audio/audio_template: use g_malloc0() to replace audio_calloc() Volker Rümelin
2023-01-23 11:03 ` Daniel P. Berrangé
2023-01-21 9:47 ` [PATCH v2 08/11] audio/audio_template: use g_new0() " Volker Rümelin
2023-01-23 11:04 ` Daniel P. Berrangé
2023-01-21 9:47 ` [PATCH v2 09/11] audio: remove audio_calloc() function Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 10/11] alsaaudio: change default playback settings Volker Rümelin
2023-01-23 7:43 ` Philippe Mathieu-Daudé
2023-01-24 7:34 ` Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 11/11] alsaaudio: reintroduce default recording settings Volker Rümelin
2023-01-23 7:44 ` Philippe Mathieu-Daudé
2023-01-31 14:51 ` [PATCH v2 00/11] audio: more improvements Marc-André Lureau
2023-03-05 17:35 ` Volker Rümelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230121094735.11644-5-vr_qemu@t-online.de \
--to=vr_qemu@t-online.de \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).