From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
qemu-trivial@nongnu.org, "Aurelien Jarno" <aurelien@aurel32.net>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Ani Sinha" <ani@anisinha.ca>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH v4 0/7] AML Housekeeping
Date: Sat, 21 Jan 2023 16:19:34 +0100 [thread overview]
Message-ID: <20230121151941.24120-1-shentey@gmail.com> (raw)
This series factors out AcpiCpuAmlIfClass::madt_cpu from AcpiDeviceIfClass.
By letting the (x86) CPUs implement the new interface, AML generation is
delegated to the CPUs, freeing the ACPI controllers from worrying about x86 CPU
specifics. The delegation to the CPUs is especially interesting for the PIIX4 PM
since it is also used in MIPS only contexts where no ACPI bios is available.
Furthermore, the series introduces qbus_build_aml() which replaces
isa_build_aml() and resolves some open coding.
v4:
- Squash qbus_build_aml() patches into one (Igor)
- Don't use a bare function pointer for AcpiDeviceIfClass::madt_cpu (Igor)
Testing done:
* `make check`
* `qemu-system-x86_64 -M pc -m 2G -cdrom manjaro-kde-21.2.6-220416-linux515.iso`
* `qemu-system-x86_64 -M q35 -m 2G -cdrom \
manjaro-kde-21.2.6-220416-linux515.iso`
v3:
- Clean up includes in AcpiDeviceIfClass::madt_cpu sub series last (Markus)
- Restructure qbus_build_aml() sub series (Phil, me)
v2:
- Don't inline qbus_build_aml() (Phil)
- Add 'hw/acpi/piix4: No need to #include "hw/southbridge/piix.h"'
Bernhard Beschow (7):
hw/i386/acpi-build: Remove unused attributes
hw/isa/isa-bus: Turn isa_build_aml() into qbus_build_aml()
hw/acpi/piix4: No need to #include "hw/southbridge/piix.h"
hw/acpi/acpi_dev_interface: Remove unused parameter from
AcpiDeviceIfClass::madt_cpu
hw/acpi/acpi_dev_interface: Factor out TYPE_ACPI_CPU_AML_IF
hw/acpi/acpi_dev_interface: Remove now unused #include "hw/boards.h"
hw/i386/pc: Unexport pc_madt_cpu_entry()
hw/acpi/hmat.h | 3 +-
hw/i386/acpi-common.h | 3 +-
include/hw/acpi/acpi_aml_interface.h | 3 ++
include/hw/acpi/acpi_cpu_interface.h | 26 ++++++++++++++++
include/hw/acpi/acpi_dev_interface.h | 4 ---
include/hw/i386/pc.h | 6 ----
include/hw/isa/isa.h | 1 -
hw/acpi/acpi-x86-stub.c | 7 -----
hw/acpi/acpi_interface.c | 18 ++++++++++-
hw/acpi/cpu.c | 13 ++++----
hw/acpi/hmat.c | 1 +
hw/acpi/memory_hotplug.c | 1 +
hw/acpi/piix4.c | 3 --
hw/i2c/smbus_ich9.c | 5 +--
hw/i386/acpi-build.c | 5 +--
hw/i386/acpi-common.c | 42 +++----------------------
hw/i386/acpi-microvm.c | 6 ++--
hw/i386/generic_event_device_x86.c | 9 ------
hw/isa/isa-bus.c | 10 ------
hw/isa/lpc_ich9.c | 6 +---
hw/isa/piix3.c | 5 +--
monitor/qmp-cmds.c | 1 +
target/i386/cpu.c | 46 ++++++++++++++++++++++++++++
23 files changed, 117 insertions(+), 107 deletions(-)
create mode 100644 include/hw/acpi/acpi_cpu_interface.h
--
2.39.1
next reply other threads:[~2023-01-21 15:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 15:19 Bernhard Beschow [this message]
2023-01-21 15:19 ` [PATCH v4 1/7] hw/i386/acpi-build: Remove unused attributes Bernhard Beschow
2023-01-21 15:19 ` [PATCH v4 2/7] hw/isa/isa-bus: Turn isa_build_aml() into qbus_build_aml() Bernhard Beschow
2023-01-21 15:19 ` [PATCH v4 3/7] hw/acpi/piix4: No need to #include "hw/southbridge/piix.h" Bernhard Beschow
2023-01-21 15:19 ` [PATCH v4 4/7] hw/acpi/acpi_dev_interface: Remove unused parameter from AcpiDeviceIfClass::madt_cpu Bernhard Beschow
2023-01-21 15:19 ` [PATCH v4 5/7] hw/acpi/acpi_dev_interface: Factor out TYPE_ACPI_CPU_AML_IF Bernhard Beschow
2023-01-25 16:48 ` Igor Mammedov
2023-01-21 15:19 ` [PATCH v4 6/7] hw/acpi/acpi_dev_interface: Remove now unused #include "hw/boards.h" Bernhard Beschow
2023-01-21 15:19 ` [PATCH v4 7/7] hw/i386/pc: Unexport pc_madt_cpu_entry() Bernhard Beschow
2023-01-25 16:52 ` [PATCH v4 0/7] AML Housekeeping Igor Mammedov
2023-01-26 10:42 ` Bernhard Beschow
2023-01-27 12:58 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230121151941.24120-1-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=ani@anisinha.ca \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).