* [PATCH v2] qga/linux: add usb support to guest-get-fsinfo
@ 2023-01-23 13:30 Kfir Manor
2023-01-23 20:42 ` Konstantin Kostiuk
0 siblings, 1 reply; 3+ messages in thread
From: Kfir Manor @ 2023-01-23 13:30 UTC (permalink / raw)
To: qemu-devel, Konstantin Kostiuk, Michael Roth; +Cc: Yan Vugenfirer
Signed-off-by: Kfir Manor <kfir@daynix.com>
---
qga/commands-posix.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index ebd33a643c..aab9d3bd50 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath,
g_str_equal(driver, "sym53c8xx") ||
g_str_equal(driver, "virtio-pci") ||
g_str_equal(driver, "ahci") ||
- g_str_equal(driver, "nvme"))) {
+ g_str_equal(driver, "nvme") ||
+ g_str_equal(driver, "xhci_hcd") ||
+ g_str_equal(driver, "ehci-pci"))) {
break;
}
@@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath,
}
} else if (strcmp(driver, "nvme") == 0) {
disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
+ } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver, "xhci_hcd") == 0) {
+ disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
} else {
g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
goto cleanup;
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] qga/linux: add usb support to guest-get-fsinfo
2023-01-23 13:30 [PATCH v2] qga/linux: add usb support to guest-get-fsinfo Kfir Manor
@ 2023-01-23 20:42 ` Konstantin Kostiuk
2023-03-29 13:04 ` Daniel P. Berrangé
0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Kostiuk @ 2023-01-23 20:42 UTC (permalink / raw)
To: Kfir Manor; +Cc: qemu-devel, Michael Roth, Yan Vugenfirer
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
On Mon, Jan 23, 2023 at 3:31 PM Kfir Manor <kfir@daynix.com> wrote:
> Signed-off-by: Kfir Manor <kfir@daynix.com>
> ---
> qga/commands-posix.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index ebd33a643c..aab9d3bd50 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
> g_str_equal(driver, "sym53c8xx") ||
> g_str_equal(driver, "virtio-pci") ||
> g_str_equal(driver, "ahci") ||
> - g_str_equal(driver, "nvme"))) {
> + g_str_equal(driver, "nvme") ||
> + g_str_equal(driver, "xhci_hcd") ||
> + g_str_equal(driver, "ehci-pci"))) {
> break;
> }
>
> @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
> }
> } else if (strcmp(driver, "nvme") == 0) {
> disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
> + } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver,
> "xhci_hcd") == 0) {
> + disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
> } else {
> g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
> goto cleanup;
> --
> 2.38.1
>
>
[-- Attachment #2: Type: text/html, Size: 2198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] qga/linux: add usb support to guest-get-fsinfo
2023-01-23 20:42 ` Konstantin Kostiuk
@ 2023-03-29 13:04 ` Daniel P. Berrangé
0 siblings, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2023-03-29 13:04 UTC (permalink / raw)
To: Konstantin Kostiuk; +Cc: Kfir Manor, qemu-devel, Michael Roth, Yan Vugenfirer
What's the status of this patch ? It was acked 2 months ago but
AFAICT it was never merged.
On Mon, Jan 23, 2023 at 10:42:06PM +0200, Konstantin Kostiuk wrote:
> Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
>
> On Mon, Jan 23, 2023 at 3:31 PM Kfir Manor <kfir@daynix.com> wrote:
>
> > Signed-off-by: Kfir Manor <kfir@daynix.com>
> > ---
> > qga/commands-posix.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> > index ebd33a643c..aab9d3bd50 100644
> > --- a/qga/commands-posix.c
> > +++ b/qga/commands-posix.c
> > @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> > *syspath,
> > g_str_equal(driver, "sym53c8xx") ||
> > g_str_equal(driver, "virtio-pci") ||
> > g_str_equal(driver, "ahci") ||
> > - g_str_equal(driver, "nvme"))) {
> > + g_str_equal(driver, "nvme") ||
> > + g_str_equal(driver, "xhci_hcd") ||
> > + g_str_equal(driver, "ehci-pci"))) {
> > break;
> > }
> >
> > @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> > *syspath,
> > }
> > } else if (strcmp(driver, "nvme") == 0) {
> > disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
> > + } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver,
> > "xhci_hcd") == 0) {
> > + disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
> > } else {
> > g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
> > goto cleanup;
> > --
> > 2.38.1
> >
> >
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-29 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-23 13:30 [PATCH v2] qga/linux: add usb support to guest-get-fsinfo Kfir Manor
2023-01-23 20:42 ` Konstantin Kostiuk
2023-03-29 13:04 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).