* [PULL 0/3] Block patches
@ 2023-01-23 20:04 Stefan Hajnoczi
2023-01-23 20:04 ` [PULL 1/3] util/aio: Defer disabling poll mode as long as possible Stefan Hajnoczi
` (3 more replies)
0 siblings, 4 replies; 29+ messages in thread
From: Stefan Hajnoczi @ 2023-01-23 20:04 UTC (permalink / raw)
To: qemu-devel
Cc: Hanna Reitz, Michael S. Tsirkin, Kevin Wolf, Stefan Hajnoczi,
Fam Zheng, qemu-block, Paolo Bonzini
The following changes since commit 00b1faea41d283e931256aa78aa975a369ec3ae6:
Merge tag 'pull-target-arm-20230123' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-01-23 13:40:28 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 4f01a9bb0461e8c11ee0c94d90a504cb7d580a85:
block/blkio: Fix inclusion of required headers (2023-01-23 15:02:07 -0500)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Chao Gao (1):
util/aio: Defer disabling poll mode as long as possible
Peter Krempa (1):
block/blkio: Fix inclusion of required headers
Stefan Hajnoczi (1):
virtio-blk: simplify virtio_blk_dma_restart_cb()
include/hw/virtio/virtio-blk.h | 2 --
block/blkio.c | 2 ++
hw/block/dataplane/virtio-blk.c | 17 +++++-------
hw/block/virtio-blk.c | 46 ++++++++++++++-------------------
util/aio-posix.c | 21 ++++++++++-----
5 files changed, 43 insertions(+), 45 deletions(-)
--
2.39.0
^ permalink raw reply [flat|nested] 29+ messages in thread* [PULL 1/3] util/aio: Defer disabling poll mode as long as possible
2023-01-23 20:04 [PULL 0/3] Block patches Stefan Hajnoczi
@ 2023-01-23 20:04 ` Stefan Hajnoczi
2023-01-23 20:04 ` [PULL 2/3] virtio-blk: simplify virtio_blk_dma_restart_cb() Stefan Hajnoczi
` (2 subsequent siblings)
3 siblings, 0 replies; 29+ messages in thread
From: Stefan Hajnoczi @ 2023-01-23 20:04 UTC (permalink / raw)
To: qemu-devel
Cc: Hanna Reitz, Michael S. Tsirkin, Kevin Wolf, Stefan Hajnoczi,
Fam Zheng, qemu-block, Paolo Bonzini, Chao Gao
From: Chao Gao <chao.gao@intel.com>
When we measure FIO read performance (cache=writethrough, bs=4k,
iodepth=64) in VMs, ~80K/s notifications (e.g., EPT_MISCONFIG) are observed
from guest to qemu.
It turns out those frequent notificatons are caused by interference from
worker threads. Worker threads queue bottom halves after completing IO
requests. Pending bottom halves may lead to either aio_compute_timeout()
zeros timeout and pass it to try_poll_mode() or run_poll_handlers() returns
no progress after noticing pending aio_notify() events. Both cause
run_poll_handlers() to call poll_set_started(false) to disable poll mode.
However, for both cases, as timeout is already zeroed, the event loop
(i.e., aio_poll()) just processes bottom halves and then starts the next
event loop iteration. So, disabling poll mode has no value but leads to
unnecessary notifications from guest.
To minimize unnecessary notifications from guest, defer disabling poll
mode to when the event loop is about to be blocked.
With this patch applied, FIO seq-read performance (bs=4k, iodepth=64,
cache=writethrough) in VMs increases from 330K/s to 413K/s IOPS.
Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Chao Gao <chao.gao@intel.com>
Message-id: 20220710120849.63086-1-chao.gao@intel.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
util/aio-posix.c | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/util/aio-posix.c b/util/aio-posix.c
index 731f3826c0..6cc6256d53 100644
--- a/util/aio-posix.c
+++ b/util/aio-posix.c
@@ -585,18 +585,16 @@ static bool try_poll_mode(AioContext *ctx, AioHandlerList *ready_list,
max_ns = qemu_soonest_timeout(*timeout, ctx->poll_ns);
if (max_ns && !ctx->fdmon_ops->need_wait(ctx)) {
+ /*
+ * Enable poll mode. It pairs with the poll_set_started() in
+ * aio_poll() which disables poll mode.
+ */
poll_set_started(ctx, ready_list, true);
if (run_poll_handlers(ctx, ready_list, max_ns, timeout)) {
return true;
}
}
-
- if (poll_set_started(ctx, ready_list, false)) {
- *timeout = 0;
- return true;
- }
-
return false;
}
@@ -657,6 +655,17 @@ bool aio_poll(AioContext *ctx, bool blocking)
* system call---a single round of run_poll_handlers_once suffices.
*/
if (timeout || ctx->fdmon_ops->need_wait(ctx)) {
+ /*
+ * Disable poll mode. poll mode should be disabled before the call
+ * of ctx->fdmon_ops->wait() so that guest's notification can wake
+ * up IO threads when some work becomes pending. It is essential to
+ * avoid hangs or unnecessary latency.
+ */
+ if (poll_set_started(ctx, &ready_list, false)) {
+ timeout = 0;
+ progress = true;
+ }
+
ctx->fdmon_ops->wait(ctx, &ready_list, timeout);
}
--
2.39.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PULL 2/3] virtio-blk: simplify virtio_blk_dma_restart_cb()
2023-01-23 20:04 [PULL 0/3] Block patches Stefan Hajnoczi
2023-01-23 20:04 ` [PULL 1/3] util/aio: Defer disabling poll mode as long as possible Stefan Hajnoczi
@ 2023-01-23 20:04 ` Stefan Hajnoczi
2023-01-23 20:04 ` [PULL 3/3] block/blkio: Fix inclusion of required headers Stefan Hajnoczi
2023-01-24 12:24 ` [PULL 0/3] Block patches Peter Maydell
3 siblings, 0 replies; 29+ messages in thread
From: Stefan Hajnoczi @ 2023-01-23 20:04 UTC (permalink / raw)
To: qemu-devel
Cc: Hanna Reitz, Michael S. Tsirkin, Kevin Wolf, Stefan Hajnoczi,
Fam Zheng, qemu-block, Paolo Bonzini, Sergio Lopez,
Emanuele Giuseppe Esposito
virtio_blk_dma_restart_cb() is tricky because the BH must deal with
virtio_blk_data_plane_start()/virtio_blk_data_plane_stop() being called.
There are two issues with the code:
1. virtio_blk_realize() should use qdev_add_vm_change_state_handler()
instead of qemu_add_vm_change_state_handler(). This ensures the
ordering with virtio_init()'s vm change state handler that calls
virtio_blk_data_plane_start()/virtio_blk_data_plane_stop() is
well-defined. Then blk's AioContext is guaranteed to be up-to-date in
virtio_blk_dma_restart_cb() and it's no longer necessary to have a
special case for virtio_blk_data_plane_start().
2. Only blk_drain() waits for virtio_blk_dma_restart_cb()'s
blk_inc_in_flight() to be decremented. The bdrv_drain() family of
functions do not wait for BlockBackend's in_flight counter to reach
zero. virtio_blk_data_plane_stop() relies on blk_set_aio_context()'s
implicit drain, but that's a bdrv_drain() and not a blk_drain().
Note that virtio_blk_reset() already correctly relies on blk_drain().
If virtio_blk_data_plane_stop() switches to blk_drain() then we can
properly wait for pending virtio_blk_dma_restart_bh() calls.
Once these issues are taken care of the code becomes simpler. This
change is in preparation for multiple IOThreads in virtio-blk where we
need to clean up the multi-threading behavior.
I ran the reproducer from commit 49b44549ace7 ("virtio-blk: On restart,
process queued requests in the proper context") to check that there is
no regression.
Cc: Sergio Lopez <slp@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Message-id: 20221102182337.252202-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/hw/virtio/virtio-blk.h | 2 --
hw/block/dataplane/virtio-blk.c | 17 +++++-------
hw/block/virtio-blk.c | 46 ++++++++++++++-------------------
3 files changed, 26 insertions(+), 39 deletions(-)
diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
index 7f589b4146..dafec432ce 100644
--- a/include/hw/virtio/virtio-blk.h
+++ b/include/hw/virtio/virtio-blk.h
@@ -55,7 +55,6 @@ struct VirtIOBlock {
VirtIODevice parent_obj;
BlockBackend *blk;
void *rq;
- QEMUBH *bh;
VirtIOBlkConf conf;
unsigned short sector_mask;
bool original_wce;
@@ -93,6 +92,5 @@ typedef struct MultiReqBuffer {
} MultiReqBuffer;
void virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq);
-void virtio_blk_process_queued_requests(VirtIOBlock *s, bool is_bh);
#endif
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 26f965cabc..b28d81737e 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -237,9 +237,6 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev)
goto fail_aio_context;
}
- /* Process queued requests before the ones in vring */
- virtio_blk_process_queued_requests(vblk, false);
-
/* Kick right away to begin processing requests already in vring */
for (i = 0; i < nvqs; i++) {
VirtQueue *vq = virtio_get_queue(s->vdev, i);
@@ -272,11 +269,6 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev)
fail_host_notifiers:
k->set_guest_notifiers(qbus->parent, nvqs, false);
fail_guest_notifiers:
- /*
- * If we failed to set up the guest notifiers queued requests will be
- * processed on the main context.
- */
- virtio_blk_process_queued_requests(vblk, false);
vblk->dataplane_disabled = true;
s->starting = false;
vblk->dataplane_started = true;
@@ -325,8 +317,13 @@ void virtio_blk_data_plane_stop(VirtIODevice *vdev)
aio_context_acquire(s->ctx);
aio_wait_bh_oneshot(s->ctx, virtio_blk_data_plane_stop_bh, s);
- /* Drain and try to switch bs back to the QEMU main loop. If other users
- * keep the BlockBackend in the iothread, that's ok */
+ /* Wait for virtio_blk_dma_restart_bh() and in flight I/O to complete */
+ blk_drain(s->conf->conf.blk);
+
+ /*
+ * Try to switch bs back to the QEMU main loop. If other users keep the
+ * BlockBackend in the iothread, that's ok
+ */
blk_set_aio_context(s->conf->conf.blk, qemu_get_aio_context(), NULL);
aio_context_release(s->ctx);
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index f717550fdc..1762517878 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -806,8 +806,10 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
virtio_blk_handle_vq(s, vq);
}
-void virtio_blk_process_queued_requests(VirtIOBlock *s, bool is_bh)
+static void virtio_blk_dma_restart_bh(void *opaque)
{
+ VirtIOBlock *s = opaque;
+
VirtIOBlockReq *req = s->rq;
MultiReqBuffer mrb = {};
@@ -834,43 +836,27 @@ void virtio_blk_process_queued_requests(VirtIOBlock *s, bool is_bh)
if (mrb.num_reqs) {
virtio_blk_submit_multireq(s, &mrb);
}
- if (is_bh) {
- blk_dec_in_flight(s->conf.conf.blk);
- }
+
+ /* Paired with inc in virtio_blk_dma_restart_cb() */
+ blk_dec_in_flight(s->conf.conf.blk);
+
aio_context_release(blk_get_aio_context(s->conf.conf.blk));
}
-static void virtio_blk_dma_restart_bh(void *opaque)
-{
- VirtIOBlock *s = opaque;
-
- qemu_bh_delete(s->bh);
- s->bh = NULL;
-
- virtio_blk_process_queued_requests(s, true);
-}
-
static void virtio_blk_dma_restart_cb(void *opaque, bool running,
RunState state)
{
VirtIOBlock *s = opaque;
- BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(s)));
- VirtioBusState *bus = VIRTIO_BUS(qbus);
if (!running) {
return;
}
- /*
- * If ioeventfd is enabled, don't schedule the BH here as queued
- * requests will be processed while starting the data plane.
- */
- if (!s->bh && !virtio_bus_ioeventfd_enabled(bus)) {
- s->bh = aio_bh_new(blk_get_aio_context(s->conf.conf.blk),
- virtio_blk_dma_restart_bh, s);
- blk_inc_in_flight(s->conf.conf.blk);
- qemu_bh_schedule(s->bh);
- }
+ /* Paired with dec in virtio_blk_dma_restart_bh() */
+ blk_inc_in_flight(s->conf.conf.blk);
+
+ aio_bh_schedule_oneshot(blk_get_aio_context(s->conf.conf.blk),
+ virtio_blk_dma_restart_bh, s);
}
static void virtio_blk_reset(VirtIODevice *vdev)
@@ -1213,7 +1199,13 @@ static void virtio_blk_device_realize(DeviceState *dev, Error **errp)
return;
}
- s->change = qemu_add_vm_change_state_handler(virtio_blk_dma_restart_cb, s);
+ /*
+ * This must be after virtio_init() so virtio_blk_dma_restart_cb() gets
+ * called after ->start_ioeventfd() has already set blk's AioContext.
+ */
+ s->change =
+ qdev_add_vm_change_state_handler(dev, virtio_blk_dma_restart_cb, s);
+
blk_ram_registrar_init(&s->blk_ram_registrar, s->blk);
blk_set_dev_ops(s->blk, &virtio_block_ops, s);
--
2.39.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* [PULL 3/3] block/blkio: Fix inclusion of required headers
2023-01-23 20:04 [PULL 0/3] Block patches Stefan Hajnoczi
2023-01-23 20:04 ` [PULL 1/3] util/aio: Defer disabling poll mode as long as possible Stefan Hajnoczi
2023-01-23 20:04 ` [PULL 2/3] virtio-blk: simplify virtio_blk_dma_restart_cb() Stefan Hajnoczi
@ 2023-01-23 20:04 ` Stefan Hajnoczi
2023-01-24 12:24 ` [PULL 0/3] Block patches Peter Maydell
3 siblings, 0 replies; 29+ messages in thread
From: Stefan Hajnoczi @ 2023-01-23 20:04 UTC (permalink / raw)
To: qemu-devel
Cc: Hanna Reitz, Michael S. Tsirkin, Kevin Wolf, Stefan Hajnoczi,
Fam Zheng, qemu-block, Paolo Bonzini, Peter Krempa,
Markus Armbruster
From: Peter Krempa <pkrempa@redhat.com>
After recent header file inclusion rework the build fails when the blkio
module is enabled:
../block/blkio.c: In function ‘blkio_detach_aio_context’:
../block/blkio.c:321:24: error: implicit declaration of function ‘bdrv_get_aio_context’; did you mean ‘qemu_get_aio_context’? [-Werror=implicit-function-declaration]
321 | aio_set_fd_handler(bdrv_get_aio_context(bs),
| ^~~~~~~~~~~~~~~~~~~~
| qemu_get_aio_context
../block/blkio.c:321:24: error: nested extern declaration of ‘bdrv_get_aio_context’ [-Werror=nested-externs]
../block/blkio.c:321:24: error: passing argument 1 of ‘aio_set_fd_handler’ makes pointer from integer without a cast [-Werror=int-conversion]
321 | aio_set_fd_handler(bdrv_get_aio_context(bs),
| ^~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
In file included from /home/pipo/git/qemu.git/include/qemu/job.h:33,
from /home/pipo/git/qemu.git/include/block/blockjob.h:30,
from /home/pipo/git/qemu.git/include/block/block_int-global-state.h:28,
from /home/pipo/git/qemu.git/include/block/block_int.h:27,
from ../block/blkio.c:13:
/home/pipo/git/qemu.git/include/block/aio.h:476:37: note: expected ‘AioContext *’ but argument is of type ‘int’
476 | void aio_set_fd_handler(AioContext *ctx,
| ~~~~~~~~~~~~^~~
../block/blkio.c: In function ‘blkio_file_open’:
../block/blkio.c:821:34: error: passing argument 2 of ‘blkio_attach_aio_context’ makes pointer from integer without a cast [-Werror=int-conversion]
821 | blkio_attach_aio_context(bs, bdrv_get_aio_context(bs));
| ^~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
Fix it by including 'block/block-io.h' which contains the required
declarations.
Fixes: e2c1c34f139f49ef909bb4322607fb8b39002312
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-id: 2bc956011404a1ab03342aefde0087b5b4762562.1674477350.git.pkrempa@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/blkio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/blkio.c b/block/blkio.c
index 5eae3adfaf..6ad86b23d1 100644
--- a/block/blkio.c
+++ b/block/blkio.c
@@ -19,6 +19,8 @@
#include "qemu/module.h"
#include "exec/memory.h" /* for ram_block_discard_disable() */
+#include "block/block-io.h"
+
/*
* Keep the QEMU BlockDriver names identical to the libblkio driver names.
* Using macros instead of typing out the string literals avoids typos.
--
2.39.0
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: [PULL 0/3] Block patches
2023-01-23 20:04 [PULL 0/3] Block patches Stefan Hajnoczi
` (2 preceding siblings ...)
2023-01-23 20:04 ` [PULL 3/3] block/blkio: Fix inclusion of required headers Stefan Hajnoczi
@ 2023-01-24 12:24 ` Peter Maydell
3 siblings, 0 replies; 29+ messages in thread
From: Peter Maydell @ 2023-01-24 12:24 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Hanna Reitz, Michael S. Tsirkin, Kevin Wolf,
Fam Zheng, qemu-block, Paolo Bonzini
On Mon, 23 Jan 2023 at 20:04, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 00b1faea41d283e931256aa78aa975a369ec3ae6:
>
> Merge tag 'pull-target-arm-20230123' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-01-23 13:40:28 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 4f01a9bb0461e8c11ee0c94d90a504cb7d580a85:
>
> block/blkio: Fix inclusion of required headers (2023-01-23 15:02:07 -0500)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2025-05-08 14:22 Stefan Hajnoczi
2025-05-10 18:36 ` Stefan Hajnoczi
0 siblings, 1 reply; 29+ messages in thread
From: Stefan Hajnoczi @ 2025-05-08 14:22 UTC (permalink / raw)
To: qemu-devel
Cc: Stefan Hajnoczi, Kevin Wolf, Fam Zheng, Hanna Reitz, qemu-block,
qemu-s390x, Thomas Huth, Philippe Mathieu-Daudé
The following changes since commit 57b6f8d07f1478375f85a4593a207e936c63ff59:
Merge tag 'pull-target-arm-20250506' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2025-05-07 14:28:20 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 624379be3a8136db420ec3a3fee36fe91e9f789e:
block/nvme: Use host PCI MMIO API (2025-05-08 10:21:10 -0400)
----------------------------------------------------------------
Pull request
Farhan Ali's s390x host PCI support for the block/nvme.c driver.
----------------------------------------------------------------
Farhan Ali (3):
util: Add functions for s390x mmio read/write
include: Add a header to define host PCI MMIO functions
block/nvme: Use host PCI MMIO API
include/qemu/host-pci-mmio.h | 136 +++++++++++++++++++++++++++++++
include/qemu/s390x_pci_mmio.h | 24 ++++++
block/nvme.c | 41 +++++-----
util/s390x_pci_mmio.c | 146 ++++++++++++++++++++++++++++++++++
util/meson.build | 2 +
5 files changed, 331 insertions(+), 18 deletions(-)
create mode 100644 include/qemu/host-pci-mmio.h
create mode 100644 include/qemu/s390x_pci_mmio.h
create mode 100644 util/s390x_pci_mmio.c
--
2.49.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2025-05-08 14:22 Stefan Hajnoczi
@ 2025-05-10 18:36 ` Stefan Hajnoczi
0 siblings, 0 replies; 29+ messages in thread
From: Stefan Hajnoczi @ 2025-05-10 18:36 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Stefan Hajnoczi, Kevin Wolf, Fam Zheng, Hanna Reitz,
qemu-block, qemu-s390x, Thomas Huth, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 116 bytes --]
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2023-11-06 17:10 Hanna Czenczek
2023-11-07 3:03 ` Stefan Hajnoczi
0 siblings, 1 reply; 29+ messages in thread
From: Hanna Czenczek @ 2023-11-06 17:10 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, Hanna Czenczek
The following changes since commit 3e01f1147a16ca566694b97eafc941d62fa1e8d8:
Merge tag 'pull-sp-20231105' of https://gitlab.com/rth7680/qemu into staging (2023-11-06 09:34:22 +0800)
are available in the Git repository at:
https://gitlab.com/hreitz/qemu.git tags/pull-block-2023-11-06
for you to fetch changes up to ad4feaca61d76fecad784e6d5e7bae40d0411c46:
file-posix: fix over-writing of returning zone_append offset (2023-11-06 16:15:07 +0100)
----------------------------------------------------------------
Block patches:
- One patch to make qcow2's discard-no-unref option do better what it is
supposed to do (i.e. prevent fragmentation)
- Two fixes for zoned requests
----------------------------------------------------------------
Jean-Louis Dupond (1):
qcow2: keep reference on zeroize with discard-no-unref enabled
Naohiro Aota (1):
file-posix: fix over-writing of returning zone_append offset
Sam Li (1):
block/file-posix: fix update_zones_wp() caller
qapi/block-core.json | 24 ++++++++++++++----------
block/file-posix.c | 23 ++++++++++++-----------
block/qcow2-cluster.c | 22 ++++++++++++++++++----
qemu-options.hx | 10 +++++++---
4 files changed, 51 insertions(+), 28 deletions(-)
--
2.41.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2022-10-31 18:51 Stefan Hajnoczi
2022-11-01 20:04 ` Stefan Hajnoczi
0 siblings, 1 reply; 29+ messages in thread
From: Stefan Hajnoczi @ 2022-10-31 18:51 UTC (permalink / raw)
To: qemu-devel
Cc: Eric Blake, Hanna Reitz, Stefan Hajnoczi, Markus Armbruster,
qemu-block, Kevin Wolf
The following changes since commit 7208429223963c405c62fa2611398f1aa8033593:
Merge tag 'mem-2022-10-28' of https://github.com/davidhildenbrand/qemu into staging (2022-10-30 18:31:59 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 6c32fc0df9cd901add75618c831fb26a9eb742cb:
block/blkio: Make driver nvme-io_uring take a "path" instead of a "filename" (2022-10-31 14:35:14 -0400)
----------------------------------------------------------------
Pull request
Note that we're still discussing "block/blkio: Make driver nvme-io_uring take a
"path" instead of a "filename"". I have sent the pull request now so everything
is ready for the soft freeze tomorrow if we decide to go ahead with the patch.
----------------------------------------------------------------
Alberto Faria (3):
block/blkio: Add virtio-blk-vfio-pci BlockDriver
block/blkio: Tolerate device size changes
block/blkio: Make driver nvme-io_uring take a "path" instead of a
"filename"
qapi/block-core.json | 22 +++++++++++++++++++--
block/blkio.c | 47 ++++++++++++++++++++++++++++++++++++++++----
2 files changed, 63 insertions(+), 6 deletions(-)
--
2.38.1
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PULL 0/3] Block patches
2022-10-31 18:51 Stefan Hajnoczi
@ 2022-11-01 20:04 ` Stefan Hajnoczi
0 siblings, 0 replies; 29+ messages in thread
From: Stefan Hajnoczi @ 2022-11-01 20:04 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Eric Blake, Hanna Reitz, Stefan Hajnoczi,
Markus Armbruster, qemu-block, Kevin Wolf
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2022-05-05 8:42 Stefan Hajnoczi
2022-05-05 16:29 ` Richard Henderson
0 siblings, 1 reply; 29+ messages in thread
From: Stefan Hajnoczi @ 2022-05-05 8:42 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, Richard Henderson, Stefan Hajnoczi
The following changes since commit 9cf289af47bcfae5c75de37d8e5d6fd23705322c:
Merge tag 'qga-pull-request' of gitlab.com:marcandre.lureau/qemu into staging (2022-05-04 03:42:49 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to bef2e050d6a7feb865854c65570c496ac5a8cf53:
util/event-loop-base: Introduce options to set the thread pool size (2022-05-04 17:02:19 +0100)
----------------------------------------------------------------
Pull request
Add new thread-pool-min/thread-pool-max parameters to control the thread pool
used for async I/O.
----------------------------------------------------------------
Nicolas Saenz Julienne (3):
Introduce event-loop-base abstract class
util/main-loop: Introduce the main loop into QOM
util/event-loop-base: Introduce options to set the thread pool size
qapi/qom.json | 43 ++++++++--
meson.build | 26 +++---
include/block/aio.h | 10 +++
include/block/thread-pool.h | 3 +
include/qemu/main-loop.h | 10 +++
include/sysemu/event-loop-base.h | 41 +++++++++
include/sysemu/iothread.h | 6 +-
event-loop-base.c | 140 +++++++++++++++++++++++++++++++
iothread.c | 68 +++++----------
util/aio-posix.c | 1 +
util/async.c | 20 +++++
util/main-loop.c | 65 ++++++++++++++
util/thread-pool.c | 55 +++++++++++-
13 files changed, 419 insertions(+), 69 deletions(-)
create mode 100644 include/sysemu/event-loop-base.h
create mode 100644 event-loop-base.c
--
2.35.1
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2022-05-05 8:42 Stefan Hajnoczi
@ 2022-05-05 16:29 ` Richard Henderson
2022-05-09 10:34 ` Stefan Hajnoczi
0 siblings, 1 reply; 29+ messages in thread
From: Richard Henderson @ 2022-05-05 16:29 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: qemu-block
On 5/5/22 03:42, Stefan Hajnoczi wrote:
> The following changes since commit 9cf289af47bcfae5c75de37d8e5d6fd23705322c:
>
> Merge tag 'qga-pull-request' of gitlab.com:marcandre.lureau/qemu into staging (2022-05-04 03:42:49 -0700)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to bef2e050d6a7feb865854c65570c496ac5a8cf53:
>
> util/event-loop-base: Introduce options to set the thread pool size (2022-05-04 17:02:19 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> Add new thread-pool-min/thread-pool-max parameters to control the thread pool
> used for async I/O.
>
> ----------------------------------------------------------------
>
> Nicolas Saenz Julienne (3):
> Introduce event-loop-base abstract class
> util/main-loop: Introduce the main loop into QOM
> util/event-loop-base: Introduce options to set the thread pool size
>
> qapi/qom.json | 43 ++++++++--
> meson.build | 26 +++---
> include/block/aio.h | 10 +++
> include/block/thread-pool.h | 3 +
> include/qemu/main-loop.h | 10 +++
> include/sysemu/event-loop-base.h | 41 +++++++++
> include/sysemu/iothread.h | 6 +-
> event-loop-base.c | 140 +++++++++++++++++++++++++++++++
> iothread.c | 68 +++++----------
> util/aio-posix.c | 1 +
> util/async.c | 20 +++++
> util/main-loop.c | 65 ++++++++++++++
> util/thread-pool.c | 55 +++++++++++-
> 13 files changed, 419 insertions(+), 69 deletions(-)
> create mode 100644 include/sysemu/event-loop-base.h
> create mode 100644 event-loop-base.c
>
This appears to introduce a new error on msys2-64bit:
14/85 qemu:unit / test-aio ERROR 2.14s
exit status 3
>>> MALLOC_PERTURB_=82 G_TEST_SRCDIR=C:/GitLab-Runner/builds/qemu-project/qemu/tests/unit
G_TEST_BUILDDIR=C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/unit
C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/unit/test-aio.exe --tap -k
------------------------------------- 8< -------------------------------------
stderr:
(test program exited with status code 3)
https://gitlab.com/qemu-project/qemu/-/jobs/2418935125
Are you in a position to test this yourself locally?
r~
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2022-05-05 16:29 ` Richard Henderson
@ 2022-05-09 10:34 ` Stefan Hajnoczi
2022-05-09 12:45 ` Stefan Hajnoczi
0 siblings, 1 reply; 29+ messages in thread
From: Stefan Hajnoczi @ 2022-05-09 10:34 UTC (permalink / raw)
To: Richard Henderson, Nicolas Saenz Julienne
Cc: Stefan Hajnoczi, qemu-devel, qemu block
On Thu, 5 May 2022 at 17:43, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 5/5/22 03:42, Stefan Hajnoczi wrote:
> > The following changes since commit 9cf289af47bcfae5c75de37d8e5d6fd23705322c:
> >
> > Merge tag 'qga-pull-request' of gitlab.com:marcandre.lureau/qemu into staging (2022-05-04 03:42:49 -0700)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to bef2e050d6a7feb865854c65570c496ac5a8cf53:
> >
> > util/event-loop-base: Introduce options to set the thread pool size (2022-05-04 17:02:19 +0100)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > Add new thread-pool-min/thread-pool-max parameters to control the thread pool
> > used for async I/O.
> >
> > ----------------------------------------------------------------
> >
> > Nicolas Saenz Julienne (3):
> > Introduce event-loop-base abstract class
> > util/main-loop: Introduce the main loop into QOM
> > util/event-loop-base: Introduce options to set the thread pool size
> >
> > qapi/qom.json | 43 ++++++++--
> > meson.build | 26 +++---
> > include/block/aio.h | 10 +++
> > include/block/thread-pool.h | 3 +
> > include/qemu/main-loop.h | 10 +++
> > include/sysemu/event-loop-base.h | 41 +++++++++
> > include/sysemu/iothread.h | 6 +-
> > event-loop-base.c | 140 +++++++++++++++++++++++++++++++
> > iothread.c | 68 +++++----------
> > util/aio-posix.c | 1 +
> > util/async.c | 20 +++++
> > util/main-loop.c | 65 ++++++++++++++
> > util/thread-pool.c | 55 +++++++++++-
> > 13 files changed, 419 insertions(+), 69 deletions(-)
> > create mode 100644 include/sysemu/event-loop-base.h
> > create mode 100644 event-loop-base.c
> >
>
> This appears to introduce a new error on msys2-64bit:
>
>
> 14/85 qemu:unit / test-aio ERROR 2.14s
> exit status 3
> >>> MALLOC_PERTURB_=82 G_TEST_SRCDIR=C:/GitLab-Runner/builds/qemu-project/qemu/tests/unit
> G_TEST_BUILDDIR=C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/unit
> C:/GitLab-Runner/builds/qemu-project/qemu/build/tests/unit/test-aio.exe --tap -k
> ------------------------------------- 8< -------------------------------------
> stderr:
> (test program exited with status code 3)
>
> https://gitlab.com/qemu-project/qemu/-/jobs/2418935125
>
> Are you in a position to test this yourself locally?
I haven't reproduced it yet but will dig a bit more.
test-aio.exe succeeds under Wine:
# random seed: R02S572ad8b9cfeac92bb23a64678114e66d
1..29
# Start of aio tests
ok 1 /aio/acquire
ok 2 /aio/external-client
# Start of bh tests
ok 3 /aio/bh/schedule
ok 4 /aio/bh/schedule10
ok 5 /aio/bh/cancel
ok 6 /aio/bh/delete
ok 7 /aio/bh/flush
# Start of callback-delete tests
ok 8 /aio/bh/callback-delete/one
ok 9 /aio/bh/callback-delete/many
# End of callback-delete tests
# End of bh tests
# Start of event tests
ok 10 /aio/event/add-remove
ok 11 /aio/event/wait
ok 12 /aio/event/flush
# Start of wait tests
ok 13 /aio/event/wait/no-flush-cb
# End of wait tests
# End of event tests
# Start of timer tests
ok 14 /aio/timer/schedule
# End of timer tests
# Start of coroutine tests
ok 15 /aio/coroutine/queue-chaining
ok 16 /aio/coroutine/worker-thread-co-enter
# End of coroutine tests
# End of aio tests
# Start of aio-gsource tests
ok 17 /aio-gsource/flush
# Start of bh tests
ok 18 /aio-gsource/bh/schedule
ok 19 /aio-gsource/bh/schedule10
ok 20 /aio-gsource/bh/cancel
ok 21 /aio-gsource/bh/delete
ok 22 /aio-gsource/bh/flush
# Start of callback-delete tests
ok 23 /aio-gsource/bh/callback-delete/one
ok 24 /aio-gsource/bh/callback-delete/many
# End of callback-delete tests
# End of bh tests
# Start of event tests
ok 25 /aio-gsource/event/add-remove
ok 26 /aio-gsource/event/wait
ok 27 /aio-gsource/event/flush
# Start of wait tests
ok 28 /aio-gsource/event/wait/no-flush-cb
# End of wait tests
# End of event tests
# Start of timer tests
ok 29 /aio-gsource/timer/schedule
# End of timer tests
# End of aio-gsource tests
Stefan
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2022-05-09 10:34 ` Stefan Hajnoczi
@ 2022-05-09 12:45 ` Stefan Hajnoczi
0 siblings, 0 replies; 29+ messages in thread
From: Stefan Hajnoczi @ 2022-05-09 12:45 UTC (permalink / raw)
To: Richard Henderson, Nicolas Saenz Julienne
Cc: Stefan Hajnoczi, qemu-devel, qemu block
It looks like a race condition in the test case. The failed test case
(tests/unit/test-aio.c:test_timer_schedule()) assumes the process will
be scheduled in a timely manner. A timer is scheduled for 750 ms and
the test waits for 1 second before running the event loop. At that
point a callback schedules the timer another 750 ms in the future. The
problem is that the exact sequence of event loop (aio_poll())
invocations can be unexpected on a heavily loaded CI runner leading to
spurious test failures.
I re-ran the job and it passed:
https://gitlab.com/qemu-project/qemu/-/jobs/2430529496
I also ran it locally under Wine and didn't see a failure.
FWIW I'm about to send another block pull request and it will include
these patches again. Feel free to wait for the next pull request.
Stefan
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2022-04-25 8:48 Stefan Hajnoczi
2022-04-25 20:35 ` Richard Henderson
0 siblings, 1 reply; 29+ messages in thread
From: Stefan Hajnoczi @ 2022-04-25 8:48 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi, qemu-block
The following changes since commit 9c125d17e9402c232c46610802e5931b3639d77b:
Merge tag 'pull-tcg-20220420' of https://gitlab.com/rth7680/qemu into staging (2022-04-20 16:43:11 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to d45c83328feab2e4083991693160f0a417cfd9b0:
virtiofsd: Add docs/helper for killpriv_v2/no_killpriv_v2 option (2022-04-21 12:05:15 +0200)
----------------------------------------------------------------
Pull request
Small contrib/vhost-user-blk, contrib/vhost-user-scsi, and tools/virtiofsd
improvements.
----------------------------------------------------------------
Liu Yiding (1):
virtiofsd: Add docs/helper for killpriv_v2/no_killpriv_v2 option
Sakshi Kaushik (1):
Implements Backend Program conventions for vhost-user-scsi
Stefan Hajnoczi (1):
contrib/vhost-user-blk: add missing GOptionEntry NULL terminator
docs/tools/virtiofsd.rst | 5 ++
contrib/vhost-user-blk/vhost-user-blk.c | 3 +-
contrib/vhost-user-scsi/vhost-user-scsi.c | 77 +++++++++++++++--------
tools/virtiofsd/helper.c | 3 +
4 files changed, 62 insertions(+), 26 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2022-04-25 8:48 Stefan Hajnoczi
@ 2022-04-25 20:35 ` Richard Henderson
0 siblings, 0 replies; 29+ messages in thread
From: Richard Henderson @ 2022-04-25 20:35 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Peter Maydell, qemu-block
On 4/25/22 01:48, Stefan Hajnoczi wrote:
> The following changes since commit 9c125d17e9402c232c46610802e5931b3639d77b:
>
> Merge tag 'pull-tcg-20220420' of https://gitlab.com/rth7680/qemu into staging (2022-04-20 16:43:11 -0700)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to d45c83328feab2e4083991693160f0a417cfd9b0:
>
> virtiofsd: Add docs/helper for killpriv_v2/no_killpriv_v2 option (2022-04-21 12:05:15 +0200)
>
> ----------------------------------------------------------------
> Pull request
>
> Small contrib/vhost-user-blk, contrib/vhost-user-scsi, and tools/virtiofsd
> improvements.
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate.
r~
>
> ----------------------------------------------------------------
>
> Liu Yiding (1):
> virtiofsd: Add docs/helper for killpriv_v2/no_killpriv_v2 option
>
> Sakshi Kaushik (1):
> Implements Backend Program conventions for vhost-user-scsi
>
> Stefan Hajnoczi (1):
> contrib/vhost-user-blk: add missing GOptionEntry NULL terminator
>
> docs/tools/virtiofsd.rst | 5 ++
> contrib/vhost-user-blk/vhost-user-blk.c | 3 +-
> contrib/vhost-user-scsi/vhost-user-scsi.c | 77 +++++++++++++++--------
> tools/virtiofsd/helper.c | 3 +
> 4 files changed, 62 insertions(+), 26 deletions(-)
>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2022-02-14 17:15 Stefan Hajnoczi
2022-02-15 22:40 ` Peter Maydell
0 siblings, 1 reply; 29+ messages in thread
From: Stefan Hajnoczi @ 2022-02-14 17:15 UTC (permalink / raw)
To: qemu-devel, Peter Maydell
Cc: Kevin Wolf, qemu-block, Michael S. Tsirkin, libvir-list,
Dr. David Alan Gilbert, virtio-fs, Hanna Reitz, Stefan Hajnoczi
The following changes since commit cc5ce8b8b6be83e5fe3b668dbd061ad97c534e3f:
Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220210' into staging (2022-02-13 20:33:28 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 4c41c69e05fe28c0f95f8abd2ebf407e95a4f04b:
util: adjust coroutine pool size to virtio block queue (2022-02-14 17:11:25 +0000)
----------------------------------------------------------------
Pull request
This contains coroutine poll size scaling, virtiofsd rseq seccomp for new glibc
versions, and the QEMU C virtiofsd deprecation notice.
----------------------------------------------------------------
Christian Ehrhardt (1):
tools/virtiofsd: Add rseq syscall to the seccomp allowlist
Dr. David Alan Gilbert (1):
Deprecate C virtiofsd
Hiroki Narukawa (1):
util: adjust coroutine pool size to virtio block queue
docs/about/deprecated.rst | 17 +++++++++++++++++
include/qemu/coroutine.h | 10 ++++++++++
hw/block/virtio-blk.c | 5 +++++
tools/virtiofsd/passthrough_seccomp.c | 3 +++
util/qemu-coroutine.c | 20 ++++++++++++++++----
5 files changed, 51 insertions(+), 4 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2022-02-14 17:15 Stefan Hajnoczi
@ 2022-02-15 22:40 ` Peter Maydell
0 siblings, 0 replies; 29+ messages in thread
From: Peter Maydell @ 2022-02-15 22:40 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, qemu-block, Michael S. Tsirkin, libvir-list,
qemu-devel, Dr. David Alan Gilbert, virtio-fs, Hanna Reitz
On Mon, 14 Feb 2022 at 17:44, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit cc5ce8b8b6be83e5fe3b668dbd061ad97c534e3f:
>
> Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220210' into staging (2022-02-13 20:33:28 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 4c41c69e05fe28c0f95f8abd2ebf407e95a4f04b:
>
> util: adjust coroutine pool size to virtio block queue (2022-02-14 17:11:25 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> This contains coroutine poll size scaling, virtiofsd rseq seccomp for new glibc
> versions, and the QEMU C virtiofsd deprecation notice.
>
> ----------------------------------------------------------------
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2021-12-22 16:52 Hanna Reitz
2021-12-23 2:33 ` Richard Henderson
0 siblings, 1 reply; 29+ messages in thread
From: Hanna Reitz @ 2021-12-22 16:52 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, Hanna Reitz, Richard Henderson, qemu-devel
The following changes since commit 8c5f94cd4182753959c8be8de415120dc879d8f0:
Merge tag 'pull-loong-20211221-2' of https://gitlab.com/rth7680/qemu into staging (2021-12-21 13:30:35 -0800)
are available in the Git repository at:
https://gitlab.com/hreitz/qemu.git tags/pull-block-2021-12-22
for you to fetch changes up to 722f87df2545b308aec49b459b028f0802b4fd9e:
iotests: check: multiprocessing support (2021-12-22 16:29:48 +0100)
----------------------------------------------------------------
Block patches:
- Added support to the iotests for running tests in several parallel
jobs (using the new -j parameter)
----------------------------------------------------------------
Vladimir Sementsov-Ogievskiy (3):
iotests/testrunner.py: add doc string for run_test()
iotests/testrunner.py: move updating last_elapsed to run_tests
iotests: check: multiprocessing support
tests/qemu-iotests/check | 4 +-
tests/qemu-iotests/testrunner.py | 86 ++++++++++++++++++++++++++++----
2 files changed, 80 insertions(+), 10 deletions(-)
--
2.33.1
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2021-12-22 16:52 Hanna Reitz
@ 2021-12-23 2:33 ` Richard Henderson
0 siblings, 0 replies; 29+ messages in thread
From: Richard Henderson @ 2021-12-23 2:33 UTC (permalink / raw)
To: Hanna Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
On 12/22/21 8:52 AM, Hanna Reitz wrote:
> The following changes since commit 8c5f94cd4182753959c8be8de415120dc879d8f0:
>
> Merge tag 'pull-loong-20211221-2' of https://gitlab.com/rth7680/qemu into staging (2021-12-21 13:30:35 -0800)
>
> are available in the Git repository at:
>
> https://gitlab.com/hreitz/qemu.git tags/pull-block-2021-12-22
>
> for you to fetch changes up to 722f87df2545b308aec49b459b028f0802b4fd9e:
>
> iotests: check: multiprocessing support (2021-12-22 16:29:48 +0100)
>
> ----------------------------------------------------------------
> Block patches:
> - Added support to the iotests for running tests in several parallel
> jobs (using the new -j parameter)
>
> ----------------------------------------------------------------
> Vladimir Sementsov-Ogievskiy (3):
> iotests/testrunner.py: add doc string for run_test()
> iotests/testrunner.py: move updating last_elapsed to run_tests
> iotests: check: multiprocessing support
>
> tests/qemu-iotests/check | 4 +-
> tests/qemu-iotests/testrunner.py | 86 ++++++++++++++++++++++++++++----
> 2 files changed, 80 insertions(+), 10 deletions(-)
Applied, thanks.
r~
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2021-11-23 15:59 Hanna Reitz
2021-11-23 17:58 ` Richard Henderson
0 siblings, 1 reply; 29+ messages in thread
From: Hanna Reitz @ 2021-11-23 15:59 UTC (permalink / raw)
To: qemu-block
Cc: Kevin Wolf, Peter Maydell, Hanna Reitz, Richard Henderson,
qemu-devel
The following changes since commit 73e0f70e097b7c92a5ce16ee35b53afe119b20d7:
Merge tag 'pull-lu-20211123' of https://gitlab.com/rth7680/qemu into staging (2021-11-23 11:33:14 +0100)
are available in the Git repository at:
https://gitlab.com/hreitz/qemu.git tags/pull-block-2021-11-23
for you to fetch changes up to 4dd218fd0717ed3cddb69c01eeb9da630107d89d:
iotests/149: Skip on unsupported ciphers (2021-11-23 15:39:12 +0100)
----------------------------------------------------------------
Block patches for 6.2-rc2:
- Fix memory leak in vvfat when vvfat_open() fails
- iotest fixes for the gnutls crypto backend
----------------------------------------------------------------
Daniella Lee (1):
block/vvfat.c fix leak when failure occurs
Hanna Reitz (2):
iotests: Use aes-128-cbc
iotests/149: Skip on unsupported ciphers
block/vvfat.c | 16 ++++++++++++----
tests/qemu-iotests/149 | 23 ++++++++++++++++++-----
tests/qemu-iotests/206 | 4 ++--
tests/qemu-iotests/206.out | 6 +++---
tests/qemu-iotests/210 | 4 ++--
tests/qemu-iotests/210.out | 6 +++---
6 files changed, 40 insertions(+), 19 deletions(-)
--
2.33.1
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2021-11-23 15:59 Hanna Reitz
@ 2021-11-23 17:58 ` Richard Henderson
0 siblings, 0 replies; 29+ messages in thread
From: Richard Henderson @ 2021-11-23 17:58 UTC (permalink / raw)
To: Hanna Reitz, qemu-block; +Cc: Kevin Wolf, Peter Maydell, qemu-devel
On 11/23/21 4:59 PM, Hanna Reitz wrote:
> The following changes since commit 73e0f70e097b7c92a5ce16ee35b53afe119b20d7:
>
> Merge tag 'pull-lu-20211123' of https://gitlab.com/rth7680/qemu into staging (2021-11-23 11:33:14 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/hreitz/qemu.git tags/pull-block-2021-11-23
>
> for you to fetch changes up to 4dd218fd0717ed3cddb69c01eeb9da630107d89d:
>
> iotests/149: Skip on unsupported ciphers (2021-11-23 15:39:12 +0100)
>
> ----------------------------------------------------------------
> Block patches for 6.2-rc2:
> - Fix memory leak in vvfat when vvfat_open() fails
> - iotest fixes for the gnutls crypto backend
>
> ----------------------------------------------------------------
> Daniella Lee (1):
> block/vvfat.c fix leak when failure occurs
>
> Hanna Reitz (2):
> iotests: Use aes-128-cbc
> iotests/149: Skip on unsupported ciphers
>
> block/vvfat.c | 16 ++++++++++++----
> tests/qemu-iotests/149 | 23 ++++++++++++++++++-----
> tests/qemu-iotests/206 | 4 ++--
> tests/qemu-iotests/206.out | 6 +++---
> tests/qemu-iotests/210 | 4 ++--
> tests/qemu-iotests/210.out | 6 +++---
> 6 files changed, 40 insertions(+), 19 deletions(-)
Applied, thanks.
r~
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2020-08-17 15:16 Stefan Hajnoczi
2020-08-21 19:08 ` Peter Maydell
0 siblings, 1 reply; 29+ messages in thread
From: Stefan Hajnoczi @ 2020-08-17 15:16 UTC (permalink / raw)
To: qemu-devel, Peter Maydell
Cc: Fam Zheng, Kevin Wolf, Eduardo Habkost, qemu-block, Max Reitz,
Stefan Hajnoczi, Cleber Rosa, Paolo Bonzini
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 44277bf914471962c9e88e09c859aae65ae109c4:
aio-posix: keep aio_notify_me disabled during polling (2020-08-13 13:34:14 =
+0100)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Stefan Hajnoczi (3):
async: rename event_notifier_dummy_cb/poll()
async: always set ctx->notified in aio_notify()
aio-posix: keep aio_notify_me disabled during polling
util/aio-posix.c | 47 +++++++++++++++++++++++++----------------------
util/async.c | 36 +++++++++++++++++++++++-------------
2 files changed, 48 insertions(+), 35 deletions(-)
--=20
2.26.2
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2020-08-17 15:16 Stefan Hajnoczi
@ 2020-08-21 19:08 ` Peter Maydell
0 siblings, 0 replies; 29+ messages in thread
From: Peter Maydell @ 2020-08-21 19:08 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Kevin Wolf, Eduardo Habkost, Qemu-block,
QEMU Developers, Max Reitz, Cleber Rosa, Paolo Bonzini
On Mon, 17 Aug 2020 at 16:16, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
>
> Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 44277bf914471962c9e88e09c859aae65ae109c4:
>
> aio-posix: keep aio_notify_me disabled during polling (2020-08-13 13:34:14 =
> +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2020-03-06 14:23 Stefan Hajnoczi
2020-03-06 17:02 ` Peter Maydell
0 siblings, 1 reply; 29+ messages in thread
From: Stefan Hajnoczi @ 2020-03-06 14:23 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Peter Maydell, Thomas Huth, qemu-block,
Alexander Bulekov, Bandan Das, Stefan Hajnoczi, Paolo Bonzini
The following changes since commit ef9f8fcbec6276414921dcd042575129a6331a2d:
Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2020-03-04-2' into staging (2020-03-05 19:39:47 +0000)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 1f40ace7b5634f93801c8474b9eb77fe2e00289c:
tests: Fix a bug with count variables (2020-03-06 10:35:15 +0000)
----------------------------------------------------------------
Pull request
These patches would have gone through Thomas Huth but he is away on leave.
----------------------------------------------------------------
Alexander Bulekov (2):
fuzz: fix style/typos in linker-script comments
qtest: fix fuzzer-related 80-char limit violations
Tianjia Zhang (1):
tests: Fix a bug with count variables
qtest.c | 3 ++-
tests/qtest/fuzz/fork_fuzz.ld | 16 ++++++++++------
tests/qtest/fuzz/qos_fuzz.c | 5 ++++-
tests/test-rcu-list.c | 2 +-
4 files changed, 17 insertions(+), 9 deletions(-)
--
2.24.1
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2020-03-06 14:23 Stefan Hajnoczi
@ 2020-03-06 17:02 ` Peter Maydell
0 siblings, 0 replies; 29+ messages in thread
From: Peter Maydell @ 2020-03-06 17:02 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Laurent Vivier, Thomas Huth, Qemu-block, QEMU Developers,
Alexander Bulekov, Bandan Das, Paolo Bonzini
On Fri, 6 Mar 2020 at 14:23, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit ef9f8fcbec6276414921dcd042575129a6331a2d:
>
> Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2020-03-04-2' into staging (2020-03-05 19:39:47 +0000)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 1f40ace7b5634f93801c8474b9eb77fe2e00289c:
>
> tests: Fix a bug with count variables (2020-03-06 10:35:15 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> These patches would have gone through Thomas Huth but he is away on leave.
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PULL 0/3] Block patches
@ 2019-12-20 10:25 Stefan Hajnoczi
2020-01-03 18:50 ` Peter Maydell
0 siblings, 1 reply; 29+ messages in thread
From: Stefan Hajnoczi @ 2019-12-20 10:25 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Peter Maydell, Eduardo Habkost, qemu-block,
libvir-list, Jason Wang, Max Reitz, Stefan Hajnoczi
The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681:
Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 15:55:20 +0000)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 725fe5d10dbd4259b1853b7d253cef83a3c0d22a:
virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bh (2019-12-19 16:20:25 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Li Hangjing (1):
virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bh
Stefan Hajnoczi (2):
virtio-blk: deprecate SCSI passthrough
docs: fix rst syntax errors in unbuilt docs
docs/arm-cpu-features.rst | 6 +++---
docs/virtio-net-failover.rst | 4 ++--
docs/virtio-pmem.rst | 19 ++++++++++---------
hw/block/dataplane/virtio-blk.c | 2 +-
qemu-deprecated.texi | 11 +++++++++++
5 files changed, 27 insertions(+), 15 deletions(-)
--
2.23.0
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PULL 0/3] Block patches
2019-12-20 10:25 Stefan Hajnoczi
@ 2020-01-03 18:50 ` Peter Maydell
0 siblings, 0 replies; 29+ messages in thread
From: Peter Maydell @ 2020-01-03 18:50 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Eduardo Habkost, Qemu-block, Libvirt, Jason Wang,
QEMU Developers, Max Reitz
On Fri, 20 Dec 2019 at 10:25, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681:
>
> Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 15:55:20 +0000)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 725fe5d10dbd4259b1853b7d253cef83a3c0d22a:
>
> virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bh (2019-12-19 16:20:25 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2025-05-10 18:38 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-23 20:04 [PULL 0/3] Block patches Stefan Hajnoczi
2023-01-23 20:04 ` [PULL 1/3] util/aio: Defer disabling poll mode as long as possible Stefan Hajnoczi
2023-01-23 20:04 ` [PULL 2/3] virtio-blk: simplify virtio_blk_dma_restart_cb() Stefan Hajnoczi
2023-01-23 20:04 ` [PULL 3/3] block/blkio: Fix inclusion of required headers Stefan Hajnoczi
2023-01-24 12:24 ` [PULL 0/3] Block patches Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2025-05-08 14:22 Stefan Hajnoczi
2025-05-10 18:36 ` Stefan Hajnoczi
2023-11-06 17:10 Hanna Czenczek
2023-11-07 3:03 ` Stefan Hajnoczi
2022-10-31 18:51 Stefan Hajnoczi
2022-11-01 20:04 ` Stefan Hajnoczi
2022-05-05 8:42 Stefan Hajnoczi
2022-05-05 16:29 ` Richard Henderson
2022-05-09 10:34 ` Stefan Hajnoczi
2022-05-09 12:45 ` Stefan Hajnoczi
2022-04-25 8:48 Stefan Hajnoczi
2022-04-25 20:35 ` Richard Henderson
2022-02-14 17:15 Stefan Hajnoczi
2022-02-15 22:40 ` Peter Maydell
2021-12-22 16:52 Hanna Reitz
2021-12-23 2:33 ` Richard Henderson
2021-11-23 15:59 Hanna Reitz
2021-11-23 17:58 ` Richard Henderson
2020-08-17 15:16 Stefan Hajnoczi
2020-08-21 19:08 ` Peter Maydell
2020-03-06 14:23 Stefan Hajnoczi
2020-03-06 17:02 ` Peter Maydell
2019-12-20 10:25 Stefan Hajnoczi
2020-01-03 18:50 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).