From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
Hanna Reitz <hreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, Fiona Ebner <f.ebner@proxmox.com>
Subject: [PATCH 0/4] block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF
Date: Thu, 26 Jan 2023 15:13:57 -0500 [thread overview]
Message-ID: <20230126201401.348845-1-stefanha@redhat.com> (raw)
The first patch fixes a regression in QEMU 7.2 where detect-zeroes breaks with
virtio-blk devices due to a BDRV_REQ_REGISTERED_BUF bug. Details of the
regression can be found here:
https://gitlab.com/qemu-project/qemu/-/issues/1404
The remaining patches add a regression test that will protect this code path in
the future. The qemu-io command is extended with the new -r option that calls
blk_register_buf(). This allows a qemu-iotests test case to trigger the same
bug as virtio-blk.
Stefan Hajnoczi (4):
block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF
qemu-io: use BdrvRequestFlags instead of int
qemu-io: add -r option to register I/O buffer
iotests/detect-zeroes-registered-buf: add new test
block/io.c | 3 +
qemu-io-cmds.c | 162 ++++++++++++------
.../tests/detect-zeroes-registered-buf | 58 +++++++
.../tests/detect-zeroes-registered-buf.out | 7 +
4 files changed, 178 insertions(+), 52 deletions(-)
create mode 100755 tests/qemu-iotests/tests/detect-zeroes-registered-buf
create mode 100644 tests/qemu-iotests/tests/detect-zeroes-registered-buf.out
--
2.39.1
next reply other threads:[~2023-01-26 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 20:13 Stefan Hajnoczi [this message]
2023-01-26 20:13 ` [PATCH 1/4] block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF Stefan Hajnoczi
2023-01-27 8:23 ` Fiona Ebner
2023-01-26 20:13 ` [PATCH 2/4] qemu-io: use BdrvRequestFlags instead of int Stefan Hajnoczi
2023-01-27 23:18 ` Eric Blake
2023-01-26 20:14 ` [PATCH 3/4] qemu-io: add -r option to register I/O buffer Stefan Hajnoczi
2023-01-27 23:24 ` Eric Blake
2023-01-30 20:55 ` Stefan Hajnoczi
2023-01-26 20:14 ` [PATCH 4/4] iotests/detect-zeroes-registered-buf: add new test Stefan Hajnoczi
2023-01-27 23:25 ` Eric Blake
2023-01-30 20:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126201401.348845-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).