From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: qemu-devel@nongnu.org
Cc: kbastian@mail.uni-paderborn.de, anton.kochkov@proton.me
Subject: [PATCH 5/5] target/tricore: Fix OPC2_32_BO_LD_BU_PREINC
Date: Fri, 27 Jan 2023 13:03:28 +0100 [thread overview]
Message-ID: <20230127120328.2520624-6-kbastian@mail.uni-paderborn.de> (raw)
In-Reply-To: <20230127120328.2520624-1-kbastian@mail.uni-paderborn.de>
we were sign extending the result of the load, while the instruction
clearly states that the result should be unsigned.
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target/tricore/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index b8e0969079..c17d19b83e 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -4964,7 +4964,7 @@ static void decode_bo_addrmode_ld_post_pre_base(DisasContext *ctx)
tcg_gen_addi_tl(cpu_gpr_a[r2], cpu_gpr_a[r2], off10);
break;
case OPC2_32_BO_LD_BU_PREINC:
- gen_ld_preincr(ctx, cpu_gpr_d[r1], cpu_gpr_a[r2], off10, MO_SB);
+ gen_ld_preincr(ctx, cpu_gpr_d[r1], cpu_gpr_a[r2], off10, MO_UB);
break;
case OPC2_32_BO_LD_D_SHORTOFF:
CHECK_REG_PAIR(r1);
--
2.39.1
next prev parent reply other threads:[~2023-01-27 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 12:03 [PATCH 0/5] TriCore instruction bugfixes Bastian Koppelmann
2023-01-27 12:03 ` [PATCH 1/5] target/tricore: Fix OPC2_32_RCRW_IMASK translation Bastian Koppelmann
2023-01-27 18:11 ` Richard Henderson
2023-01-27 12:03 ` [PATCH 2/5] target/tricore: Fix OPC2_32_RCRW_INSERT translation Bastian Koppelmann
2023-01-27 18:13 ` Richard Henderson
2023-01-27 12:03 ` [PATCH 3/5] target/tricore: Fix RRPW_DEXTR Bastian Koppelmann
2023-01-27 18:21 ` Richard Henderson
2023-01-27 12:03 ` [PATCH 4/5] target/tricore: Fix OPC2_32_RRRR_DEXTR Bastian Koppelmann
2023-01-27 18:25 ` Richard Henderson
2023-01-27 12:03 ` Bastian Koppelmann [this message]
2023-01-27 18:25 ` [PATCH 5/5] target/tricore: Fix OPC2_32_BO_LD_BU_PREINC Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127120328.2520624-6-kbastian@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=anton.kochkov@proton.me \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).