qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, pbonzini@redhat.com,
	kwolf@redhat.com, hreitz@redhat.com, imp@bsdimp.com,
	kevans@freebsd.org, berrange@redhat.com, groug@kaod.org,
	qemu_oss@crudebyte.com, mst@redhat.com, philmd@linaro.org,
	peter.maydell@linaro.org, alistair@alistair23.me,
	jasowang@redhat.com, jonathan.cameron@huawei.com,
	kbastian@mail.uni-paderborn.de, quintela@redhat.com,
	dgilbert@redhat.com, michael.roth@amd.com, kkostiuk@redhat.com,
	tsimpson@quicinc.com, palmer@dabbelt.com, bin.meng@windriver.com,
	qemu-block@nongnu.org, qemu-arm@nongnu.org,
	qemu-riscv@nongnu.org, Eric Blake <eblake@redhat.com>
Subject: [PATCH v5 03/20] scripts/clean-includes: Skip symbolic links
Date: Mon, 30 Jan 2023 14:21:39 +0100	[thread overview]
Message-ID: <20230130132156.1868019-4-armbru@redhat.com> (raw)
In-Reply-To: <20230130132156.1868019-1-armbru@redhat.com>

When a symbolic link points to a file that needs cleaning, the script
replaces the link with a cleaned regular file.  Not wanted; skip them.

We have a few symbolic links under subprojects/libvduse/ and
subprojects/libvhost-user/.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 scripts/clean-includes | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/clean-includes b/scripts/clean-includes
index 8e8420d785..f0466a6262 100755
--- a/scripts/clean-includes
+++ b/scripts/clean-includes
@@ -113,6 +113,10 @@ EOT
 
 files=
 for f in "$@"; do
+  if [ -L "$f" ]; then
+      echo "SKIPPING $f (symbolic link)"
+      continue
+  fi
   case "$f" in
     *.c.inc)
       # These aren't standalone C source files
-- 
2.39.0



  parent reply	other threads:[~2023-01-30 13:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 13:21 [PATCH v5 00/20] Clean up includes Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 01/20] scripts/clean-includes: Fully skip / ignore files Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 02/20] scripts/clean-includes: Don't claim duplicate headers found when not Markus Armbruster
2023-01-30 13:21 ` Markus Armbruster [this message]
2023-01-30 13:21 ` [PATCH v5 04/20] scripts/clean-includes: Improve --git commit message Markus Armbruster
2023-01-30 14:12   ` Juan Quintela
2023-02-01 12:49     ` Markus Armbruster
2023-02-01 13:14       ` Juan Quintela
2023-02-01 13:44         ` Markus Armbruster
2023-02-01 14:54           ` Juan Quintela
2023-02-02  9:00             ` Markus Armbruster
2023-02-02 10:54               ` Juan Quintela
2023-01-30 13:21 ` [PATCH v5 05/20] bsd-user: Clean up includes Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 06/20] crypto: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 07/20] hw/cxl: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 08/20] hw/input: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 09/20] hw/tricore: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 10/20] qga: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 11/20] migration: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 12/20] net: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 13/20] target/hexagon: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 14/20] riscv: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 15/20] block: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 16/20] accel: " Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 17/20] Fix non-first inclusions of qemu/osdep.h Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 18/20] Don't include headers already included by qemu/osdep.h Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 19/20] 9p: Drop superfluous include of linux/limits.h Markus Armbruster
2023-01-30 13:21 ` [PATCH v5 20/20] Drop duplicate #include Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230130132156.1868019-4-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=berrange@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=groug@kaod.org \
    --cc=hreitz@redhat.com \
    --cc=imp@bsdimp.com \
    --cc=jasowang@redhat.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kevans@freebsd.org \
    --cc=kkostiuk@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=mst@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=tsimpson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).