From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 20/27] tests/qtest/vnc-display-test: Disable on Darwin
Date: Tue, 31 Jan 2023 11:11:58 +0100 [thread overview]
Message-ID: <20230131101205.1499867-21-thuth@redhat.com> (raw)
In-Reply-To: <20230131101205.1499867-1-thuth@redhat.com>
From: Philippe Mathieu-Daudé <philmd@linaro.org>
This test is failing in gtk-vnc on Darwin:
$ make check-qtest-aarch64
...
19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test
ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672
While QEMU picks the sigaltstack coroutine backend, gtk-vnc uses
the ucontext coroutine backend, which might be broken on Darwin.
Disable this test (current problem being investigated in this thread:
https://lore.kernel.org/qemu-devel/Y8kw6X6keB5l53nl@redhat.com/).
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230119120514.28778-4-philmd@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/vnc-display-test.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c
index df468c7b22..e52a4326ec 100644
--- a/tests/qtest/vnc-display-test.c
+++ b/tests/qtest/vnc-display-test.c
@@ -19,7 +19,7 @@ typedef struct Test {
GMainLoop *loop;
} Test;
-#if !defined(WIN32)
+#if !defined(WIN32) && !defined(CONFIG_DARWIN)
static void on_vnc_error(VncConnection* self,
const char* msg)
@@ -41,6 +41,9 @@ test_setup(Test *test)
#ifdef WIN32
g_test_skip("Not supported on Windows yet");
return false;
+#elif defined(CONFIG_DARWIN)
+ g_test_skip("Broken on Darwin");
+ return false;
#else
int pair[2];
--
2.31.1
next prev parent reply other threads:[~2023-01-31 10:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 10:11 [PULL 00/27] qtest and misc patches Thomas Huth
2023-01-31 10:11 ` [PULL 01/27] tests/qtest: netdev: test stream and dgram backends Thomas Huth
2023-01-31 10:11 ` [PULL 02/27] tests/qtest/qom-test: Stop spamming the test log Thomas Huth
2023-01-31 10:11 ` [PULL 03/27] tests/qtest/bios-tables-test: Make the test less verbose by default Thomas Huth
2023-01-31 10:11 ` [PULL 04/27] hw/misc/sifive_u_otp: Remove the deprecated OTP config with '-drive if=none' Thomas Huth
2023-01-31 10:11 ` [PULL 05/27] configs/targets/nios2-softmmu: Add TARGET_NEED_FDT=y to the nios2 config Thomas Huth
2023-01-31 10:11 ` [PULL 06/27] travis.yml: Use the libfdt from the distro instead of the submodule Thomas Huth
2023-01-31 10:11 ` [PULL 07/27] travis.yml: Remove the generic addons section Thomas Huth
2023-01-31 10:11 ` [PULL 08/27] tests/docker/dockerfiles: Add libfdt to the i386 and to the riscv64 container Thomas Huth
2023-01-31 10:11 ` [PULL 09/27] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap() Thomas Huth
2023-01-31 10:11 ` [PULL 10/27] qemu/bswap: Replace bswapXXs() " Thomas Huth
2023-01-31 10:11 ` [PULL 11/27] qemu/bswap: Remove <byteswap.h> dependency Thomas Huth
2023-01-31 10:11 ` [PULL 12/27] qemu/bswap: Use compiler __builtin_bswap() on Haiku Thomas Huth
2023-01-31 10:11 ` [PULL 13/27] qemu/bswap: Use compiler __builtin_bswap() on FreeBSD Thomas Huth
2023-01-31 10:11 ` [PULL 14/27] qemu/bswap: Use compiler __builtin_bswap() on NetBSD Thomas Huth
2023-01-31 10:11 ` [PULL 15/27] MAINTAINERS: Abort HAXM maintenance Thomas Huth
2023-01-31 10:11 ` [PULL 16/27] docs/about/deprecated: Mark HAXM in QEMU as deprecated Thomas Huth
2023-01-31 10:11 ` [PULL 17/27] tests/tcg: Do not build/run TCG tests if TCG is disabled Thomas Huth
2023-01-31 10:11 ` [PULL 18/27] tests/qtest/vnc-display-test: Suppress build warnings on Windows Thomas Huth
2023-01-31 10:11 ` [PULL 19/27] tests/qtest/vnc-display-test: Use the 'none' machine Thomas Huth
2023-01-31 10:11 ` Thomas Huth [this message]
2023-01-31 10:11 ` [PULL 21/27] tests/qtest/boot-serial-test: Constify tests[] array Thomas Huth
2023-01-31 10:12 ` [PULL 22/27] docs/s390x/pcidevices: document pci devices on s390x Thomas Huth
2023-01-31 10:12 ` [PULL 23/27] qapi, audio: add query-audiodev command Thomas Huth
2023-01-31 10:12 ` [PULL 24/27] qapi, audio: Make introspection reflect build configuration more closely Thomas Huth
2023-01-31 10:12 ` [PULL 25/27] gitlab-ci.d/buildtest: Remove ppc-softmmu from the clang-system job Thomas Huth
2023-01-31 10:12 ` [PULL 26/27] tests/qtest/display-vga-test: Add proper checks if a device is available Thomas Huth
2023-01-31 10:12 ` [PULL 27/27] gitlab-ci.d/buildtest: Merge the --without-default-* jobs Thomas Huth
2023-02-02 18:00 ` [PULL 00/27] qtest and misc patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131101205.1499867-21-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).