From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32E98C636CD for ; Wed, 1 Feb 2023 15:29:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNF1l-0001VO-US; Wed, 01 Feb 2023 10:28:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNF1l-0001V8-0L for qemu-devel@nongnu.org; Wed, 01 Feb 2023 10:28:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNF1i-00070K-Re for qemu-devel@nongnu.org; Wed, 01 Feb 2023 10:28:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675265277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+Ax+vLYlU7rwGU9o8QTQC+ruOTBHfslKKW0Im1G+vQk=; b=ZI5pteao4OtzMNd2KkkZXv8xsLCO0Lmp/6S6IwhMFFvuJYSzAGgk7y2H8wOAGxz9LFtQVC J0y/ADrUD3KjjVbDUoTCW9hl4BoKYM7S0t5fifF6M4RCCYSrxA1gaRG/iOJiVofgHJgz2Q un0Dy3bqfATMm6y/0S55b52mSCc40rQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-341-ev0vCcBFPOOqT8Bu84WRPA-1; Wed, 01 Feb 2023 10:27:56 -0500 X-MC-Unique: ev0vCcBFPOOqT8Bu84WRPA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 393F980280B; Wed, 1 Feb 2023 15:27:54 +0000 (UTC) Received: from localhost (unknown [10.39.195.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91B9A404BEC0; Wed, 1 Feb 2023 15:27:53 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Hanna Reitz , Fam Zheng , Fiona Ebner Subject: [PATCH v3 0/4] block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF Date: Wed, 1 Feb 2023 10:27:47 -0500 Message-Id: <20230201152751.270508-1-stefanha@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org v3: - Restore alphabetical order in getopt strings [Eric] v2: - Add comment explaining unbalanced error code path in qemu_io_alloc_from_file() [Eric] - List options alphabetically in help output [Eric] - Add Tested-by/Reviewed-by - CC qemu-stable on the fix The first patch fixes a regression in QEMU 7.2 where detect-zeroes breaks with virtio-blk devices due to a BDRV_REQ_REGISTERED_BUF bug. Details of the regression can be found here: https://gitlab.com/qemu-project/qemu/-/issues/1404 The remaining patches add a regression test that will protect this code path in the future. The qemu-io command is extended with the new -r option that calls blk_register_buf(). This allows a qemu-iotests test case to trigger the same bug as virtio-blk. Stefan Hajnoczi (4): block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF qemu-io: use BdrvRequestFlags instead of int qemu-io: add -r option to register I/O buffer iotests/detect-zeroes-registered-buf: add new test block/io.c | 3 + qemu-io-cmds.c | 180 ++++++++++++------ .../tests/detect-zeroes-registered-buf | 58 ++++++ .../tests/detect-zeroes-registered-buf.out | 7 + 4 files changed, 189 insertions(+), 59 deletions(-) create mode 100755 tests/qemu-iotests/tests/detect-zeroes-registered-buf create mode 100644 tests/qemu-iotests/tests/detect-zeroes-registered-buf.out -- 2.39.1