From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Manish Mishra <manish.mishra@nutanix.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>
Subject: [PATCH v2 0/3] migration: Fix disorder of channel creations
Date: Thu, 2 Feb 2023 16:24:55 -0500 [thread overview]
Message-ID: <20230202212458.726496-1-peterx@redhat.com> (raw)
This patchset is rebased to Juan's latest pull request:
Based-on: <20230202160640.2300-1-quintela@redhat.com>
I can trigger disordered connections with preempt mode postcopy (1 out of a
few attemps), which can cause migration to hang during precopy phase, if
e.g. I set the NIC packet loss rate to 50%.
Patch 1 is IMHO a cleanup that I'd think good to have even without patch
2/3. Patch 3 actually fixes the ordering issue. For each of the patch,
please refer to the commit message and comments in-code.
Any comment welcomed, thanks.
Peter Xu (3):
migration: Rework multi-channel checks on URI
migration: Add a semaphore to count PONGs
migration: Postpone postcopy preempt channel to be after main
migration/migration.c | 121 ++++++++++++++++++++++++++-------------
migration/migration.h | 15 ++++-
migration/multifd.c | 12 +---
migration/postcopy-ram.c | 31 +++++-----
migration/postcopy-ram.h | 4 +-
migration/savevm.c | 6 +-
6 files changed, 117 insertions(+), 72 deletions(-)
--
2.37.3
next reply other threads:[~2023-02-02 21:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 21:24 Peter Xu [this message]
2023-02-02 21:24 ` [PATCH v2 1/3] migration: Rework multi-channel checks on URI Peter Xu
2023-02-08 19:19 ` Juan Quintela
2023-02-08 20:03 ` Peter Xu
2023-02-02 21:24 ` [PATCH v2 2/3] migration: Add a semaphore to count PONGs Peter Xu
2023-02-08 19:19 ` Juan Quintela
2023-02-02 21:24 ` [PATCH v2 3/3] migration: Postpone postcopy preempt channel to be after main Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202212458.726496-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=manish.mishra@nutanix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).