From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"Markus Armbruster" <armbru@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Subject: [PATCH 1/9] hw/i386/sgx: Do not open-code qdev_realize_and_unref()
Date: Fri, 3 Feb 2023 12:36:42 +0100 [thread overview]
Message-ID: <20230203113650.78146-2-philmd@linaro.org> (raw)
In-Reply-To: <20230203113650.78146-1-philmd@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/i386/sgx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/i386/sgx.c b/hw/i386/sgx.c
index db004d17a6..5ddc5d7ea2 100644
--- a/hw/i386/sgx.c
+++ b/hw/i386/sgx.c
@@ -299,7 +299,7 @@ void pc_machine_init_sgx_epc(PCMachineState *pcms)
&sgx_epc->mr);
for (list = x86ms->sgx_epc_list; list; list = list->next) {
- obj = object_new("sgx-epc");
+ obj = object_new(TYPE_SGX_EPC);
/* set the memdev link with memory backend */
object_property_parse(obj, SGX_EPC_MEMDEV_PROP, list->value->memdev,
@@ -307,8 +307,7 @@ void pc_machine_init_sgx_epc(PCMachineState *pcms)
/* set the numa node property for sgx epc object */
object_property_set_uint(obj, SGX_EPC_NUMA_NODE_PROP, list->value->node,
&error_fatal);
- object_property_set_bool(obj, "realized", true, &error_fatal);
- object_unref(obj);
+ qdev_realize_and_unref(DEVICE(obj), NULL, &error_fatal);
}
if ((sgx_epc->base + sgx_epc->size) < sgx_epc->base) {
--
2.38.1
next prev parent reply other threads:[~2023-02-03 11:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 11:36 [PATCH 0/9] hw: Use QOM alias properties and few QOM/QDev cleanups Philippe Mathieu-Daudé
2023-02-03 11:36 ` Philippe Mathieu-Daudé [this message]
2023-02-03 12:32 ` [PATCH 1/9] hw/i386/sgx: Do not open-code qdev_realize_and_unref() Markus Armbruster
2023-02-03 13:15 ` Philippe Mathieu-Daudé
2023-02-03 13:36 ` Markus Armbruster
2023-02-03 11:36 ` [PATCH 2/9] hw/ppc/sam460ex: Correctly set MAL properties Philippe Mathieu-Daudé
2023-02-03 12:50 ` BALATON Zoltan
2023-02-03 11:36 ` [PATCH 3/9] hw/arm/nrf51: QOM-alias 'flash-size' property in SoC object Philippe Mathieu-Daudé
2023-02-03 11:36 ` [PATCH 4/9] hw/arm/fsl-imx: QOM-alias 'phy-num' " Philippe Mathieu-Daudé
2023-02-03 11:36 ` [PATCH 5/9] hw/usb/hcd-ohci: Include missing 'sysbus.h' header Philippe Mathieu-Daudé
2023-02-03 12:33 ` Markus Armbruster
2023-02-03 11:36 ` [PATCH 6/9] hw/display/sm501: QOM-alias 'dma-offset' property in chipset object Philippe Mathieu-Daudé
2023-02-03 13:05 ` BALATON Zoltan
2023-02-03 13:21 ` Philippe Mathieu-Daudé
2023-02-03 13:50 ` BALATON Zoltan
2023-02-03 14:11 ` Philippe Mathieu-Daudé
2023-02-03 14:12 ` BALATON Zoltan
2023-02-03 11:36 ` [PATCH 7/9] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h' Philippe Mathieu-Daudé
2023-02-03 11:36 ` [PATCH 8/9] hw/mips: Declare all length properties as unsigned Philippe Mathieu-Daudé
2023-02-03 11:36 ` [RFC PATCH 9/9] hw/mips/itu: Pass SAAR using QOM link property Philippe Mathieu-Daudé
2023-02-13 14:01 ` Jiaxun Yang
2023-02-05 23:29 ` [PATCH 0/9] hw: Use QOM alias properties and few QOM/QDev cleanups Mark Cave-Ayland
2023-02-06 15:27 ` Philippe Mathieu-Daudé
2023-02-06 21:54 ` Mark Cave-Ayland
2023-02-06 23:04 ` Philippe Mathieu-Daudé
2023-02-07 20:35 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203113650.78146-2-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).