From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
qemu-riscv@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 01/19] NOTFORMERGE scripts/coccinelle: Add qom-qdev-prop.cocci
Date: Fri, 3 Feb 2023 19:08:56 +0100 [thread overview]
Message-ID: <20230203180914.49112-2-philmd@linaro.org> (raw)
In-Reply-To: <20230203180914.49112-1-philmd@linaro.org>
Script I used to generate the following patches. This is
not an automatic conversion as object_property_set_[u]int()
does not specify the type size. Each integer property must
then be converted manually. Therefore this script doesn't
seem relevant to be committed in the repository.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
scripts/coccinelle/qom-qdev-prop.cocci | 259 +++++++++++++++++++++++++
1 file changed, 259 insertions(+)
create mode 100644 scripts/coccinelle/qom-qdev-prop.cocci
diff --git a/scripts/coccinelle/qom-qdev-prop.cocci b/scripts/coccinelle/qom-qdev-prop.cocci
new file mode 100644
index 0000000000..21e6ed2b33
--- /dev/null
+++ b/scripts/coccinelle/qom-qdev-prop.cocci
@@ -0,0 +1,259 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// SPDX-FileCopyrightText: Linaro Limited 2023
+//
+// Convert QOM set_property() API to QDev set_prop() API equivalent
+//
+// Only bool / string / link properties are automatically converted.
+// Integer properties must be converted manually, since the QOM
+// object_property_set_[u]int() helpers don't specify the type size.
+
+
+//
+// bool
+//
+
+// bool OBJECT
+@@
+typedef DeviceState;
+identifier dev;
+expression prop, val;
+@@
+ DeviceState *dev;
+ ...
+- object_property_set_bool(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_bit(dev, prop, val);
+
+// bool dev
+@@
+expression dev;
+expression prop, val;
+@@
+- object_property_set_bool(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_bit(dev, prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(dev), ...);
+|
+ qdev_realize(dev, ...);
+|
+ qdev_realize_and_unref(dev, ...);
+)
+
+// bool DEVICE(dev)
+@@
+expression dev;
+expression prop, val;
+@@
+- object_property_set_bool(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_bit(DEVICE(dev), prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(dev), ...);
+|
+ qdev_realize(DEVICE(dev), ...);
+|
+ qdev_realize_and_unref(DEVICE(dev), ...);
+)
+
+// bool DEVICE(obj)
+@@
+expression obj;
+expression prop, val;
+@@
+- object_property_set_bool(obj, prop, val, ... /* &error_abort */);
++ qdev_prop_set_bit(DEVICE(obj), prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(obj), ...);
+|
+ qdev_realize(DEVICE(obj), ...);
+|
+ qdev_realize_and_unref(DEVICE(obj), ...);
+)
+
+
+//
+// str
+//
+
+// str OBJECT
+@@
+typedef DeviceState;
+identifier dev;
+expression prop, val;
+@@
+ DeviceState *dev;
+ ...
+- object_property_set_str(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_string(dev, prop, val);
+
+// str dev
+@@
+expression dev;
+expression prop, val;
+@@
+- object_property_set_str(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_string(dev, prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(dev), ...);
+|
+ qdev_realize(dev, ...);
+|
+ qdev_realize_and_unref(dev, ...);
+)
+
+// str DEVICE(dev)
+@@
+expression dev;
+expression prop, val;
+@@
+- object_property_set_str(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_string(DEVICE(dev), prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(dev), ...);
+|
+ qdev_realize(DEVICE(dev), ...);
+|
+ qdev_realize_and_unref(DEVICE(dev), ...);
+)
+
+// str DEVICE(obj)
+@@
+expression obj;
+expression prop, val;
+@@
+- object_property_set_str(obj, prop, val, ... /* &error_abort */);
++ qdev_prop_set_string(DEVICE(obj), prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(obj), ...);
+|
+ qdev_realize(DEVICE(obj), ...);
+|
+ qdev_realize_and_unref(DEVICE(obj), ...);
+)
+
+
+// int OBJECT
+@@
+typedef DeviceState;
+identifier dev;
+expression prop, val;
+@@
+ DeviceState *dev;
+ ...
+- object_property_set_int(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_XintXX(dev, prop, val);
+
+// int dev
+@@
+expression dev;
+expression prop, val;
+@@
+- object_property_set_int(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_XintXX(dev, prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(dev), ...);
+|
+ qdev_realize(dev, ...);
+|
+ qdev_realize_and_unref(dev, ...);
+)
+
+// int DEVICE(dev)
+@@
+expression dev;
+expression prop, val;
+@@
+- object_property_set_int(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_XintXX(DEVICE(dev), prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(dev), ...);
+|
+ qdev_realize(DEVICE(dev), ...);
+|
+ qdev_realize_and_unref(DEVICE(dev), ...);
+)
+
+// int DEVICE(obj)
+@@
+expression obj;
+expression prop, val;
+@@
+- object_property_set_int(obj, prop, val, ... /* &error_abort */);
++ qdev_prop_set_XintXX(DEVICE(obj), prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(obj), ...);
+|
+ qdev_realize(DEVICE(obj), ...);
+|
+ qdev_realize_and_unref(DEVICE(obj), ...);
+)
+
+//
+// link
+//
+
+// link OBJECT
+@@
+typedef DeviceState;
+identifier dev;
+expression prop, val;
+@@
+ DeviceState *dev;
+ ...
+- object_property_set_link(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_link(dev, prop, val);
+
+// link dev
+@@
+expression dev;
+expression prop, val;
+@@
+- object_property_set_link(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_link(dev, prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(dev), ...);
+|
+ qdev_realize(dev, ...);
+|
+ qdev_realize_and_unref(dev, ...);
+)
+
+// link DEVICE(dev)
+@@
+expression dev;
+expression prop, val;
+@@
+- object_property_set_link(OBJECT(dev), prop, val, ... /* &error_abort */);
++ qdev_prop_set_link(DEVICE(dev), prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(dev), ...);
+|
+ qdev_realize(DEVICE(dev), ...);
+|
+ qdev_realize_and_unref(DEVICE(dev), ...);
+)
+
+// link DEVICE(obj)
+@@
+expression obj;
+expression prop, val;
+@@
+- object_property_set_link(obj, prop, val, ... /* &error_abort */);
++ qdev_prop_set_link(DEVICE(obj), prop, val);
+ ...
+(
+ sysbus_realize(SYS_BUS_DEVICE(obj), ...);
+|
+ qdev_realize(DEVICE(obj), ...);
+|
+ qdev_realize_and_unref(DEVICE(obj), ...);
+)
--
2.38.1
next prev parent reply other threads:[~2023-02-03 18:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 18:08 [PATCH 00/19] hw: Set QDev properties using QDev API (part 1/3) Philippe Mathieu-Daudé
2023-02-03 18:08 ` Philippe Mathieu-Daudé [this message]
2023-02-03 18:08 ` [PATCH 02/19] hw/qdev: Introduce qdev_prop_set_link() Philippe Mathieu-Daudé
2023-02-05 22:53 ` Mark Cave-Ayland
2023-02-03 18:08 ` [PATCH 03/19] hw/acpi: Set QDev properties using QDev API Philippe Mathieu-Daudé
2023-03-01 14:07 ` Igor Mammedov
2023-02-03 18:08 ` [PATCH 04/19] hw/audio: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 05/19] hw/core/numa: " Philippe Mathieu-Daudé
2023-03-01 14:09 ` Igor Mammedov
2023-02-03 18:09 ` [PATCH 06/19] hw/core/gpio: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 07/19] hw/scsi: " Philippe Mathieu-Daudé
2023-03-01 14:13 ` Igor Mammedov
2023-02-03 18:09 ` [PATCH 08/19] hw/usb: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 09/19] hw/virtio: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 10/19] hw/avr: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 11/19] hw/hppa: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 12/19] hw/i386: " Philippe Mathieu-Daudé
2023-02-04 13:23 ` Bernhard Beschow
2023-03-01 14:00 ` Igor Mammedov
2023-02-03 18:09 ` [PATCH 13/19] hw/m68k: " Philippe Mathieu-Daudé
2023-02-05 9:14 ` Thomas Huth
2023-02-03 18:09 ` [PATCH 14/19] hw/microblaze: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 15/19] hw/mips: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 16/19] hw/nios2: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [RFC PATCH 17/19] hw/riscv: " Philippe Mathieu-Daudé
2023-02-03 18:09 ` [PATCH 18/19] hw/rx: " Philippe Mathieu-Daudé
2023-02-06 13:01 ` Yoshinori Sato
2023-02-03 18:09 ` [PATCH 19/19] hw/sparc: " Philippe Mathieu-Daudé
2023-02-03 18:12 ` [PATCH 00/19] hw: Set QDev properties using QDev API (part 1/3) Philippe Mathieu-Daudé
2023-02-03 18:52 ` BALATON Zoltan
2023-03-01 13:42 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203180914.49112-2-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).