From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Cindy Lu <lulu@redhat.com>,
Liuxiangdong <liuxiangdong5@huawei.com>,
alvaro.karsz@solid-run.com, Zhu Lingshan <lingshan.zhu@intel.com>,
Jason Wang <jasowang@redhat.com>,
longpeng2@huawei.com, "Michael S. Tsirkin" <mst@redhat.com>,
Shannon Nelson <snelson@pensando.io>,
Eli Cohen <eli@mellanox.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
virtualization@lists.linux-foundation.org,
Parav Pandit <parav@mellanox.com>,
si-wei.liu@oracle.com, Laurent Vivier <lvivier@redhat.com>,
Gautam Dawar <gdawar@xilinx.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>
Subject: [PATCH 10/13] vdpa: block migration if device has unsupported features
Date: Fri, 3 Feb 2023 20:11:39 +0100 [thread overview]
Message-ID: <20230203191142.362623-11-eperezma@redhat.com> (raw)
In-Reply-To: <20230203191142.362623-1-eperezma@redhat.com>
A vdpa net device must initialize with SVQ in order to be migratable at
this moment, and initialization code verifies some conditions. If the
device is not initialized with the x-svq parameter, it will not expose
_F_LOG so the vhost subsystem will block VM migration from its
initialization.
Next patches change this, so we need to verify migration conditions
differently.
QEMU only supports a subset of net features in SVQ, and it cannot
migrate state that cannot track or restore in the destination. Add a
migration blocker if the device offer an unsupported feature.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
net/vhost-vdpa.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 309861e56c..a0c4d5de2c 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -952,6 +952,15 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
iova_range);
if (!ncs[i])
goto err;
+
+ if (i == 0) {
+ VhostVDPAState *s = DO_UPCAST(VhostVDPAState, nc, ncs[0]);
+
+ if (!s->vhost_vdpa.dev->migration_blocker) {
+ vhost_vdpa_net_valid_svq_features(features,
+ &s->vhost_vdpa.dev->migration_blocker);
+ }
+ }
}
if (has_cvq) {
--
2.31.1
next prev parent reply other threads:[~2023-02-03 19:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 19:11 [PATCH 00/13] Dynamycally switch to vhost shadow virtqueues at vdpa net migration Eugenio Pérez
2023-02-03 19:11 ` [PATCH 01/13] vdpa net: move iova tree creation from init to start Eugenio Pérez
2023-02-03 19:11 ` [PATCH 02/13] vdpa: Negotiate _F_SUSPEND feature Eugenio Pérez
2023-02-03 19:11 ` [PATCH 03/13] vdpa: add vhost_vdpa_suspend Eugenio Pérez
2023-02-03 19:11 ` [PATCH 04/13] vdpa: move vhost reset after get vring base Eugenio Pérez
2023-02-03 19:11 ` [PATCH 05/13] vdpa: rewind at get_base, not set_base Eugenio Pérez
2023-02-03 19:11 ` [PATCH 06/13] vdpa net: allow VHOST_F_LOG_ALL Eugenio Pérez
2023-02-03 19:11 ` [PATCH 07/13] vdpa: add vdpa net migration state notifier Eugenio Pérez
2023-02-03 19:11 ` [PATCH 08/13] vdpa: disable RAM block discard only for the first device Eugenio Pérez
2023-02-03 19:11 ` [PATCH 09/13] vdpa net: block migration if the device has CVQ Eugenio Pérez
2023-02-03 19:11 ` Eugenio Pérez [this message]
2023-02-03 19:11 ` [PATCH 11/13] vdpa: block migration if dev does not have _F_SUSPEND Eugenio Pérez
2023-02-03 19:11 ` [PATCH 12/13] vdpa: block migration if SVQ does not admit a feature Eugenio Pérez
2023-02-03 19:11 ` [PATCH 13/13] vdpa: return VHOST_F_LOG_ALL in vhost-vdpa devices Eugenio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203191142.362623-11-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=arei.gonglei@huawei.com \
--cc=eli@mellanox.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=liuxiangdong5@huawei.com \
--cc=longpeng2@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=snelson@pensando.io \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).