From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "BALATON Zoltan" <balaton@eik.bme.hu>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-ppc@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Greg Kurz" <groug@kaod.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 0/5] hw/ppc: Set QDev properties using QDev API (part 2/3)
Date: Fri, 3 Feb 2023 22:16:18 +0100 [thread overview]
Message-ID: <20230203211623.50930-1-philmd@linaro.org> (raw)
part 1 [*] cover:
--
QEMU provides the QOM API for core objects.
Devices are modelled on top of QOM as QDev objects.
There is no point in using the lower level QOM API with
QDev; it makes the code more complex and harder to review.
I first converted all the calls using errp=&error_abort or
&errp=NULL, then noticed the other uses weren't really
consistent.
A QDev property defined with the DEFINE_PROP_xxx() macros
is always available, thus can't fail. When using hot-plug
devices, we only need to check for optional properties
registered at runtime with the object_property_add_XXX()
API. Some are even always registered in device instance_init.
--
In this series PPC hw is converted. Only one call site in PNV
forwards the Error* argument and its conversion is justified.
Based-on: <20230203180914.49112-1-philmd@linaro.org>
(in particular [PATCH 02/19] hw/qdev: Introduce qdev_prop_set_link():
https://lore.kernel.org/qemu-devel/20230203180914.49112-3-philmd@linaro.org/)
[*] https://lore.kernel.org/qemu-devel/20230203180914.49112-1-philmd@linaro.org/
Philippe Mathieu-Daudé (5):
hw/misc/macio: Set QDev properties using QDev API
hw/pci-host/raven: Set QDev properties using QDev API
hw/ppc/ppc4xx: Set QDev properties using QDev API
hw/ppc/spapr: Set QDev properties using QDev API
hw/ppc/pnv: Set QDev properties using QDev API
hw/intc/pnv_xive.c | 11 ++++------
hw/intc/pnv_xive2.c | 15 +++++---------
hw/intc/spapr_xive.c | 11 ++++------
hw/intc/xics.c | 4 ++--
hw/intc/xive.c | 4 ++--
hw/misc/macio/macio.c | 6 ++----
hw/pci-host/pnv_phb3.c | 9 +++------
hw/pci-host/pnv_phb4.c | 4 ++--
hw/pci-host/pnv_phb4_pec.c | 10 +++-------
hw/pci-host/raven.c | 6 ++----
hw/ppc/e500.c | 3 +--
hw/ppc/pnv.c | 41 ++++++++++++++++----------------------
hw/ppc/pnv_psi.c | 10 +++-------
hw/ppc/ppc405_boards.c | 6 ++----
hw/ppc/ppc405_uc.c | 6 +++---
hw/ppc/ppc440_bamboo.c | 3 +--
hw/ppc/ppc4xx_devs.c | 2 +-
hw/ppc/sam460ex.c | 5 ++---
hw/ppc/spapr_irq.c | 8 +++-----
19 files changed, 62 insertions(+), 102 deletions(-)
--
2.38.1
next reply other threads:[~2023-02-03 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 21:16 Philippe Mathieu-Daudé [this message]
2023-02-03 21:16 ` [PATCH 1/5] hw/misc/macio: Set QDev properties using QDev API Philippe Mathieu-Daudé
2023-02-03 21:16 ` [PATCH 2/5] hw/pci-host/raven: " Philippe Mathieu-Daudé
2023-02-05 11:03 ` Daniel Henrique Barboza
2023-02-03 21:16 ` [PATCH 3/5] hw/ppc/ppc4xx: " Philippe Mathieu-Daudé
2023-02-03 21:26 ` BALATON Zoltan
2023-02-05 10:59 ` Daniel Henrique Barboza
2023-02-03 21:16 ` [PATCH 4/5] hw/ppc/spapr: " Philippe Mathieu-Daudé
2023-02-05 11:00 ` Daniel Henrique Barboza
2023-02-06 8:06 ` Cédric Le Goater
2023-02-03 21:16 ` [PATCH 5/5] hw/ppc/pnv: " Philippe Mathieu-Daudé
2023-02-05 11:00 ` Daniel Henrique Barboza
2023-02-06 8:06 ` Cédric Le Goater
2023-02-05 11:05 ` [PATCH 0/5] hw/ppc: Set QDev properties using QDev API (part 2/3) Daniel Henrique Barboza
2023-02-06 8:00 ` Cédric Le Goater
2023-02-06 9:09 ` Mark Cave-Ayland
2023-02-06 13:52 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203211623.50930-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).