qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PULL 11/22] Revert "linux-user: fix compat with glibc >= 2.36 sys/mount.h"
Date: Sat,  4 Feb 2023 17:08:19 +0100	[thread overview]
Message-ID: <20230204160830.193093-12-laurent@vivier.eu> (raw)
In-Reply-To: <20230204160830.193093-1-laurent@vivier.eu>

From: Daniel P. Berrangé <berrange@redhat.com>

This reverts commit 3cd3df2a9584e6f753bb62a0028bd67124ab5532.

glibc has fixed (in 2.36.9000-40-g774058d729) the problem
that caused a clash when both sys/mount.h annd linux/mount.h
are included, and backported this to the 2.36 stable release
too:

  https://sourceware.org/glibc/wiki/Release/2.36#Usage_of_.3Clinux.2Fmount.h.3E_and_.3Csys.2Fmount.h.3E

It is saner for QEMU to remove the workaround it applied for
glibc 2.36 and expect distros to ship the 2.36 maint release
with the fix. This avoids needing to add a further workaround
to QEMU to deal with the fact that linux/brtfs.h now also pulls
in linux/mount.h via linux/fs.h since Linux 6.1

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230110174901.2580297-3-berrange@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/syscall.c | 18 ------------------
 meson.build          |  2 --
 2 files changed, 20 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index b88f8ee96f0f..210db5f0be94 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -95,25 +95,7 @@
 #include <linux/soundcard.h>
 #include <linux/kd.h>
 #include <linux/mtio.h>
-
-#ifdef HAVE_SYS_MOUNT_FSCONFIG
-/*
- * glibc >= 2.36 linux/mount.h conflicts with sys/mount.h,
- * which in turn prevents use of linux/fs.h. So we have to
- * define the constants ourselves for now.
- */
-#define FS_IOC_GETFLAGS                _IOR('f', 1, long)
-#define FS_IOC_SETFLAGS                _IOW('f', 2, long)
-#define FS_IOC_GETVERSION              _IOR('v', 1, long)
-#define FS_IOC_SETVERSION              _IOW('v', 2, long)
-#define FS_IOC_FIEMAP                  _IOWR('f', 11, struct fiemap)
-#define FS_IOC32_GETFLAGS              _IOR('f', 1, int)
-#define FS_IOC32_SETFLAGS              _IOW('f', 2, int)
-#define FS_IOC32_GETVERSION            _IOR('v', 1, int)
-#define FS_IOC32_SETVERSION            _IOW('v', 2, int)
-#else
 #include <linux/fs.h>
-#endif
 #include <linux/fd.h>
 #if defined(CONFIG_FIEMAP)
 #include <linux/fiemap.h>
diff --git a/meson.build b/meson.build
index 6d3b66562975..cccd19f864e3 100644
--- a/meson.build
+++ b/meson.build
@@ -2046,8 +2046,6 @@ config_host_data.set('HAVE_OPTRESET',
                      cc.has_header_symbol('getopt.h', 'optreset'))
 config_host_data.set('HAVE_IPPROTO_MPTCP',
                      cc.has_header_symbol('netinet/in.h', 'IPPROTO_MPTCP'))
-config_host_data.set('HAVE_SYS_MOUNT_FSCONFIG',
-                     cc.has_header_symbol('sys/mount.h', 'FSCONFIG_SET_FLAG'))
 
 # has_member
 config_host_data.set('HAVE_SIGEV_NOTIFY_THREAD_ID',
-- 
2.39.1



  parent reply	other threads:[~2023-02-04 16:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-04 16:08 [PULL 00/22] Linux user for 8.0 patches Laurent Vivier
2023-02-04 16:08 ` [PULL 01/22] linux-user/strace: Constify struct flags Laurent Vivier
2023-02-04 16:08 ` [PULL 02/22] linux-user/strace: Extract print_execve_argv() from print_execve() Laurent Vivier
2023-02-04 16:08 ` [PULL 03/22] linux-user/strace: Add output for execveat() syscall Laurent Vivier
2023-02-04 16:08 ` [PULL 04/22] linux-user/syscall: Extract do_execve() from do_syscall1() Laurent Vivier
2023-02-04 16:08 ` [PULL 05/22] linux-user/syscall: Implement execveat() Laurent Vivier
2023-02-04 16:08 ` [PULL 06/22] linux-user: Add missing MAP_HUGETLB and MAP_STACK flags in strace Laurent Vivier
2023-02-04 16:08 ` [PULL 07/22] linux-user: un-parent OBJECT(cpu) when closing thread Laurent Vivier
2023-02-04 16:08 ` [PULL 08/22] linux-user: fix strace build w/out munlockall Laurent Vivier
2023-02-04 16:08 ` [PULL 09/22] linux-user: add more netlink protocol constants Laurent Vivier
2023-02-04 16:08 ` [PULL 10/22] Revert "linux-user: add more compat ioctl definitions" Laurent Vivier
2023-02-04 16:08 ` Laurent Vivier [this message]
2023-02-04 16:08 ` [PULL 12/22] linux-user: Add strace output for clock_getres_time64() and futex_time64() Laurent Vivier
2023-02-04 16:08 ` [PULL 13/22] linux-user: Improve strace output of getgroups() and setgroups() Laurent Vivier
2023-02-04 16:08 ` [PULL 14/22] linux-user: move target_flat.h to target subdirs Laurent Vivier
2023-02-04 16:08 ` [PULL 15/22] linux-user: Fix SO_ERROR return code of getsockopt() Laurent Vivier
2023-02-04 16:08 ` [PULL 16/22] linux-user: Fix /proc/cpuinfo output for hppa Laurent Vivier
2023-02-04 16:08 ` [PULL 17/22] linux-user: Improve strace output of personality() and sysinfo() Laurent Vivier
2023-02-04 16:08 ` [PULL 18/22] linux-user: Add emulation for MADV_WIPEONFORK and MADV_KEEPONFORK in madvise() Laurent Vivier
2023-02-04 16:08 ` [PULL 19/22] linux-user: Show 4th argument of rt_sigprocmask() in strace Laurent Vivier
2023-02-04 16:08 ` [PULL 20/22] linux-user: Enhance strace output for various syscalls Laurent Vivier
2023-02-04 16:08 ` [PULL 21/22] linux-user: Implement SOL_ALG encryption support Laurent Vivier
2023-02-04 16:08 ` [PULL 22/22] linux-user: Allow sendmsg() without IOV Laurent Vivier
2023-02-04 19:12 ` [PULL 00/22] Linux user for 8.0 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230204160830.193093-12-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).