* [PATCH] meson: Avoid duplicates in generated config-poison.h again
@ 2023-02-06 10:20 Markus Armbruster
2023-02-06 10:30 ` Marc-André Lureau
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Markus Armbruster @ 2023-02-06 10:20 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini
Commit eed56e9a89f "configure, meson: move config-poison.h to meson"
lost a "| sort -u". Restore it. config-poison shrinks from ~4500 to
~700 lines when all targets are enabled.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
scripts/make-config-poison.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/make-config-poison.sh b/scripts/make-config-poison.sh
index d222a04304..1892854261 100755
--- a/scripts/make-config-poison.sh
+++ b/scripts/make-config-poison.sh
@@ -13,4 +13,4 @@ exec sed -n \
-e 's///' \
-e 's/ .*//' \
-e 's/^/#pragma GCC poison /p' \
- -e '}' "$@"
+ -e '}' "$@" | sort -u
--
2.39.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] meson: Avoid duplicates in generated config-poison.h again
2023-02-06 10:20 [PATCH] meson: Avoid duplicates in generated config-poison.h again Markus Armbruster
@ 2023-02-06 10:30 ` Marc-André Lureau
2023-02-06 11:04 ` Philippe Mathieu-Daudé
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Marc-André Lureau @ 2023-02-06 10:30 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, pbonzini
On Mon, Feb 6, 2023 at 2:21 PM Markus Armbruster <armbru@redhat.com> wrote:
>
> Commit eed56e9a89f "configure, meson: move config-poison.h to meson"
> lost a "| sort -u". Restore it. config-poison shrinks from ~4500 to
> ~700 lines when all targets are enabled.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> scripts/make-config-poison.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/make-config-poison.sh b/scripts/make-config-poison.sh
> index d222a04304..1892854261 100755
> --- a/scripts/make-config-poison.sh
> +++ b/scripts/make-config-poison.sh
> @@ -13,4 +13,4 @@ exec sed -n \
> -e 's///' \
> -e 's/ .*//' \
> -e 's/^/#pragma GCC poison /p' \
> - -e '}' "$@"
> + -e '}' "$@" | sort -u
> --
> 2.39.0
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] meson: Avoid duplicates in generated config-poison.h again
2023-02-06 10:20 [PATCH] meson: Avoid duplicates in generated config-poison.h again Markus Armbruster
2023-02-06 10:30 ` Marc-André Lureau
@ 2023-02-06 11:04 ` Philippe Mathieu-Daudé
2023-02-06 12:48 ` Alex Bennée
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-06 11:04 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: pbonzini
On 6/2/23 11:20, Markus Armbruster wrote:
> Commit eed56e9a89f "configure, meson: move config-poison.h to meson"
> lost a "| sort -u". Restore it. config-poison shrinks from ~4500 to
> ~700 lines when all targets are enabled.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/make-config-poison.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] meson: Avoid duplicates in generated config-poison.h again
2023-02-06 10:20 [PATCH] meson: Avoid duplicates in generated config-poison.h again Markus Armbruster
2023-02-06 10:30 ` Marc-André Lureau
2023-02-06 11:04 ` Philippe Mathieu-Daudé
@ 2023-02-06 12:48 ` Alex Bennée
2023-02-23 11:46 ` Markus Armbruster
2023-02-23 13:36 ` Paolo Bonzini
4 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2023-02-06 12:48 UTC (permalink / raw)
To: Markus Armbruster; +Cc: pbonzini, qemu-devel
Markus Armbruster <armbru@redhat.com> writes:
> Commit eed56e9a89f "configure, meson: move config-poison.h to meson"
> lost a "| sort -u". Restore it. config-poison shrinks from ~4500 to
> ~700 lines when all targets are enabled.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] meson: Avoid duplicates in generated config-poison.h again
2023-02-06 10:20 [PATCH] meson: Avoid duplicates in generated config-poison.h again Markus Armbruster
` (2 preceding siblings ...)
2023-02-06 12:48 ` Alex Bennée
@ 2023-02-23 11:46 ` Markus Armbruster
2023-02-23 13:36 ` Paolo Bonzini
4 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2023-02-23 11:46 UTC (permalink / raw)
To: qemu-trivial; +Cc: qemu-devel, pbonzini
Nominating for qemu-trivial. Thanks in advance!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] meson: Avoid duplicates in generated config-poison.h again
2023-02-06 10:20 [PATCH] meson: Avoid duplicates in generated config-poison.h again Markus Armbruster
` (3 preceding siblings ...)
2023-02-23 11:46 ` Markus Armbruster
@ 2023-02-23 13:36 ` Paolo Bonzini
4 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2023-02-23 13:36 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, pbonzini
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-23 13:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-06 10:20 [PATCH] meson: Avoid duplicates in generated config-poison.h again Markus Armbruster
2023-02-06 10:30 ` Marc-André Lureau
2023-02-06 11:04 ` Philippe Mathieu-Daudé
2023-02-06 12:48 ` Alex Bennée
2023-02-23 11:46 ` Markus Armbruster
2023-02-23 13:36 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).