From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: <qemu-devel@nongnu.org>, Michael Tsirkin <mst@redhat.com>
Cc: "Ben Widawsky" <bwidawsk@kernel.org>,
linux-cxl@vger.kernel.org, linuxarm@huawei.com,
"Ira Weiny" <ira.weiny@intel.com>,
"Gregory Price" <gourry.memverge@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v4 03/10] hw/cxl: set cxl-type3 device type to PCI_CLASS_MEMORY_CXL
Date: Mon, 6 Feb 2023 17:28:09 +0000 [thread overview]
Message-ID: <20230206172816.8201-4-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20230206172816.8201-1-Jonathan.Cameron@huawei.com>
From: Gregory Price <gourry.memverge@gmail.com>
Current code sets to STORAGE_EXPRESS and then overrides it.
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Gregory Price <gregory.price@memverge.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
hw/mem/cxl_type3.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index 252822bd82..217a5e639b 100644
--- a/hw/mem/cxl_type3.c
+++ b/hw/mem/cxl_type3.c
@@ -408,7 +408,6 @@ static void ct3_realize(PCIDevice *pci_dev, Error **errp)
}
pci_config_set_prog_interface(pci_conf, 0x10);
- pci_config_set_class(pci_conf, PCI_CLASS_MEMORY_CXL);
pcie_endpoint_cap_init(pci_dev, 0x80);
if (ct3d->sn != UI64_NULL) {
@@ -627,7 +626,7 @@ static void ct3_class_init(ObjectClass *oc, void *data)
pc->realize = ct3_realize;
pc->exit = ct3_exit;
- pc->class_id = PCI_CLASS_STORAGE_EXPRESS;
+ pc->class_id = PCI_CLASS_MEMORY_CXL;
pc->vendor_id = PCI_VENDOR_ID_INTEL;
pc->device_id = 0xd93; /* LVF for now */
pc->revision = 1;
--
2.37.2
next prev parent reply other threads:[~2023-02-06 17:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 17:28 [PATCH v4 00/10] hw/cxl: CXL emulation cleanups and minor fixes for upstream Jonathan Cameron via
2023-02-06 17:28 ` [PATCH v4 01/10] hw/mem/cxl_type3: Improve error handling in realize() Jonathan Cameron via
[not found] ` <CGME20230228041008uscas1p1296b02da63f7c8c81506d67dafe7ff75@uscas1p1.samsung.com>
2023-02-28 4:10 ` Fan Ni
2023-02-06 17:28 ` [PATCH v4 02/10] hw/pci-bridge/cxl_downstream: Fix type naming mismatch Jonathan Cameron via
[not found] ` <CGME20230228041044uscas1p1dfa4b92cb69b2f3c37d33c484521b491@uscas1p1.samsung.com>
2023-02-28 4:10 ` Fan Ni
2023-02-06 17:28 ` Jonathan Cameron via [this message]
[not found] ` <CGME20230228041113uscas1p1e62bf38766962db8de58b4c1b6cff804@uscas1p1.samsung.com>
2023-02-28 4:11 ` [PATCH v4 03/10] hw/cxl: set cxl-type3 device type to PCI_CLASS_MEMORY_CXL Fan Ni
2023-02-06 17:28 ` [PATCH v4 04/10] hw/cxl: Add CXL_CAPACITY_MULTIPLIER definition Jonathan Cameron via
[not found] ` <CGME20230228041151uscas1p18d7918f0111d9186a6740c93293a7bc4@uscas1p1.samsung.com>
2023-02-28 4:11 ` Fan Ni
2023-02-06 17:28 ` [PATCH v4 05/10] tests/acpi: Allow update of q35/DSDT.cxl Jonathan Cameron via
[not found] ` <CGME20230228041219uscas1p140e49d902024e0eab1eb1cf3cba168fa@uscas1p1.samsung.com>
2023-02-28 4:12 ` Fan Ni
2023-02-06 17:28 ` [PATCH v4 06/10] hw/i386/acpi: Drop duplicate _UID entry for CXL root bridge Jonathan Cameron via
[not found] ` <CGME20230228041253uscas1p229d8375093fdd4d2de21be8921e35e32@uscas1p2.samsung.com>
2023-02-28 4:12 ` Fan Ni
2023-02-06 17:28 ` [PATCH v4 07/10] tests: acpi: Update q35/DSDT.cxl for removed duplicate UID Jonathan Cameron via
[not found] ` <CGME20230228041312uscas1p1baf3e096036cefdc0a843ec47126facc@uscas1p1.samsung.com>
2023-02-28 4:13 ` Fan Ni
2023-02-06 17:28 ` [PATCH v4 08/10] qemu/bswap: Add const_le64() Jonathan Cameron via
[not found] ` <CGME20230228041419uscas1p1b9d933dc37c4b6369ef1dea03a54c9e4@uscas1p1.samsung.com>
2023-02-28 4:14 ` Fan Ni
2023-02-06 17:28 ` [PATCH v4 09/10] qemu/uuid: Add UUID static initializer Jonathan Cameron via
[not found] ` <CGME20230228041451uscas1p19d32976b917a5b8eaf3cd9b413e911f0@uscas1p1.samsung.com>
2023-02-28 4:14 ` Fan Ni
2023-02-06 17:28 ` [PATCH v4 10/10] hw/cxl/mailbox: Use new UUID network order define for cel_uuid Jonathan Cameron via
[not found] ` <CGME20230228041511uscas1p29bfa83f0efe2632d89d5d76ea1be0245@uscas1p2.samsung.com>
2023-02-28 4:15 ` Fan Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206172816.8201-4-Jonathan.Cameron@huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=bwidawsk@kernel.org \
--cc=gourry.memverge@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).