From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Juan Quintela <quintela@redhat.com>
Subject: [PULL 04/20] scripts/clean-includes: Improve --git commit message
Date: Tue, 7 Feb 2023 07:45:07 +0100 [thread overview]
Message-ID: <20230207064523.3968603-5-armbru@redhat.com> (raw)
In-Reply-To: <20230207064523.3968603-1-armbru@redhat.com>
The script drops #include "qemu/osdep.h" from headers. Mention it in
the commit message it uses for --git.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20230202133830.2152150-5-armbru@redhat.com>
---
scripts/clean-includes | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/scripts/clean-includes b/scripts/clean-includes
index f0466a6262..58e1607a82 100755
--- a/scripts/clean-includes
+++ b/scripts/clean-includes
@@ -193,11 +193,17 @@ if [ "$GIT" = "yes" ]; then
git commit --signoff -F - <<EOF
$GITSUBJ: Clean up includes
-Clean up includes so that osdep.h is included first and headers
-which it implies are not included manually.
-
This commit was created with scripts/clean-includes.
+All .c should include qemu/osdep.h first. The script performs three
+related cleanups:
+
+* Ensure .c files include qemu/osdep.h first.
+* Including it in a .h is redundant, since the .c already includes
+ it. Drop such inclusions.
+* Likewise, including headers qemu/osdep.h includes is redundant.
+ Drop these, too.
+
EOF
fi
--
2.39.0
next prev parent reply other threads:[~2023-02-07 6:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 6:45 [PULL 00/20] Header cleanup patches for 2023-02-06 Markus Armbruster
2023-02-07 6:45 ` [PULL 01/20] scripts/clean-includes: Fully skip / ignore files Markus Armbruster
2023-02-07 6:45 ` [PULL 02/20] scripts/clean-includes: Don't claim duplicate headers found when not Markus Armbruster
2023-02-07 6:45 ` [PULL 03/20] scripts/clean-includes: Skip symbolic links Markus Armbruster
2023-02-07 6:45 ` Markus Armbruster [this message]
2023-02-07 6:45 ` [PULL 05/20] bsd-user: Clean up includes Markus Armbruster
2023-02-07 6:45 ` [PULL 06/20] crypto: " Markus Armbruster
2023-02-07 6:45 ` [PULL 07/20] hw/cxl: " Markus Armbruster
2023-02-07 6:45 ` [PULL 08/20] hw/input: " Markus Armbruster
2023-02-07 6:45 ` [PULL 09/20] hw/tricore: " Markus Armbruster
2023-02-07 6:45 ` [PULL 10/20] qga: " Markus Armbruster
2023-02-07 6:45 ` [PULL 11/20] migration: " Markus Armbruster
2023-02-07 6:45 ` [PULL 12/20] net: " Markus Armbruster
2023-02-07 6:45 ` [PULL 13/20] target/hexagon: " Markus Armbruster
2023-02-07 6:45 ` [PULL 14/20] riscv: " Markus Armbruster
2023-02-07 6:45 ` [PULL 15/20] block: " Markus Armbruster
2023-02-07 6:45 ` [PULL 16/20] accel: " Markus Armbruster
2023-02-07 6:45 ` [PULL 17/20] Fix non-first inclusions of qemu/osdep.h Markus Armbruster
2023-02-07 6:45 ` [PULL 18/20] Don't include headers already included by qemu/osdep.h Markus Armbruster
2023-02-07 6:45 ` [PULL 19/20] 9p: Drop superfluous include of linux/limits.h Markus Armbruster
2023-02-07 6:45 ` [PULL 20/20] Drop duplicate #include Markus Armbruster
2023-02-07 17:47 ` [PULL 00/20] Header cleanup patches for 2023-02-06 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207064523.3968603-5-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).