From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, mst@redhat.com, imammedo@redhat.com,
ani@anisinha.ca, eduardo@habkost.net, marcel.apfelbaum@gmail.com,
philmd@linaro.org, wangyanan55@huawei.com, jiri@resnulli.us,
jasowang@redhat.com, pavel.dovgaluk@ispras.ru,
pbonzini@redhat.com, zhanghailiang@xfusion.com,
quintela@redhat.com, dgilbert@redhat.com, michael.roth@amd.com,
kkostiuk@redhat.com
Subject: [PATCH 03/12] dump: Assert cpu_get_note_size() can't fail
Date: Tue, 7 Feb 2023 08:51:06 +0100 [thread overview]
Message-ID: <20230207075115.1525-4-armbru@redhat.com> (raw)
In-Reply-To: <20230207075115.1525-1-armbru@redhat.com>
The only way cpu_get_note_size() can return a negative value is
integer overflow in the non-stub versions, which is a programming
error. The stub version is not actually reachable, because the
cpu_get_dump_info() stub will fail first. Use assert(). This gets
rid of another use of QERR_UNSUPPORTED.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
dump/dump.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/dump/dump.c b/dump/dump.c
index 80620da40d..6be8a65fe3 100644
--- a/dump/dump.c
+++ b/dump/dump.c
@@ -1865,10 +1865,7 @@ static void dump_init(DumpState *s, int fd, bool has_format,
s->note_size = cpu_get_note_size(s->dump_info.d_class,
s->dump_info.d_machine, nr_cpus);
- if (s->note_size < 0) {
- error_setg(errp, QERR_UNSUPPORTED);
- goto cleanup;
- }
+ assert(s->note_size >= 0);
/*
* The goal of this block is to (a) update the previously guessed
--
2.39.0
next prev parent reply other threads:[~2023-02-07 7:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 7:51 [PATCH 00/12] error: Reduce qerror.h usage a bit more Markus Armbruster
2023-02-07 7:51 ` [PATCH 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h" Markus Armbruster
2023-02-07 8:45 ` Juan Quintela
2023-02-07 16:26 ` Konstantin Kostiuk
2023-02-07 7:51 ` [PATCH 02/12] dump: Improve error message when target doesn't support memory dump Markus Armbruster
2023-02-07 8:32 ` Philippe Mathieu-Daudé
2023-02-07 12:00 ` Markus Armbruster
2023-02-07 8:45 ` Juan Quintela
2023-02-07 7:51 ` Markus Armbruster [this message]
2023-02-07 8:46 ` [PATCH 03/12] dump: Assert cpu_get_note_size() can't fail Juan Quintela
2023-02-07 7:51 ` [PATCH 04/12] hw/core: Improve error message when machine doesn't provide NMIs Markus Armbruster
2023-02-07 8:47 ` Juan Quintela
2023-02-07 7:51 ` [PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub Markus Armbruster
2023-02-07 8:50 ` Juan Quintela
2023-02-07 7:51 ` [PATCH 06/12] hw/acpi: Dumb down acpi_table_add() stub Markus Armbruster
2023-02-07 8:51 ` Juan Quintela
2023-02-07 7:51 ` [PATCH 07/12] hw/acpi: Move QMP command to hw/core/ Markus Armbruster
2023-02-07 8:52 ` Juan Quintela
2023-02-07 7:51 ` [PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED Markus Armbruster
2023-02-07 8:53 ` Juan Quintela
2023-02-07 16:26 ` Konstantin Kostiuk
2023-02-07 7:51 ` [PATCH 09/12] replay: Simplify setting replay blockers Markus Armbruster
2023-02-07 8:38 ` Philippe Mathieu-Daudé
2023-02-07 12:50 ` Markus Armbruster
2023-02-07 7:51 ` [PATCH 10/12] hw/core: Improve the query-hotpluggable-cpus error message Markus Armbruster
2023-02-07 8:40 ` Philippe Mathieu-Daudé
2023-02-07 12:53 ` Markus Armbruster
2023-02-07 7:51 ` [PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat " Markus Armbruster
2023-02-07 9:03 ` Juan Quintela
2023-02-07 10:10 ` Markus Armbruster
2023-02-07 7:51 ` [PATCH 12/12] rocker: Tweak stubbed out monitor commands' error messages Markus Armbruster
2023-02-07 9:04 ` Juan Quintela
2023-02-07 8:41 ` [PATCH 00/12] error: Reduce qerror.h usage a bit more Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207075115.1525-4-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=ani@anisinha.ca \
--cc=dgilbert@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).