From: Andrew Jones <ajones@ventanamicro.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Andrea Bolognani <abologna@redhat.com>,
Sunil V L <sunilvl@ventanamicro.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
Anup Patel <apatel@ventanamicro.com>,
Atish Kumar Patra <atishp@rivosinc.com>,
Ani Sinha <ani@anisinha.ca>,
"Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Bernhard Beschow <shentey@gmail.com>
Subject: Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI
Date: Tue, 7 Feb 2023 11:14:30 +0100 [thread overview]
Message-ID: <20230207101430.k3asm7s3f6gz54i4@orel> (raw)
In-Reply-To: <25504aa3-20e3-d7e6-4111-c956370949ba@linaro.org>
On Tue, Feb 07, 2023 at 09:50:29AM +0100, Philippe Mathieu-Daudé wrote:
> On 6/2/23 13:56, Gerd Hoffmann wrote:
> > On Mon, Feb 06, 2023 at 12:18:06PM +0100, Philippe Mathieu-Daudé wrote:
> > > On 6/2/23 11:54, Andrea Bolognani wrote:
> > > > On Thu, Feb 02, 2023 at 10:22:15AM +0530, Sunil V L wrote:
> > > > > + object_class_property_add(oc, "acpi", "OnOffAuto",
> > > > > + virt_get_acpi, virt_set_acpi,
> > > > > + NULL, NULL);
> > > > > + object_class_property_set_description(oc, "acpi",
> > > > > + "Enable ACPI");
> > > >
> > > > The way this works on other architectures (x86_64, aarch64) is that
> > > > you get ACPI by default and can use -no-acpi to disable it if
> > > > desired. Can we have the same on RISC-V, for consistency?
> > >
> > > -no-acpi rather seems a x86-specific hack for the ISA PC machine, and
> > > has a high maintenance cost / burden.
> >
> > Under the hood it is actually a OnOffAuto machine property and -no-acpi
> > is just a shortcut to set that.
> >
> > > Actually, what is the value added by '-no-acpi'?
> >
> > On arm(64) the linux kernel can use either device trees or ACPI to find
> > the hardware. Historical reasons mostly, when the platform started
> > there was no ACPI support. Also the edk2 firmware uses Device Trees
> > for hardware discovery, likewise for historical reasons.
> >
> > When ACPI is available for a platform right from the start I see little
> > reason to offer an option to turn it off though ...
>
> Yeah I concur. There is no point in disabling ACPI on the RISCV virt
> machine IMO.
edk2 will only present DT or ACPI to the guest, not both. However, RISCV
Linux supports both. If we don't offer '-no-acpi' as a way to switch to
DT, then edk2+DT users will need to configure the varstore to select it.
And, since testing needs to be done with both, that varstore change will
need to be added to all the testcases which need DT (or a varstore with
DT already selected will need to be maintained and used by the testsuites)
IMO, the generation of the ACPI tables should be 'on' by default, but then
the, already present, '-no-acpi' command line option should be made
available in order to easily inform edk2 to present DT instead of ACPI.
Thanks,
drew
next prev parent reply other threads:[~2023-02-07 10:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 4:52 [PATCH 00/10] Add basic ACPI support for risc-v virt Sunil V L
2023-02-02 4:52 ` [PATCH 01/10] hw/riscv/virt: Add OEM_ID and OEM_TABLE_ID fields Sunil V L
2023-02-06 5:49 ` Bin Meng
2023-02-09 0:17 ` Alistair Francis
2023-02-02 4:52 ` [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI Sunil V L
2023-02-06 9:43 ` Bin Meng
2023-02-06 10:54 ` Andrea Bolognani
2023-02-06 11:18 ` Philippe Mathieu-Daudé
2023-02-06 12:35 ` Andrew Jones
2023-02-06 13:04 ` Sunil V L
2023-02-07 3:57 ` Bin Meng
2023-02-07 5:37 ` Andrew Jones
2023-02-07 12:33 ` Sunil V L
2023-02-06 12:56 ` Gerd Hoffmann
2023-02-07 8:50 ` Philippe Mathieu-Daudé
2023-02-07 10:12 ` Sunil V L
2023-02-07 10:14 ` Andrew Jones [this message]
2023-02-06 23:14 ` Bernhard Beschow
2023-02-07 10:23 ` Andrew Jones
2023-02-07 13:56 ` Andrea Bolognani
2023-02-07 14:02 ` Thomas Huth
2023-02-07 14:38 ` Andrea Bolognani
2023-02-07 19:20 ` Andrew Jones
2023-02-08 16:48 ` Andrea Bolognani
2023-02-09 5:15 ` Thomas Huth
2023-02-02 4:52 ` [PATCH 03/10] hw/riscv/virt: Add memmap pointer to RiscVVirtState Sunil V L
2023-02-06 9:50 ` Bin Meng
2023-02-09 0:18 ` Alistair Francis
2023-02-02 4:52 ` [PATCH 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables Sunil V L
2023-02-06 10:17 ` Bin Meng
2023-02-06 13:24 ` Sunil V L
2023-02-07 16:10 ` Bin Meng
2023-02-07 18:15 ` Sunil V L
2023-02-08 1:06 ` Bin Meng
2023-02-08 4:49 ` Sunil V L
2023-02-24 16:14 ` Igor Mammedov
2023-02-02 4:52 ` [PATCH 05/10] hw/riscv/virt: virt-acpi-build.c: Add RINTC in MADT Sunil V L
2023-02-09 0:21 ` Alistair Francis
2023-02-02 4:52 ` [PATCH 06/10] hw/riscv/virt: virt-acpi-build.c: Add RHCT Table Sunil V L
2023-02-02 4:52 ` [PATCH 07/10] hw/riscv: meson.build: Build virt-acpi-build.c Sunil V L
2023-02-06 10:26 ` Bin Meng
2023-02-02 4:52 ` [PATCH 08/10] hw/riscv/Kconfig: virt: Enable ACPI config options Sunil V L
2023-02-06 10:29 ` Bin Meng
2023-02-06 14:19 ` Sunil V L
2023-02-02 4:52 ` [PATCH 09/10] hw/riscv/virt.c: Initialize the ACPI tables Sunil V L
2023-02-06 10:32 ` Bin Meng
2023-02-02 4:52 ` [PATCH 10/10] MAINTAINERS: Add entry for RISC-V ACPI Sunil V L
2023-02-06 10:33 ` Bin Meng
2023-02-09 0:23 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207101430.k3asm7s3f6gz54i4@orel \
--to=ajones@ventanamicro.com \
--cc=abologna@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=ani@anisinha.ca \
--cc=apatel@ventanamicro.com \
--cc=armbru@redhat.com \
--cc=atishp@rivosinc.com \
--cc=bin.meng@windriver.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=shentey@gmail.com \
--cc=sunilvl@ventanamicro.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).