From: Andrew Jones <ajones@ventanamicro.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Andrea Bolognani <abologna@redhat.com>,
Sunil V L <sunilvl@ventanamicro.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
Anup Patel <apatel@ventanamicro.com>,
Atish Kumar Patra <atishp@rivosinc.com>,
Ani Sinha <ani@anisinha.ca>,
"Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>, Thomas Huth <thuth@redhat.com>,
Bernhard Beschow <shentey@gmail.com>
Subject: Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI
Date: Tue, 7 Feb 2023 11:23:53 +0100 [thread overview]
Message-ID: <20230207102353.hpg2gxh22urjbebu@orel> (raw)
In-Reply-To: <fe3b5794-be2a-eec7-9d4e-9a13eab48378@linaro.org>
On Mon, Feb 06, 2023 at 12:18:06PM +0100, Philippe Mathieu-Daudé wrote:
> On 6/2/23 11:54, Andrea Bolognani wrote:
> > On Thu, Feb 02, 2023 at 10:22:15AM +0530, Sunil V L wrote:
> > > + object_class_property_add(oc, "acpi", "OnOffAuto",
> > > + virt_get_acpi, virt_set_acpi,
> > > + NULL, NULL);
> > > + object_class_property_set_description(oc, "acpi",
> > > + "Enable ACPI");
> >
> > The way this works on other architectures (x86_64, aarch64) is that
> > you get ACPI by default and can use -no-acpi to disable it if
> > desired. Can we have the same on RISC-V, for consistency?
>
> -no-acpi rather seems a x86-specific hack for the ISA PC machine, and
> has a high maintenance cost / burden.
Can you elaborate on this? RISCV doesn't need '-no-acpi' specifically.
If -no-acpi is problematic for some reason, then something like
'-machine virt,acpi=off' would be sufficient for switching to DT too.
Thanks,
drew
next prev parent reply other threads:[~2023-02-07 10:24 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 4:52 [PATCH 00/10] Add basic ACPI support for risc-v virt Sunil V L
2023-02-02 4:52 ` [PATCH 01/10] hw/riscv/virt: Add OEM_ID and OEM_TABLE_ID fields Sunil V L
2023-02-06 5:49 ` Bin Meng
2023-02-09 0:17 ` Alistair Francis
2023-02-02 4:52 ` [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI Sunil V L
2023-02-06 9:43 ` Bin Meng
2023-02-06 10:54 ` Andrea Bolognani
2023-02-06 11:18 ` Philippe Mathieu-Daudé
2023-02-06 12:35 ` Andrew Jones
2023-02-06 13:04 ` Sunil V L
2023-02-07 3:57 ` Bin Meng
2023-02-07 5:37 ` Andrew Jones
2023-02-07 12:33 ` Sunil V L
2023-02-06 12:56 ` Gerd Hoffmann
2023-02-07 8:50 ` Philippe Mathieu-Daudé
2023-02-07 10:12 ` Sunil V L
2023-02-07 10:14 ` Andrew Jones
2023-02-06 23:14 ` Bernhard Beschow
2023-02-07 10:23 ` Andrew Jones [this message]
2023-02-07 13:56 ` Andrea Bolognani
2023-02-07 14:02 ` Thomas Huth
2023-02-07 14:38 ` Andrea Bolognani
2023-02-07 19:20 ` Andrew Jones
2023-02-08 16:48 ` Andrea Bolognani
2023-02-09 5:15 ` Thomas Huth
2023-02-02 4:52 ` [PATCH 03/10] hw/riscv/virt: Add memmap pointer to RiscVVirtState Sunil V L
2023-02-06 9:50 ` Bin Meng
2023-02-09 0:18 ` Alistair Francis
2023-02-02 4:52 ` [PATCH 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables Sunil V L
2023-02-06 10:17 ` Bin Meng
2023-02-06 13:24 ` Sunil V L
2023-02-07 16:10 ` Bin Meng
2023-02-07 18:15 ` Sunil V L
2023-02-08 1:06 ` Bin Meng
2023-02-08 4:49 ` Sunil V L
2023-02-24 16:14 ` Igor Mammedov
2023-02-02 4:52 ` [PATCH 05/10] hw/riscv/virt: virt-acpi-build.c: Add RINTC in MADT Sunil V L
2023-02-09 0:21 ` Alistair Francis
2023-02-02 4:52 ` [PATCH 06/10] hw/riscv/virt: virt-acpi-build.c: Add RHCT Table Sunil V L
2023-02-02 4:52 ` [PATCH 07/10] hw/riscv: meson.build: Build virt-acpi-build.c Sunil V L
2023-02-06 10:26 ` Bin Meng
2023-02-02 4:52 ` [PATCH 08/10] hw/riscv/Kconfig: virt: Enable ACPI config options Sunil V L
2023-02-06 10:29 ` Bin Meng
2023-02-06 14:19 ` Sunil V L
2023-02-02 4:52 ` [PATCH 09/10] hw/riscv/virt.c: Initialize the ACPI tables Sunil V L
2023-02-06 10:32 ` Bin Meng
2023-02-02 4:52 ` [PATCH 10/10] MAINTAINERS: Add entry for RISC-V ACPI Sunil V L
2023-02-06 10:33 ` Bin Meng
2023-02-09 0:23 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207102353.hpg2gxh22urjbebu@orel \
--to=ajones@ventanamicro.com \
--cc=abologna@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=ani@anisinha.ca \
--cc=apatel@ventanamicro.com \
--cc=armbru@redhat.com \
--cc=atishp@rivosinc.com \
--cc=bin.meng@windriver.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=shentey@gmail.com \
--cc=sunilvl@ventanamicro.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).