From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, thuth@redhat.com, philmd@linaro.org,
david.daney@fungible.com
Subject: Re: [PATCH] virtio-rng-pci: fix transitional migration compat for vectors
Date: Tue, 7 Feb 2023 16:48:22 -0500 [thread overview]
Message-ID: <20230207164805-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230207174944.138255-1-dgilbert@redhat.com>
On Tue, Feb 07, 2023 at 05:49:44PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
virtio?
> migration compatibility, but it was discovered that we also need to fix
> the other aliases of the device for the transitional cases.
>
> Fixes: 9ea02e8f1 ('virtio-rng-pci: Allow setting nvectors, so we can use MSI-X')
> bz: https://bugzilla.redhat.com/show_bug.cgi?id=2162569
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/core/machine.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index b5cd42cd8c..4627b274d9 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -49,6 +49,8 @@ const size_t hw_compat_7_2_len = G_N_ELEMENTS(hw_compat_7_2);
> GlobalProperty hw_compat_7_1[] = {
> { "virtio-device", "queue_reset", "false" },
> { "virtio-rng-pci", "vectors", "0" },
> + { "virtio-rng-pci-transitional", "vectors", "0" },
> + { "virtio-rng-pci-non-transitional", "vectors", "0" },
> };
> const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
>
> --
> 2.39.1
prev parent reply other threads:[~2023-02-07 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 17:49 [PATCH] virtio-rng-pci: fix transitional migration compat for vectors Dr. David Alan Gilbert (git)
2023-02-07 18:30 ` Philippe Mathieu-Daudé
2023-02-07 18:31 ` Dr. David Alan Gilbert
2023-02-07 21:49 ` Michael S. Tsirkin
2023-02-07 18:32 ` Thomas Huth
2023-02-07 21:48 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207164805-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=david.daney@fungible.com \
--cc=dgilbert@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).