* [PATCH] virtio-rng-pci: fix transitional migration compat for vectors
@ 2023-02-07 17:49 Dr. David Alan Gilbert (git)
2023-02-07 18:30 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2023-02-07 17:49 UTC (permalink / raw)
To: qemu-devel, mst, thuth, philmd; +Cc: david.daney
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
migration compatibility, but it was discovered that we also need to fix
the other aliases of the device for the transitional cases.
Fixes: 9ea02e8f1 ('virtio-rng-pci: Allow setting nvectors, so we can use MSI-X')
bz: https://bugzilla.redhat.com/show_bug.cgi?id=2162569
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
hw/core/machine.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index b5cd42cd8c..4627b274d9 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -49,6 +49,8 @@ const size_t hw_compat_7_2_len = G_N_ELEMENTS(hw_compat_7_2);
GlobalProperty hw_compat_7_1[] = {
{ "virtio-device", "queue_reset", "false" },
{ "virtio-rng-pci", "vectors", "0" },
+ { "virtio-rng-pci-transitional", "vectors", "0" },
+ { "virtio-rng-pci-non-transitional", "vectors", "0" },
};
const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng-pci: fix transitional migration compat for vectors
2023-02-07 17:49 [PATCH] virtio-rng-pci: fix transitional migration compat for vectors Dr. David Alan Gilbert (git)
@ 2023-02-07 18:30 ` Philippe Mathieu-Daudé
2023-02-07 18:31 ` Dr. David Alan Gilbert
2023-02-07 18:32 ` Thomas Huth
2023-02-07 21:48 ` Michael S. Tsirkin
2 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-07 18:30 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel, mst, thuth; +Cc: david.daney
On 7/2/23 18:49, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
Typo "virtio-rng-pci".
> migration compatibility, but it was discovered that we also need to fix
> the other aliases of the device for the transitional cases.
>
> Fixes: 9ea02e8f1 ('virtio-rng-pci: Allow setting nvectors, so we can use MSI-X')
> bz: https://bugzilla.redhat.com/show_bug.cgi?id=2162569
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/core/machine.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index b5cd42cd8c..4627b274d9 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -49,6 +49,8 @@ const size_t hw_compat_7_2_len = G_N_ELEMENTS(hw_compat_7_2);
> GlobalProperty hw_compat_7_1[] = {
> { "virtio-device", "queue_reset", "false" },
> { "virtio-rng-pci", "vectors", "0" },
> + { "virtio-rng-pci-transitional", "vectors", "0" },
> + { "virtio-rng-pci-non-transitional", "vectors", "0" },
Ouch :(
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> };
> const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng-pci: fix transitional migration compat for vectors
2023-02-07 18:30 ` Philippe Mathieu-Daudé
@ 2023-02-07 18:31 ` Dr. David Alan Gilbert
2023-02-07 21:49 ` Michael S. Tsirkin
0 siblings, 1 reply; 6+ messages in thread
From: Dr. David Alan Gilbert @ 2023-02-07 18:31 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-devel, mst, thuth, david.daney
* Philippe Mathieu-Daudé (philmd@linaro.org) wrote:
> On 7/2/23 18:49, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
>
> Typo "virtio-rng-pci".
I've made that typo SO many times...
> > migration compatibility, but it was discovered that we also need to fix
> > the other aliases of the device for the transitional cases.
> >
> > Fixes: 9ea02e8f1 ('virtio-rng-pci: Allow setting nvectors, so we can use MSI-X')
> > bz: https://bugzilla.redhat.com/show_bug.cgi?id=2162569
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > ---
> > hw/core/machine.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index b5cd42cd8c..4627b274d9 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -49,6 +49,8 @@ const size_t hw_compat_7_2_len = G_N_ELEMENTS(hw_compat_7_2);
> > GlobalProperty hw_compat_7_1[] = {
> > { "virtio-device", "queue_reset", "false" },
> > { "virtio-rng-pci", "vectors", "0" },
> > + { "virtio-rng-pci-transitional", "vectors", "0" },
> > + { "virtio-rng-pci-non-transitional", "vectors", "0" },
>
> Ouch :(
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks!
Dave
>
> > };
> > const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng-pci: fix transitional migration compat for vectors
2023-02-07 17:49 [PATCH] virtio-rng-pci: fix transitional migration compat for vectors Dr. David Alan Gilbert (git)
2023-02-07 18:30 ` Philippe Mathieu-Daudé
@ 2023-02-07 18:32 ` Thomas Huth
2023-02-07 21:48 ` Michael S. Tsirkin
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2023-02-07 18:32 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel, mst, philmd; +Cc: david.daney
On 07/02/2023 18.49, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
> migration compatibility, but it was discovered that we also need to fix
> the other aliases of the device for the transitional cases.
>
> Fixes: 9ea02e8f1 ('virtio-rng-pci: Allow setting nvectors, so we can use MSI-X')
> bz: https://bugzilla.redhat.com/show_bug.cgi?id=2162569
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/core/machine.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index b5cd42cd8c..4627b274d9 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -49,6 +49,8 @@ const size_t hw_compat_7_2_len = G_N_ELEMENTS(hw_compat_7_2);
> GlobalProperty hw_compat_7_1[] = {
> { "virtio-device", "queue_reset", "false" },
> { "virtio-rng-pci", "vectors", "0" },
> + { "virtio-rng-pci-transitional", "vectors", "0" },
> + { "virtio-rng-pci-non-transitional", "vectors", "0" },
> };
> const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng-pci: fix transitional migration compat for vectors
2023-02-07 17:49 [PATCH] virtio-rng-pci: fix transitional migration compat for vectors Dr. David Alan Gilbert (git)
2023-02-07 18:30 ` Philippe Mathieu-Daudé
2023-02-07 18:32 ` Thomas Huth
@ 2023-02-07 21:48 ` Michael S. Tsirkin
2 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2023-02-07 21:48 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: qemu-devel, thuth, philmd, david.daney
On Tue, Feb 07, 2023 at 05:49:44PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
virtio?
> migration compatibility, but it was discovered that we also need to fix
> the other aliases of the device for the transitional cases.
>
> Fixes: 9ea02e8f1 ('virtio-rng-pci: Allow setting nvectors, so we can use MSI-X')
> bz: https://bugzilla.redhat.com/show_bug.cgi?id=2162569
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hw/core/machine.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index b5cd42cd8c..4627b274d9 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -49,6 +49,8 @@ const size_t hw_compat_7_2_len = G_N_ELEMENTS(hw_compat_7_2);
> GlobalProperty hw_compat_7_1[] = {
> { "virtio-device", "queue_reset", "false" },
> { "virtio-rng-pci", "vectors", "0" },
> + { "virtio-rng-pci-transitional", "vectors", "0" },
> + { "virtio-rng-pci-non-transitional", "vectors", "0" },
> };
> const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
>
> --
> 2.39.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-rng-pci: fix transitional migration compat for vectors
2023-02-07 18:31 ` Dr. David Alan Gilbert
@ 2023-02-07 21:49 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2023-02-07 21:49 UTC (permalink / raw)
To: Dr. David Alan Gilbert
Cc: Philippe Mathieu-Daudé, qemu-devel, thuth, david.daney
On Tue, Feb 07, 2023 at 06:31:53PM +0000, Dr. David Alan Gilbert wrote:
> * Philippe Mathieu-Daudé (philmd@linaro.org) wrote:
> > On 7/2/23 18:49, Dr. David Alan Gilbert (git) wrote:
> > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > >
> > > In bad9c5a5166fd5e3a892b7b0477cf2f4bd3a959a I fixed the virito-rng-pci
> >
> > Typo "virtio-rng-pci".
>
> I've made that typo SO many times...
Add this in .vimrc
ab virito virtio
and never make this mistake again ... as long as you use vim ;)
> > > migration compatibility, but it was discovered that we also need to fix
> > > the other aliases of the device for the transitional cases.
> > >
> > > Fixes: 9ea02e8f1 ('virtio-rng-pci: Allow setting nvectors, so we can use MSI-X')
> > > bz: https://bugzilla.redhat.com/show_bug.cgi?id=2162569
> > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > > ---
> > > hw/core/machine.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > > index b5cd42cd8c..4627b274d9 100644
> > > --- a/hw/core/machine.c
> > > +++ b/hw/core/machine.c
> > > @@ -49,6 +49,8 @@ const size_t hw_compat_7_2_len = G_N_ELEMENTS(hw_compat_7_2);
> > > GlobalProperty hw_compat_7_1[] = {
> > > { "virtio-device", "queue_reset", "false" },
> > > { "virtio-rng-pci", "vectors", "0" },
> > > + { "virtio-rng-pci-transitional", "vectors", "0" },
> > > + { "virtio-rng-pci-non-transitional", "vectors", "0" },
> >
> > Ouch :(
> >
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Thanks!
>
> Dave
>
> >
> > > };
> > > const size_t hw_compat_7_1_len = G_N_ELEMENTS(hw_compat_7_1);
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-07 21:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-07 17:49 [PATCH] virtio-rng-pci: fix transitional migration compat for vectors Dr. David Alan Gilbert (git)
2023-02-07 18:30 ` Philippe Mathieu-Daudé
2023-02-07 18:31 ` Dr. David Alan Gilbert
2023-02-07 21:49 ` Michael S. Tsirkin
2023-02-07 18:32 ` Thomas Huth
2023-02-07 21:48 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).