From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Michael Roth <michael.roth@amd.com>,
Markus Armbruster <armbru@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: [PATCH v2 0/7] qapi: static typing conversion, pt5c
Date: Tue, 7 Feb 2023 21:12:59 -0500 [thread overview]
Message-ID: <20230208021306.870657-1-jsnow@redhat.com> (raw)
This is part five (c), and focuses on sharing strict types between
parser.py and expr.py.
gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5c
Every commit should pass with:
- `isort -c qapi/`
- `flake8 qapi/`
- `pylint --rcfile=qapi/pylintrc qapi/`
- `mypy --config-file=qapi/mypy.ini qapi/`
Some notes on this series:
Patches 2 and 3 are almost entirely superseded by patch 5, but I wasn't
as confident that Markus would like patch 5, so these patches aren't
squashed quite as tightly as they could be -- I recommend peeking ahead
at the cover letters before reviewing the actual patch diffs.
By the end of this series, the only JSON-y types we have left are:
(A) QAPIExpression,
(B) JSONValue,
(C) _ExprValue.
The argument I'm making here is that QAPIExpression and JSONValue are
distinct enough to warrant having both types (for now, at least); and
that _ExprValue is specialized enough to also warrant its inclusion.
(Brutal honesty: my attempts at unifying this even further had even more
hacks and unsatisfying conclusions, and fully unifying these types
should probably wait until we're allowed to rely on some fairly modern
Python versions.)
John Snow (7):
qapi/expr: Split check_expr out from check_exprs
qapi/parser.py: add ParsedExpression type
qapi/expr: Use TopLevelExpr where appropriate
qapi/expr: add typing workaround for AbstractSet
qapi/parser: [RFC] add QAPIExpression
qapi: remove _JSONObject
qapi: remove JSON value FIXME
scripts/qapi/expr.py | 282 +++++++++++++++++++----------------------
scripts/qapi/parser.py | 51 +++++---
scripts/qapi/schema.py | 105 +++++++--------
3 files changed, 218 insertions(+), 220 deletions(-)
--
2.39.0
next reply other threads:[~2023-02-08 2:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 2:12 John Snow [this message]
2023-02-08 2:13 ` [PATCH v2 1/7] qapi/expr: Split check_expr out from check_exprs John Snow
2023-02-08 16:08 ` Markus Armbruster
2023-02-08 2:13 ` [PATCH v2 2/7] qapi/parser.py: add ParsedExpression type John Snow
2023-02-08 16:17 ` Markus Armbruster
2023-02-08 18:01 ` John Snow
2023-02-08 2:13 ` [PATCH v2 3/7] qapi/expr: Use TopLevelExpr where appropriate John Snow
2023-02-08 16:22 ` Markus Armbruster
2023-02-08 2:13 ` [PATCH v2 4/7] qapi/expr: add typing workaround for AbstractSet John Snow
2023-02-08 2:13 ` [PATCH v2 5/7] qapi/parser: [RFC] add QAPIExpression John Snow
2023-02-08 16:28 ` Markus Armbruster
2023-02-08 17:17 ` John Snow
2023-02-08 21:05 ` Markus Armbruster
2023-02-09 6:57 ` Markus Armbruster
2023-02-08 2:13 ` [PATCH v2 6/7] qapi: remove _JSONObject John Snow
2023-02-08 2:13 ` [PATCH v2 7/7] qapi: remove JSON value FIXME John Snow
2023-02-08 16:31 ` [PATCH v2 0/7] qapi: static typing conversion, pt5c Markus Armbruster
2023-02-08 17:02 ` John Snow
2023-02-09 7:08 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208021306.870657-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).