From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>, qemu-stable@nongnu.org
Subject: [PULL 10/11] target/i386: Fix C flag for BLSI, BLSMSK, BLSR
Date: Wed, 8 Feb 2023 18:19:21 +0100 [thread overview]
Message-ID: <20230208171922.95048-11-pbonzini@redhat.com> (raw)
In-Reply-To: <20230208171922.95048-1-pbonzini@redhat.com>
From: Richard Henderson <richard.henderson@linaro.org>
We forgot to set cc_src, which is used for computing C.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1370
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230114180601.2993644-1-richard.henderson@linaro.org>
Cc: qemu-stable@nongnu.org
Fixes: 1d0b926150e5 ("target/i386: move scalar 0F 38 and 0F 3A instruction to new decoder", 2022-10-18)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/tcg/emit.c.inc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc
index 99f6ba6e19a2..4d7702c106bf 100644
--- a/target/i386/tcg/emit.c.inc
+++ b/target/i386/tcg/emit.c.inc
@@ -1111,6 +1111,7 @@ static void gen_BLSI(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode)
{
MemOp ot = decode->op[0].ot;
+ tcg_gen_mov_tl(cpu_cc_src, s->T0);
tcg_gen_neg_tl(s->T1, s->T0);
tcg_gen_and_tl(s->T0, s->T0, s->T1);
tcg_gen_mov_tl(cpu_cc_dst, s->T0);
@@ -1121,6 +1122,7 @@ static void gen_BLSMSK(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode
{
MemOp ot = decode->op[0].ot;
+ tcg_gen_mov_tl(cpu_cc_src, s->T0);
tcg_gen_subi_tl(s->T1, s->T0, 1);
tcg_gen_xor_tl(s->T0, s->T0, s->T1);
tcg_gen_mov_tl(cpu_cc_dst, s->T0);
@@ -1131,6 +1133,7 @@ static void gen_BLSR(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode)
{
MemOp ot = decode->op[0].ot;
+ tcg_gen_mov_tl(cpu_cc_src, s->T0);
tcg_gen_subi_tl(s->T1, s->T0, 1);
tcg_gen_and_tl(s->T0, s->T0, s->T1);
tcg_gen_mov_tl(cpu_cc_dst, s->T0);
--
2.39.1
next prev parent reply other threads:[~2023-02-08 17:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 17:19 [PULL 00/11] Misc patches for 2022-02-08 Paolo Bonzini
2023-02-08 17:19 ` [PULL 01/11] build: make meson-buildoptions.sh stable Paolo Bonzini
2023-02-08 17:19 ` [PULL 02/11] remove unnecessary extern "C" blocks Paolo Bonzini
2023-02-08 17:19 ` [PULL 03/11] block/iscsi: fix double-free on BUSY or similar statuses Paolo Bonzini
2023-02-21 12:15 ` Fiona Ebner
2023-02-08 17:19 ` [PULL 04/11] vl: catch [accel] entry without accelerator Paolo Bonzini
2023-02-08 17:19 ` [PULL 05/11] libqtest: split qtest_spawn_qemu function Paolo Bonzini
2023-02-08 17:19 ` [PULL 06/11] libqtest: ensure waitpid() is only called once Paolo Bonzini
2023-02-08 17:19 ` [PULL 07/11] readconfig-test: add test for accelerator configuration Paolo Bonzini
2023-02-09 5:21 ` Thomas Huth
2023-02-09 9:01 ` Paolo Bonzini
2023-02-08 17:19 ` [PULL 08/11] tests/tcg/i386: Introduce and use reg_t consistently Paolo Bonzini
2023-02-08 17:19 ` [PULL 09/11] target/i386: Fix BEXTR instruction Paolo Bonzini
2023-02-10 10:23 ` Michael Tokarev
2023-02-08 17:19 ` Paolo Bonzini [this message]
2023-02-08 17:19 ` [PULL 11/11] target/i386: fix ADOX followed by ADCX Paolo Bonzini
2023-02-09 5:19 ` [PULL 00/11] Misc patches for 2022-02-08 Thomas Huth
2023-02-09 7:09 ` Philippe Mathieu-Daudé
2023-02-09 9:02 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208171922.95048-11-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).