qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kfir Manor <kfir@daynix.com>
To: qemu-devel@nongnu.org, Konstantin Kostiuk <kkostiuk@redhat.com>,
	Michael Roth <michael.roth@amd.com>
Cc: Yan Vugenfirer <yan@daynix.com>
Subject: [PATCH 0/3] qga/win/vss: add VSS backup type options
Date: Thu,  9 Feb 2023 10:50:01 +0200	[thread overview]
Message-ID: <20230209085004.2745131-1-kfir@daynix.com> (raw)

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/775

The problem, VSS backup type VSS-FULL (the only available VSS backup type currently) can break other backups that use VSS-FULL(for example, Bareos-Fullbackup).

Fix, add other backup types.

Implementation, put the desired backup type number inside Regkey value HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\QEMU Guest Agent VSS Provider\VssOption, so that the program can query the desired backup type.

VSS backup types:
number   type
1        VSS_BT_FULL
2        VSS_BT_INCREMENTAL
3        VSS_BT_DIFFERENTIAL
4        VSS_BT_LOG
5        VSS_BT_COPY

for more information about the different backup types https://learn.microsoft.com/en-us/windows/win32/vss/vss-backup-state

Additionally, the program would work as before with VSS-FULL in cases where VssOption doesn't exist, or VssOption value isn't a known backup type.

Kfir Manor (3):
  add VssOption to installer
  query VSS backup type
  requester_freeze changes

 qga/installer/qemu-ga.wxs   |  4 ++++
 qga/vss-win32/requester.cpp | 41 ++++++++++++++++++++++++++++++++++++-
 qga/vss-win32/vss-handles.h |  3 +++
 3 files changed, 47 insertions(+), 1 deletion(-)

-- 
2.38.1



             reply	other threads:[~2023-02-09  8:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09  8:50 Kfir Manor [this message]
2023-02-09  8:50 ` [PATCH 1/3] qga/win/installer: add VssOption to installer Kfir Manor
2023-02-15 10:22   ` Konstantin Kostiuk
2023-02-09  8:50 ` [PATCH 2/3] qga/win/vss: query VSS backup type Kfir Manor
2023-02-15 10:23   ` Konstantin Kostiuk
2023-02-09  8:50 ` [PATCH 3/3] qga/win/vss: requester_freeze changes Kfir Manor
2023-02-15 10:23   ` Konstantin Kostiuk
2023-02-13 16:20 ` [PATCH 0/3] qga/win/vss: add VSS backup type options Konstantin Kostiuk
2023-02-14  9:20   ` Marc-André Lureau
2023-02-15 10:21     ` Konstantin Kostiuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209085004.2745131-1-kfir@daynix.com \
    --to=kfir@daynix.com \
    --cc=kkostiuk@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).