qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Michael Roth <michael.roth@amd.com>,
	Markus Armbruster <armbru@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: [PATCH v3 0/7] qapi: static typing conversion, pt5c
Date: Thu,  9 Feb 2023 13:47:51 -0500	[thread overview]
Message-ID: <20230209184758.1017863-1-jsnow@redhat.com> (raw)

This is part five (c), and focuses on sharing strict types between
parser.py and expr.py.

gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5c

Every commit should pass with:
 - `isort -c qapi/`
 - `flake8 qapi/`
 - `pylint --rcfile=qapi/pylintrc qapi/`
 - `mypy --config-file=qapi/mypy.ini qapi/`

V3:
 - Squashed a bunch of patches into the QAPIExpression patch
 - Added a few 'info' locals whenever there were >= 3 usages to help
   minimize some churn
 - Removed some type redundancy from docstrings
 - Brought along the two patches from pt0 that I want merged.
 - Removed 'pexpr' entirely, there's no intermediate state where it's
   needed now.
 - Minor style issues.

John Snow (7):
  qapi: Update flake8 config
  qapi: update pylint configuration
  qapi/expr: Split check_expr out from check_exprs
  qapi/expr: add typing workaround for AbstractSet
  qapi/parser: add QAPIExpression type
  qapi: remove _JSONObject
  qapi: remove JSON value FIXME

 scripts/qapi/.flake8   |   3 +-
 scripts/qapi/expr.py   | 231 +++++++++++++++++++----------------------
 scripts/qapi/parser.py |  49 +++++----
 scripts/qapi/pylintrc  |   1 +
 scripts/qapi/schema.py |  72 +++++++------
 5 files changed, 181 insertions(+), 175 deletions(-)

-- 
2.39.0




             reply	other threads:[~2023-02-09 18:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 18:47 John Snow [this message]
2023-02-09 18:47 ` [PATCH v3 1/7] qapi: Update flake8 config John Snow
2023-02-09 18:47 ` [PATCH v3 2/7] qapi: update pylint configuration John Snow
2023-02-09 18:47 ` [PATCH v3 3/7] qapi/expr: Split check_expr out from check_exprs John Snow
2023-02-10 12:14   ` Markus Armbruster
2023-02-10 12:33   ` Markus Armbruster
2023-02-10 15:20     ` John Snow
2023-02-11 10:06       ` Markus Armbruster
2023-02-14 17:04         ` John Snow
2023-02-09 18:47 ` [PATCH v3 4/7] qapi/expr: add typing workaround for AbstractSet John Snow
2023-02-10 15:44   ` Markus Armbruster
2023-02-10 16:26     ` John Snow
2023-02-14 17:08       ` John Snow
2023-02-09 18:47 ` [PATCH v3 5/7] qapi/parser: add QAPIExpression type John Snow
2023-02-11  6:49   ` Markus Armbruster
2023-02-14 16:57     ` John Snow
2023-02-09 18:47 ` [PATCH v3 6/7] qapi: remove _JSONObject John Snow
2023-02-11  6:18   ` Markus Armbruster
2023-02-09 18:47 ` [PATCH v3 7/7] qapi: remove JSON value FIXME John Snow
2023-02-11  6:42   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209184758.1017863-1-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).