* [PATCH] target/i386: Remove pointless env_archcpu() in helper_rdmsr()
@ 2023-02-10 12:57 Philippe Mathieu-Daudé
2023-02-10 13:31 ` Daniel Henrique Barboza
2023-02-23 15:16 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-10 12:57 UTC (permalink / raw)
To: qemu-devel
Cc: Richard Henderson, Paolo Bonzini, Eduardo Habkost,
Philippe Mathieu-Daudé, Daniel Henrique Barboza
We have a X86CPU *cpu pointer available at the start of the function.
Inspired-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/i386/tcg/sysemu/misc_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/tcg/sysemu/misc_helper.c b/target/i386/tcg/sysemu/misc_helper.c
index e1528b7f80..e47db9376e 100644
--- a/target/i386/tcg/sysemu/misc_helper.c
+++ b/target/i386/tcg/sysemu/misc_helper.c
@@ -326,7 +326,7 @@ void helper_rdmsr(CPUX86State *env)
val = env->sysenter_eip;
break;
case MSR_IA32_APICBASE:
- val = cpu_get_apic_base(env_archcpu(env)->apic_state);
+ val = cpu_get_apic_base(x86_cpu->apic_state);
break;
case MSR_EFER:
val = env->efer;
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/i386: Remove pointless env_archcpu() in helper_rdmsr()
2023-02-10 12:57 [PATCH] target/i386: Remove pointless env_archcpu() in helper_rdmsr() Philippe Mathieu-Daudé
@ 2023-02-10 13:31 ` Daniel Henrique Barboza
2023-02-23 15:16 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Henrique Barboza @ 2023-02-10 13:31 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Richard Henderson, Paolo Bonzini, Eduardo Habkost
On 2/10/23 09:57, Philippe Mathieu-Daudé wrote:
> We have a X86CPU *cpu pointer available at the start of the function.
>
> Inspired-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> target/i386/tcg/sysemu/misc_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/tcg/sysemu/misc_helper.c b/target/i386/tcg/sysemu/misc_helper.c
> index e1528b7f80..e47db9376e 100644
> --- a/target/i386/tcg/sysemu/misc_helper.c
> +++ b/target/i386/tcg/sysemu/misc_helper.c
> @@ -326,7 +326,7 @@ void helper_rdmsr(CPUX86State *env)
> val = env->sysenter_eip;
> break;
> case MSR_IA32_APICBASE:
> - val = cpu_get_apic_base(env_archcpu(env)->apic_state);
> + val = cpu_get_apic_base(x86_cpu->apic_state);
> break;
> case MSR_EFER:
> val = env->efer;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/i386: Remove pointless env_archcpu() in helper_rdmsr()
2023-02-10 12:57 [PATCH] target/i386: Remove pointless env_archcpu() in helper_rdmsr() Philippe Mathieu-Daudé
2023-02-10 13:31 ` Daniel Henrique Barboza
@ 2023-02-23 15:16 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-23 15:16 UTC (permalink / raw)
To: qemu-devel
Cc: Richard Henderson, Paolo Bonzini, Eduardo Habkost,
Daniel Henrique Barboza
ping
On 10/2/23 13:57, Philippe Mathieu-Daudé wrote:
> We have a X86CPU *cpu pointer available at the start of the function.
>
> Inspired-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/i386/tcg/sysemu/misc_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/tcg/sysemu/misc_helper.c b/target/i386/tcg/sysemu/misc_helper.c
> index e1528b7f80..e47db9376e 100644
> --- a/target/i386/tcg/sysemu/misc_helper.c
> +++ b/target/i386/tcg/sysemu/misc_helper.c
> @@ -326,7 +326,7 @@ void helper_rdmsr(CPUX86State *env)
> val = env->sysenter_eip;
> break;
> case MSR_IA32_APICBASE:
> - val = cpu_get_apic_base(env_archcpu(env)->apic_state);
> + val = cpu_get_apic_base(x86_cpu->apic_state);
> break;
> case MSR_EFER:
> val = env->efer;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-23 15:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-10 12:57 [PATCH] target/i386: Remove pointless env_archcpu() in helper_rdmsr() Philippe Mathieu-Daudé
2023-02-10 13:31 ` Daniel Henrique Barboza
2023-02-23 15:16 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).