qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Peter Xu" <peterx@redhat.com>
Subject: [PULL 16/22] migration: Add a semaphore to count PONGs
Date: Mon, 13 Feb 2023 03:51:44 +0100	[thread overview]
Message-ID: <20230213025150.71537-17-quintela@redhat.com> (raw)
In-Reply-To: <20230213025150.71537-1-quintela@redhat.com>

From: Peter Xu <peterx@redhat.com>

This is mostly useless, but useful for us to know whether the main channel
is correctly established without changing the migration protocol.

Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/migration.h | 6 ++++++
 migration/migration.c | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/migration/migration.h b/migration/migration.h
index c351872360..4cb1cb6fa8 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -276,6 +276,12 @@ struct MigrationState {
          */
         bool          rp_thread_created;
         QemuSemaphore rp_sem;
+        /*
+         * We post to this when we got one PONG from dest. So far it's an
+         * easy way to know the main channel has successfully established
+         * on dest QEMU.
+         */
+        QemuSemaphore rp_pong_acks;
     } rp_state;
 
     double mbps;
diff --git a/migration/migration.c b/migration/migration.c
index fb0ecf5649..a2e362541d 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3025,6 +3025,7 @@ retry:
         case MIG_RP_MSG_PONG:
             tmp32 = ldl_be_p(buf);
             trace_source_return_path_thread_pong(tmp32);
+            qemu_sem_post(&ms->rp_state.rp_pong_acks);
             break;
 
         case MIG_RP_MSG_REQ_PAGES:
@@ -4524,6 +4525,7 @@ static void migration_instance_finalize(Object *obj)
     qemu_sem_destroy(&ms->postcopy_pause_sem);
     qemu_sem_destroy(&ms->postcopy_pause_rp_sem);
     qemu_sem_destroy(&ms->rp_state.rp_sem);
+    qemu_sem_destroy(&ms->rp_state.rp_pong_acks);
     qemu_sem_destroy(&ms->postcopy_qemufile_src_sem);
     error_free(ms->error);
 }
@@ -4570,6 +4572,7 @@ static void migration_instance_init(Object *obj)
     qemu_sem_init(&ms->postcopy_pause_sem, 0);
     qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
     qemu_sem_init(&ms->rp_state.rp_sem, 0);
+    qemu_sem_init(&ms->rp_state.rp_pong_acks, 0);
     qemu_sem_init(&ms->rate_limit_sem, 0);
     qemu_sem_init(&ms->wait_unplug_sem, 0);
     qemu_sem_init(&ms->postcopy_qemufile_src_sem, 0);
-- 
2.39.1



  parent reply	other threads:[~2023-02-13  2:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  2:51 [PULL 00/22] Migration 20230213 patches Juan Quintela
2023-02-13  2:51 ` [PULL 01/22] migration: Remove spurious files Juan Quintela
2023-02-13  2:51 ` [PULL 02/22] multifd: cleanup the function multifd_channel_connect Juan Quintela
2023-02-13  2:51 ` [PULL 03/22] multifd: Remove some redundant code Juan Quintela
2023-02-13  2:51 ` [PULL 04/22] linux-headers: Update to v6.1 Juan Quintela
2023-02-13  2:51 ` [PULL 05/22] util/userfaultfd: Support /dev/userfaultfd Juan Quintela
2023-02-13  2:51 ` [PULL 06/22] migration: Simplify ram_find_and_save_block() Juan Quintela
2023-02-13  2:51 ` [PULL 07/22] migration: Make find_dirty_block() return a single parameter Juan Quintela
2023-02-13  2:51 ` [PULL 08/22] migration: Split ram_bytes_total_common() in two functions Juan Quintela
2023-02-13  2:51 ` [PULL 09/22] migration: Calculate ram size once Juan Quintela
2023-02-13  2:51 ` [PULL 10/22] migration: Make ram_save_target_page() a pointer Juan Quintela
2023-02-13  2:51 ` [PULL 11/22] migration: I messed state_pending_exact/estimate Juan Quintela
2023-02-13  2:51 ` [PULL 12/22] AVX512 support for xbzrle_encode_buffer Juan Quintela
2023-02-13  2:51 ` [PULL 13/22] Update bench-code for addressing CI problem Juan Quintela
2023-02-13  2:51 ` [PULL 14/22] migration: Rework multi-channel checks on URI Juan Quintela
2023-02-13  2:51 ` [PULL 15/22] migration: Cleanup postcopy_preempt_setup() Juan Quintela
2023-02-13  2:51 ` Juan Quintela [this message]
2023-02-13  2:51 ` [PULL 17/22] migration: Postpone postcopy preempt channel to be after main Juan Quintela
2023-02-13  2:51 ` [PULL 18/22] migration/multifd: Change multifd_load_cleanup() signature and usage Juan Quintela
2023-02-13  2:51 ` [PULL 19/22] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup() Juan Quintela
2023-02-13  2:51 ` [PULL 20/22] migration/multifd: Join all multifd threads in order to avoid leaks Juan Quintela
2023-02-13  2:51 ` [PULL 21/22] migration/multifd: Move load_cleanup inside incoming_state_destroy Juan Quintela
2023-02-13  2:51 ` [PULL 22/22] ram: Document migration ram flags Juan Quintela
2023-02-13 14:17 ` [PULL 00/22] Migration 20230213 patches Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2023-02-13  2:28 Xxx Xx
2023-02-13  2:29 ` [PULL 16/22] migration: Add a semaphore to count PONGs Xxx Xx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213025150.71537-17-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).