From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Li Xiaohui" <xiaohli@redhat.com>, "Peter Xu" <peterx@redhat.com>
Subject: [PULL 19/22] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup()
Date: Mon, 13 Feb 2023 03:51:47 +0100 [thread overview]
Message-ID: <20230213025150.71537-20-quintela@redhat.com> (raw)
In-Reply-To: <20230213025150.71537-1-quintela@redhat.com>
From: Leonardo Bras <leobras@redhat.com>
Before assigning "p->quit = true" for every multifd channel,
multifd_load_cleanup() will call multifd_recv_terminate_threads() which
already does the same assignment, while protected by a mutex.
So there is no point doing the same assignment again.
Fixes: b5eea99ec2 ("migration: Add yank feature")
Reported-by: Li Xiaohui <xiaohli@redhat.com>
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/multifd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index cac8496edc..3dd569d0c9 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -1025,7 +1025,6 @@ void multifd_load_cleanup(void)
MultiFDRecvParams *p = &multifd_recv_state->params[i];
if (p->running) {
- p->quit = true;
/*
* multifd_recv_thread may hung at MULTIFD_FLAG_SYNC handle code,
* however try to wakeup it without harm in cleanup phase.
--
2.39.1
next prev parent reply other threads:[~2023-02-13 2:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 2:51 [PULL 00/22] Migration 20230213 patches Juan Quintela
2023-02-13 2:51 ` [PULL 01/22] migration: Remove spurious files Juan Quintela
2023-02-13 2:51 ` [PULL 02/22] multifd: cleanup the function multifd_channel_connect Juan Quintela
2023-02-13 2:51 ` [PULL 03/22] multifd: Remove some redundant code Juan Quintela
2023-02-13 2:51 ` [PULL 04/22] linux-headers: Update to v6.1 Juan Quintela
2023-02-13 2:51 ` [PULL 05/22] util/userfaultfd: Support /dev/userfaultfd Juan Quintela
2023-02-13 2:51 ` [PULL 06/22] migration: Simplify ram_find_and_save_block() Juan Quintela
2023-02-13 2:51 ` [PULL 07/22] migration: Make find_dirty_block() return a single parameter Juan Quintela
2023-02-13 2:51 ` [PULL 08/22] migration: Split ram_bytes_total_common() in two functions Juan Quintela
2023-02-13 2:51 ` [PULL 09/22] migration: Calculate ram size once Juan Quintela
2023-02-13 2:51 ` [PULL 10/22] migration: Make ram_save_target_page() a pointer Juan Quintela
2023-02-13 2:51 ` [PULL 11/22] migration: I messed state_pending_exact/estimate Juan Quintela
2023-02-13 2:51 ` [PULL 12/22] AVX512 support for xbzrle_encode_buffer Juan Quintela
2023-02-13 2:51 ` [PULL 13/22] Update bench-code for addressing CI problem Juan Quintela
2023-02-13 2:51 ` [PULL 14/22] migration: Rework multi-channel checks on URI Juan Quintela
2023-02-13 2:51 ` [PULL 15/22] migration: Cleanup postcopy_preempt_setup() Juan Quintela
2023-02-13 2:51 ` [PULL 16/22] migration: Add a semaphore to count PONGs Juan Quintela
2023-02-13 2:51 ` [PULL 17/22] migration: Postpone postcopy preempt channel to be after main Juan Quintela
2023-02-13 2:51 ` [PULL 18/22] migration/multifd: Change multifd_load_cleanup() signature and usage Juan Quintela
2023-02-13 2:51 ` Juan Quintela [this message]
2023-02-13 2:51 ` [PULL 20/22] migration/multifd: Join all multifd threads in order to avoid leaks Juan Quintela
2023-02-13 2:51 ` [PULL 21/22] migration/multifd: Move load_cleanup inside incoming_state_destroy Juan Quintela
2023-02-13 2:51 ` [PULL 22/22] ram: Document migration ram flags Juan Quintela
2023-02-13 14:17 ` [PULL 00/22] Migration 20230213 patches Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2023-02-13 2:28 Xxx Xx
2023-02-13 2:29 ` [PULL 19/22] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup() Xxx Xx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213025150.71537-20-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=leobras@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=xiaohli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).