qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
	Gonglei Arei <arei.gonglei@huawei.com>, Li Qiang <liq3ea@163.com>,
	Cao jin <caoj.fnst@cn.fujitsu.com>, Hu Tao <hutao@cn.fujitsu.com>,
	qemu-block@nongnu.org, qemu-ppc@nongnu.org,
	xiaoqiang zhao <zxq_yx_007@163.com>,
	Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH v2 4/9] hw/net: Replace dev->parent_bus by qdev_get_parent_bus(dev)
Date: Mon, 13 Feb 2023 05:52:24 -0500	[thread overview]
Message-ID: <20230213055218-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230213070423.76428-5-philmd@linaro.org>

On Mon, Feb 13, 2023 at 08:04:18AM +0100, Philippe Mathieu-Daudé wrote:
> DeviceState::parent_bus is an internal field and should be
> accessed by the qdev_get_parent_bus() helper.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/net/virtio-net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 3ae909041a..8bc160ab59 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -3423,7 +3423,7 @@ static bool failover_replug_primary(VirtIONet *n, DeviceState *dev,
>      if (!pdev->partially_hotplugged) {
>          return true;
>      }
> -    primary_bus = dev->parent_bus;
> +    primary_bus = qdev_get_parent_bus(dev);
>      if (!primary_bus) {
>          error_setg(errp, "virtio_net: couldn't find primary bus");
>          return false;
> -- 
> 2.38.1



  reply	other threads:[~2023-02-13 10:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  7:04 [PATCH v2 0/9] hw/qdev: Housekeeping around qdev_get_parent_bus() Philippe Mathieu-Daudé
2023-02-13  7:04 ` [PATCH v2 1/9] hw/qdev: Constify DeviceState* argument of qdev_get_parent_bus() Philippe Mathieu-Daudé
2023-02-13  7:04 ` [PATCH v2 2/9] hw/audio: Replace dev->parent_bus by qdev_get_parent_bus(dev) Philippe Mathieu-Daudé
2023-02-13  7:04 ` [PATCH v2 3/9] hw/block: " Philippe Mathieu-Daudé
2023-02-13  7:04 ` [PATCH v2 4/9] hw/net: " Philippe Mathieu-Daudé
2023-02-13 10:52   ` Michael S. Tsirkin [this message]
2023-02-13  7:04 ` [PATCH v2 5/9] hw/pci: " Philippe Mathieu-Daudé
2023-02-13 10:52   ` Michael S. Tsirkin
2023-02-13  7:04 ` [PATCH v2 6/9] hw/ppc: " Philippe Mathieu-Daudé
2023-02-13  7:32   ` Cédric Le Goater
2023-02-13  7:04 ` [PATCH v2 7/9] hw/usb: " Philippe Mathieu-Daudé
2023-02-13  7:04 ` [PATCH v2 8/9] hw: Use qdev_get_parent_bus() in qdev_get_own_fw_dev_path_from_handler() Philippe Mathieu-Daudé
2023-02-13  7:04 ` [PATCH v2 9/9] qdev-monitor: Use qdev_get_parent_bus() in bus_print_dev() Philippe Mathieu-Daudé
2023-02-13  7:09   ` Markus Armbruster
2023-02-13 10:53 ` [PATCH v2 0/9] hw/qdev: Housekeeping around qdev_get_parent_bus() Michael S. Tsirkin
2023-02-13 11:07   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213055218-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=eduardo@habkost.net \
    --cc=hutao@cn.fujitsu.com \
    --cc=jasowang@redhat.com \
    --cc=liq3ea@163.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=zxq_yx_007@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).