qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Sunil Muthuswamy <sunilmut@microsoft.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	qemu-trivial@nongnu.org,
	Richard Henderson <richard.henderson@linaro.org>,
	Juan Quintela <quintela@redhat.com>,
	Eduardo Habkost <eduardo@habkost.net>,
	Thomas Huth <thuth@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	BALATON Zoltan <balaton@eik.bme.hu>, Ani Sinha <ani@anisinha.ca>,
	Laurent Vivier <lvivier@redhat.com>,
	Bernhard Beschow <shentey@gmail.com>
Subject: [PATCH v4 9/9] target/i386/tcg/sysemu/tcg-cpu: Avoid own opinion about smram size
Date: Mon, 13 Feb 2023 17:20:04 +0100	[thread overview]
Message-ID: <20230213162004.2797-10-shentey@gmail.com> (raw)
In-Reply-To: <20230213162004.2797-1-shentey@gmail.com>

When setting up the CPU's smram memory region alias, the code currently
assumes that the smram size is 4 GiB. While this is true, it repeats a
decision made elsewhere which seems redundant and prone to
inconsistencies. Avoid this by reusing whatever size the smram region
was set to.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 target/i386/tcg/sysemu/tcg-cpu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/i386/tcg/sysemu/tcg-cpu.c b/target/i386/tcg/sysemu/tcg-cpu.c
index c223c0fe9b..8f5ce6093c 100644
--- a/target/i386/tcg/sysemu/tcg-cpu.c
+++ b/target/i386/tcg/sysemu/tcg-cpu.c
@@ -22,7 +22,6 @@
 #include "tcg/helper-tcg.h"
 
 #include "sysemu/sysemu.h"
-#include "qemu/units.h"
 #include "exec/address-spaces.h"
 
 #include "tcg/tcg-cpu.h"
@@ -36,7 +35,7 @@ static void tcg_cpu_machine_done(Notifier *n, void *unused)
     if (smram) {
         cpu->smram = g_new(MemoryRegion, 1);
         memory_region_init_alias(cpu->smram, OBJECT(cpu), "smram",
-                                 smram, 0, 4 * GiB);
+                                 smram, 0, memory_region_size(smram));
         memory_region_set_enabled(cpu->smram, true);
         memory_region_add_subregion_overlap(cpu->cpu_as_root, 0,
                                             cpu->smram, 1);
-- 
2.39.1



  parent reply	other threads:[~2023-02-13 16:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 16:19 [PATCH v4 0/9] PC cleanups Bernhard Beschow
2023-02-13 16:19 ` [PATCH v4 1/9] hw/pci-host/i440fx: Inline sysbus_add_io() Bernhard Beschow
2023-02-22 10:58   ` Philippe Mathieu-Daudé
2023-02-22 18:05     ` Bernhard Beschow
2023-03-06  6:57       ` Bernhard Beschow
2023-03-07 22:32         ` Philippe Mathieu-Daudé
2023-02-13 16:19 ` [PATCH v4 2/9] hw/pci-host/q35: " Bernhard Beschow
2023-02-13 16:19 ` [PATCH v4 3/9] hw/i386/pc_q35: Reuse machine parameter Bernhard Beschow
2023-02-22 11:03   ` Philippe Mathieu-Daudé
2023-02-22 17:52     ` Bernhard Beschow
2023-02-22 20:24       ` Michael S. Tsirkin
2023-02-13 16:19 ` [PATCH v4 4/9] hw/i386/pc_{q35, piix}: Reuse MachineClass::desc as SMB product name Bernhard Beschow
2023-02-13 16:20 ` [PATCH v4 5/9] hw/i386/pc_{q35, piix}: Minimize usage of get_system_memory() Bernhard Beschow
2023-02-22 11:05   ` Philippe Mathieu-Daudé
2023-02-13 16:20 ` [PATCH v4 6/9] hw/i386/pc: Initialize ram_memory variable directly Bernhard Beschow
2023-02-22  2:38   ` Xiaoyao Li
2023-02-22  8:21     ` Bernhard Beschow
2023-02-13 16:20 ` [PATCH v4 7/9] hw/pci-host/pam: Make init_pam() usage more readable Bernhard Beschow
2023-02-13 16:20 ` [PATCH v4 8/9] hw/i386/x86: Make TYPE_X86_MACHINE the owner of smram Bernhard Beschow
2023-02-13 16:20 ` Bernhard Beschow [this message]
2023-02-13 16:45 ` [PATCH v4 0/9] PC cleanups Bernhard Beschow
2023-03-05  7:45   ` Bernhard Beschow
2023-03-05 10:09     ` Michael S. Tsirkin
2023-03-07 22:34       ` Philippe Mathieu-Daudé
2023-05-10 18:26     ` Bernhard Beschow
2023-05-10 19:20       ` Michael S. Tsirkin
2023-05-10 21:19         ` Bernhard Beschow
2023-02-21 15:40 ` Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213162004.2797-10-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=ani@anisinha.ca \
    --cc=balaton@eik.bme.hu \
    --cc=dgilbert@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=sunilmut@microsoft.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).