qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>
Subject: [PATCH v3 00/12] qtests vs. default devices
Date: Mon, 13 Feb 2023 18:07:26 -0300	[thread overview]
Message-ID: <20230213210738.9719-1-farosas@suse.de> (raw)

I based this on master this time, the Kconfig series might take
longer.

patch 4 - changed conditional to use the same style as surrounding
          code;

v2:

patch 3 - fixed typo s/PCIE_ROOT/PCIE_PORT and dropped runtime check;

patch 4 - dropped runtime check and added a dep on CONFIG_VIRTIO_SERIAL;

patch 7 - added skip messages and folded look_for_device_builtin into
          has_device_builtin;

patch 9 - dropped runtime check;

v1:
https://lore.kernel.org/r/20230206150416.4604-1-farosas@suse.de

Most of our tests assume the presence of default devices. When
building --without-default-devices or with individual CONFIGs
disabled, several tests fail.

I went through them one by one and did local changes to skip or avoid
including tests that require devices that are missing. With these
initial changes, 'make check' now passes for the
--without-default-devices build for x86 and arm.

However, the approach of making local changes seems hard to maintain:
every time a CONFIG changes from 'y' to 'n' a test might break and all
new tests need to remember to check before adding devices, which some
tests add several.

So the last patch in the series provides an alternative: Parse the
command line at qtest_init and skip the test if devices are
missing. Individual tests would have to check 'if (!qts)' and
bail. Seems a bit heavy-weight, but it would mean we don't have to put
a qtest_has_device check for every device in every test.

Based on: <20230206140809.26028-1-farosas@suse.de>
[PATCH 00/10] Kconfig vs. default devices
https://lore.kernel.org/r/20230206140809.26028-1-farosas@suse.de

Fabiano Rosas (12):
  tests/qtest: Skip PXE tests for missing devices
  tests/qtest: Do not run lsi53c895a test if device is not present
  tests/qtest: Add dependence on PCIE_PORT for virtio-net-failover.c
  tests/qtest: Don't build virtio-serial-test.c if device not present
  tests/qtest: hd-geo-test: Check for missing devices
  tests/qtest: Fix coding style in device-plug-test.c
  tests/qtest: Skip unplug tests that use missing devices
  tests/qtest: drive_del-test: Skip tests that require missing devices
  tests/qtest: Check for devices in bios-tables-test
  tests/qtest: Do not include hexloader-test if loader device is not
    present
  tests/qemu-iotests: Require virtio-scsi-pci
  tests/qtest: bios-tables-test: Skip if missing configs

 tests/qemu-iotests/186             |  1 +
 tests/qtest/bios-tables-test.c     | 75 ++++++++++++++++++++++++++++--
 tests/qtest/device-plug-test.c     | 41 ++++++++++++----
 tests/qtest/drive_del-test.c       | 65 ++++++++++++++++++++++++++
 tests/qtest/fuzz-lsi53c895a-test.c |  4 ++
 tests/qtest/hd-geo-test.c          | 38 +++++++++------
 tests/qtest/meson.build            | 17 +++++--
 tests/qtest/pxe-test.c             |  4 ++
 8 files changed, 214 insertions(+), 31 deletions(-)

-- 
2.35.3



             reply	other threads:[~2023-02-13 21:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 21:07 Fabiano Rosas [this message]
2023-02-13 21:07 ` [PATCH v3 01/12] tests/qtest: Skip PXE tests for missing devices Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 02/12] tests/qtest: Do not run lsi53c895a test if device is not present Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 03/12] tests/qtest: Add dependence on PCIE_PORT for virtio-net-failover.c Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 04/12] tests/qtest: Don't build virtio-serial-test.c if device not present Fabiano Rosas
2023-02-14  7:57   ` Thomas Huth
2023-02-13 21:07 ` [PATCH v3 05/12] tests/qtest: hd-geo-test: Check for missing devices Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 06/12] tests/qtest: Fix coding style in device-plug-test.c Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 07/12] tests/qtest: Skip unplug tests that use missing devices Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 08/12] tests/qtest: drive_del-test: Skip tests that require " Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 09/12] tests/qtest: Check for devices in bios-tables-test Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 10/12] tests/qtest: Do not include hexloader-test if loader device is not present Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 11/12] tests/qemu-iotests: Require virtio-scsi-pci Fabiano Rosas
2023-02-13 21:07 ` [PATCH v3 12/12] tests/qtest: bios-tables-test: Skip if missing configs Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213210738.9719-1-farosas@suse.de \
    --to=farosas@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).