qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: "Eugenio Pérez" <eperezma@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>
Subject: [PULL 10/10] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check
Date: Tue, 14 Feb 2023 14:11:40 +0800	[thread overview]
Message-ID: <20230214061140.36696-11-jasowang@redhat.com> (raw)
In-Reply-To: <20230214061140.36696-1-jasowang@redhat.com>

From: Eugenio Pérez <eperezma@redhat.com>

VHOST_BACKEND_F_IOTLB_ASID is the feature bit, not the bitmask. Since
the device under test also provided VHOST_BACKEND_F_IOTLB_MSG_V2 and
VHOST_BACKEND_F_IOTLB_BATCH, this went unnoticed.

Fixes: c1a1008685 ("vdpa: always start CVQ in SVQ mode if possible")
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 net/vhost-vdpa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 1a13a34..de5ed8f 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -384,7 +384,7 @@ static int vhost_vdpa_net_cvq_start(NetClientState *nc)
             g_strerror(errno), errno);
         return -1;
     }
-    if (!(backend_features & VHOST_BACKEND_F_IOTLB_ASID) ||
+    if (!(backend_features & BIT_ULL(VHOST_BACKEND_F_IOTLB_ASID)) ||
         !vhost_vdpa_net_valid_svq_features(v->dev->features, NULL)) {
         return 0;
     }
-- 
2.7.4



  parent reply	other threads:[~2023-02-14  6:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  6:11 [PULL 00/10] Net patches Jason Wang
2023-02-14  6:11 ` [PULL 01/10] net: Move the code to collect available NIC models to a separate function Jason Wang
2023-02-14  6:11 ` [PULL 02/10] net: Restore printing of the help text with "-nic help" Jason Wang
2023-02-14  6:11 ` [PULL 03/10] net: Replace "Supported NIC models" with "Available NIC models" Jason Wang
2023-02-14  6:11 ` [PULL 04/10] hw/net/lan9118: log [read|write]b when mode_16bit is enabled rather than abort Jason Wang
2023-02-14  6:11 ` [PULL 05/10] hw/net/vmxnet3: allow VMXNET3_MAX_MTU itself as a value Jason Wang
2023-02-14  6:11 ` [PULL 06/10] net: Increase L2TPv3 buffer to fit jumboframes Jason Wang
2023-02-14  6:11 ` [PULL 07/10] vmnet: stop recieving events when VM is stopped Jason Wang
2023-02-14  6:11 ` [PULL 08/10] hw/net/can/xlnx-zynqmp-can: fix assertion failures in transfer_fifo() Jason Wang
2023-02-15 14:56   ` Philippe Mathieu-Daudé
2023-02-14  6:11 ` [PULL 09/10] net: stream: add a new option to automatically reconnect Jason Wang
2023-02-14  6:11 ` Jason Wang [this message]
2023-02-14 14:29 ` [PULL 00/10] Net patches Peter Maydell
2023-02-14 14:30   ` Peter Maydell
2023-02-15 14:39     ` Laurent Vivier
2023-02-16  4:45       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230214061140.36696-11-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).