qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>
Subject: [PULL 14/22] tests/qtest: Skip unplug tests that use missing devices
Date: Tue, 14 Feb 2023 12:21:40 +0100	[thread overview]
Message-ID: <20230214112148.646077-15-thuth@redhat.com> (raw)
In-Reply-To: <20230214112148.646077-1-thuth@redhat.com>

From: Fabiano Rosas <farosas@suse.de>

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Message-Id: <20230208194700.11035-8-farosas@suse.de>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/device-plug-test.c | 33 +++++++++++++++++++++++++++------
 1 file changed, 27 insertions(+), 6 deletions(-)

diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c
index 4f92617335..01cecd6e20 100644
--- a/tests/qtest/device-plug-test.c
+++ b/tests/qtest/device-plug-test.c
@@ -68,6 +68,11 @@ static void test_pci_unplug_request(void)
     const char *arch = qtest_get_arch();
     const char *machine_addition = "";
 
+    if (!qtest_has_device("virtio-mouse-pci")) {
+        g_test_skip("Device virtio-mouse-pci not available");
+        return;
+    }
+
     if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
         machine_addition = "-machine pc";
     }
@@ -82,11 +87,17 @@ static void test_pci_unplug_request(void)
 
 static void test_q35_pci_unplug_request(void)
 {
+    QTestState *qtest;
+
+    if (!qtest_has_device("virtio-mouse-pci")) {
+        g_test_skip("Device virtio-mouse-pci not available");
+        return;
+    }
 
-    QTestState *qtest = qtest_initf("-machine q35 "
-                                    "-device pcie-root-port,id=p1 "
-                                    "-device pcie-pci-bridge,bus=p1,id=b1 "
-                                    "-device virtio-mouse-pci,bus=b1,id=dev0");
+    qtest = qtest_initf("-machine q35 "
+                        "-device pcie-root-port,id=p1 "
+                        "-device pcie-pci-bridge,bus=p1,id=b1 "
+                        "-device virtio-mouse-pci,bus=b1,id=dev0");
 
     process_device_remove(qtest, "dev0");
 
@@ -99,6 +110,11 @@ static void test_pci_unplug_json_request(void)
     const char *arch = qtest_get_arch();
     const char *machine_addition = "";
 
+    if (!qtest_has_device("virtio-mouse-pci")) {
+        g_test_skip("Device virtio-mouse-pci not available");
+        return;
+    }
+
     if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
         machine_addition = "-machine pc";
     }
@@ -114,6 +130,7 @@ static void test_pci_unplug_json_request(void)
 
 static void test_q35_pci_unplug_json_request(void)
 {
+    QTestState *qtest;
     const char *port = "-device \"{'driver': 'pcie-root-port', "
                                   "'id': 'p1'}\"";
 
@@ -125,8 +142,12 @@ static void test_q35_pci_unplug_json_request(void)
                                     "'bus': 'b1', "
                                     "'id': 'dev0'}\"";
 
-    QTestState *qtest = qtest_initf("-machine q35 %s %s %s",
-                                    port, bridge, device);
+    if (!qtest_has_device("virtio-mouse-pci")) {
+        g_test_skip("Device virtio-mouse-pci not available");
+        return;
+    }
+
+    qtest = qtest_initf("-machine q35 %s %s %s", port, bridge, device);
 
     process_device_remove(qtest, "dev0");
 
-- 
2.31.1



  parent reply	other threads:[~2023-02-14 11:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 11:21 [PULL 00/22] qtest, s390x and misc patches Thomas Huth
2023-02-14 11:21 ` [PULL 01/22] configure: Bump minimum Clang version to 10.0 Thomas Huth
2023-02-14 11:21 ` [PULL 02/22] meson: Add missing libdw knobs Thomas Huth
2023-02-14 11:21 ` [PULL 03/22] meson: Disable libdw for static builds by default Thomas Huth
2023-02-14 11:21 ` [PULL 04/22] build: deprecate --enable-gprof builds and remove from CI Thomas Huth
2023-02-14 11:21 ` [PULL 05/22] tests/qtest/npcm7xx_pwm-test: Be less verbose unless V=2 Thomas Huth
2023-02-14 11:21 ` [PULL 06/22] hw/misc/sga: Remove the deprecated "sga" device Thomas Huth
2023-02-14 11:21 ` [PULL 07/22] include/hw: Do not include "hw/registerfields.h" in headers that don't need it Thomas Huth
2023-02-14 11:21 ` [PULL 08/22] Do not include "qemu/error-report.h" in headers that do not " Thomas Huth
2023-02-14 11:21 ` [PULL 09/22] tests/qtest: Skip PXE tests for missing devices Thomas Huth
2023-02-14 11:21 ` [PULL 10/22] tests/qtest: Do not run lsi53c895a test if device is not present Thomas Huth
2023-02-14 11:21 ` [PULL 11/22] tests/qtest: Add dependence on PCIE_PORT for virtio-net-failover.c Thomas Huth
2023-02-14 11:21 ` [PULL 12/22] tests/qtest: hd-geo-test: Check for missing devices Thomas Huth
2023-02-14 11:21 ` [PULL 13/22] test/qtest: Fix coding style in device-plug-test.c Thomas Huth
2023-02-14 11:21 ` Thomas Huth [this message]
2023-02-14 11:21 ` [PULL 15/22] tests/qtest: drive_del-test: Skip tests that require missing devices Thomas Huth
2023-02-14 11:21 ` [PULL 16/22] tests/qtest: Check for devices in bios-tables-test Thomas Huth
2023-02-14 11:21 ` [PULL 17/22] tests/qtest: Do not include hexloader-test if loader device is not present Thomas Huth
2023-02-14 11:21 ` [PULL 18/22] tests/qemu-iotests: Require virtio-scsi-pci Thomas Huth
2023-02-14 11:21 ` [PULL 19/22] tests/qtest: bios-tables-test: Skip if missing configs Thomas Huth
2023-02-14 11:21 ` [PULL 20/22] tests/qtest: Don't build virtio-serial-test.c if device not present Thomas Huth
2023-02-14 11:21 ` [PULL 21/22] tests/tcg/s390x: Use -nostdlib for softmmu tests Thomas Huth
2023-02-14 11:21 ` [PULL 22/22] hw/s390x/event-facility: Replace DO_UPCAST(SCLPEvent) by SCLP_EVENT() Thomas Huth
2023-02-15 14:05 ` [PULL 00/22] qtest, s390x and misc patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230214112148.646077-15-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=farosas@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).