From: Stefano Stabellini <sstabellini@kernel.org>
To: peter.maydell@linaro.org
Cc: sstabellini@kernel.org, qemu-devel@nongnu.org,
Vikram Garhwal <vikram.garhwal@amd.com>,
Paul Durrant <paul@xen.org>
Subject: [PULL v2 07/10] hw/xen/xen-hvm-common: Use g_new and error_report
Date: Tue, 14 Feb 2023 15:43:27 -0800 [thread overview]
Message-ID: <20230214234330.2107879-7-sstabellini@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2302141541100.2025117@ubuntu-linux-20-04-desktop>
From: Vikram Garhwal <vikram.garhwal@amd.com>
Replace g_malloc with g_new and perror with error_report.
Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Paul Durrant <paul@xen.org>
---
hw/xen/xen-hvm-common.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c
index 5e3c7b073f..077c8dae5b 100644
--- a/hw/xen/xen-hvm-common.c
+++ b/hw/xen/xen-hvm-common.c
@@ -34,7 +34,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr,
trace_xen_ram_alloc(ram_addr, size);
nr_pfn = size >> TARGET_PAGE_BITS;
- pfn_list = g_malloc(sizeof (*pfn_list) * nr_pfn);
+ pfn_list = g_new(xen_pfn_t, nr_pfn);
for (i = 0; i < nr_pfn; i++) {
pfn_list[i] = (ram_addr >> TARGET_PAGE_BITS) + i;
@@ -731,7 +731,7 @@ void destroy_hvm_domain(bool reboot)
return;
}
if (errno != ENOTTY /* old Xen */) {
- perror("xendevicemodel_shutdown failed");
+ error_report("xendevicemodel_shutdown failed with error %d", errno);
}
/* well, try the old thing then */
}
@@ -801,7 +801,7 @@ static void xen_do_ioreq_register(XenIOState *state,
}
/* Note: cpus is empty at this point in init */
- state->cpu_by_vcpu_id = g_malloc0(max_cpus * sizeof(CPUState *));
+ state->cpu_by_vcpu_id = g_new0(CPUState *, max_cpus);
rc = xen_set_ioreq_server_state(xen_domid, state->ioservid, true);
if (rc < 0) {
@@ -810,7 +810,7 @@ static void xen_do_ioreq_register(XenIOState *state,
goto err;
}
- state->ioreq_local_port = g_malloc0(max_cpus * sizeof (evtchn_port_t));
+ state->ioreq_local_port = g_new0(evtchn_port_t, max_cpus);
/* FIXME: how about if we overflow the page here? */
for (i = 0; i < max_cpus; i++) {
@@ -864,13 +864,13 @@ void xen_register_ioreq(XenIOState *state, unsigned int max_cpus,
state->xce_handle = xenevtchn_open(NULL, 0);
if (state->xce_handle == NULL) {
- perror("xen: event channel open");
+ error_report("xen: event channel open failed with error %d", errno);
goto err;
}
state->xenstore = xs_daemon_open();
if (state->xenstore == NULL) {
- perror("xen: xenstore open");
+ error_report("xen: xenstore open failed with error %d", errno);
goto err;
}
--
2.25.1
next prev parent reply other threads:[~2023-02-14 23:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 23:43 [PULL v2 0/10] xenpvh Stefano Stabellini
2023-02-14 23:43 ` [PULL v2 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/ Stefano Stabellini
2023-02-14 23:43 ` [PULL v2 02/10] hw/i386/xen: rearrange xen_hvm_init_pc Stefano Stabellini
2023-02-14 23:43 ` [PULL v2 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState Stefano Stabellini
2023-02-14 23:43 ` [PULL v2 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common Stefano Stabellini
2023-02-14 23:43 ` [PULL v2 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server Stefano Stabellini
2023-02-14 23:43 ` [PULL v2 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure Stefano Stabellini
2023-02-14 23:43 ` Stefano Stabellini [this message]
2023-02-14 23:43 ` [PULL v2 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets Stefano Stabellini
2023-02-14 23:43 ` [PULL v2 09/10] hw/arm: introduce xenpvh machine Stefano Stabellini
2023-02-14 23:43 ` [PULL v2 10/10] meson.build: enable xenpv machine build for ARM Stefano Stabellini
2023-02-15 18:36 ` [PULL v2 0/10] xenpvh Peter Maydell
2023-02-15 20:05 ` Fabiano Rosas
2023-02-15 21:17 ` Stefano Stabellini
2023-02-16 17:15 ` Peter Maydell
2023-02-16 12:59 ` Fabiano Rosas
2023-02-16 17:17 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214234330.2107879-7-sstabellini@kernel.org \
--to=sstabellini@kernel.org \
--cc=paul@xen.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vikram.garhwal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).