qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
	Michael Roth <michael.roth@amd.com>, John Snow <jsnow@redhat.com>
Subject: [PATCH v4 0/6] qapi: static typing conversion, pt5c
Date: Tue, 14 Feb 2023 19:00:05 -0500	[thread overview]
Message-ID: <20230215000011.1725012-1-jsnow@redhat.com> (raw)

This is part five (c), and focuses on sharing strict types between
parser.py and expr.py.

gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5c

Every commit should pass with:
 - `isort -c qapi/`
 - `flake8 qapi/`
 - `pylint --rcfile=qapi/pylintrc qapi/`
 - `mypy --config-file=qapi/mypy.ini qapi/`

V4:
 - Dropped the "split check_exprs" patch
 - Based the QAPIExpression class on Dict[str, object] instead
 - Removed the type workaround patch, which is no longer needed.
 - Added a new patch to fix a problem with Python 3.6 and pylint

V3:
 - Squashed a bunch of patches into the QAPIExpression patch
 - Added a few 'info' locals whenever there were >= 3 usages to help
   minimize some churn
 - Removed some type redundancy from docstrings
 - Brought along the two patches from pt0 that I want merged.
 - Removed 'pexpr' entirely, there's no intermediate state where it's
   needed now.
 - Minor style issues.

John Snow (6):
  qapi: Update flake8 config
  qapi: update pylint configuration
  qapi: Add minor typing workaround for 3.6
  qapi/parser: add QAPIExpression type
  qapi: remove _JSONObject
  qapi: remove JSON value FIXME

 scripts/qapi/.flake8   |   3 +-
 scripts/qapi/expr.py   | 101 ++++++++++++++++-------------------------
 scripts/qapi/parser.py |  41 +++++++++--------
 scripts/qapi/pylintrc  |   1 +
 scripts/qapi/schema.py |  72 +++++++++++++++--------------
 5 files changed, 104 insertions(+), 114 deletions(-)

-- 
2.39.0




             reply	other threads:[~2023-02-15  0:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15  0:00 John Snow [this message]
2023-02-15  0:00 ` [PATCH v4 1/6] qapi: Update flake8 config John Snow
2023-02-15  0:00 ` [PATCH v4 2/6] qapi: update pylint configuration John Snow
2023-02-15  0:00 ` [PATCH v4 3/6] qapi: Add minor typing workaround for 3.6 John Snow
2023-02-15  7:15   ` Markus Armbruster
2023-02-15 13:36     ` Markus Armbruster
2023-02-15 14:46       ` John Snow
2023-02-15  0:00 ` [PATCH v4 4/6] qapi/parser: add QAPIExpression type John Snow
2023-02-15  9:43   ` Markus Armbruster
2023-02-15 19:05     ` John Snow
2023-02-15  0:00 ` [PATCH v4 5/6] qapi: remove _JSONObject John Snow
2023-02-15  9:44   ` Markus Armbruster
2023-02-15  0:00 ` [PATCH v4 6/6] qapi: remove JSON value FIXME John Snow
2023-02-15 11:13   ` Markus Armbruster
2023-02-15 13:39 ` [PATCH v4 0/6] qapi: static typing conversion, pt5c Markus Armbruster
2023-02-21  1:26   ` John Snow
2023-02-21  6:42     ` Markus Armbruster
2023-02-21 17:32       ` John Snow
2023-02-22  9:16         ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230215000011.1725012-1-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).