From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Michael Roth <michael.roth@amd.com>, John Snow <jsnow@redhat.com>
Subject: [PATCH v4 3/6] qapi: Add minor typing workaround for 3.6
Date: Tue, 14 Feb 2023 19:00:08 -0500 [thread overview]
Message-ID: <20230215000011.1725012-4-jsnow@redhat.com> (raw)
In-Reply-To: <20230215000011.1725012-1-jsnow@redhat.com>
Pylint under 3.6 does not believe that Collection is subscriptable at
runtime. It is, making this a Pylint
bug. https://github.com/PyCQA/pylint/issues/2377
They closed it as fixed, but that doesn't seem to be true as of Pylint
2.13.9, the latest version you can install under Python 3.6. 2.13.9 was
released 2022-05-13, about seven months after the bug was closed.
The least-annoying fix here is to just use the more specific type
Sequence, only because it seems to work in 3.6.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/expr.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index 5a1782b57ea..8701351fdfc 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -33,11 +33,11 @@
import re
from typing import (
- Collection,
Dict,
Iterable,
List,
Optional,
+ Sequence,
Union,
cast,
)
@@ -195,8 +195,8 @@ def check_defn_name_str(name: str, info: QAPISourceInfo, meta: str) -> None:
def check_keys(value: _JSONObject,
info: QAPISourceInfo,
source: str,
- required: Collection[str],
- optional: Collection[str]) -> None:
+ required: Sequence[str],
+ optional: Sequence[str]) -> None:
"""
Ensure that a dict has a specific set of keys.
--
2.39.0
next prev parent reply other threads:[~2023-02-15 0:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 0:00 [PATCH v4 0/6] qapi: static typing conversion, pt5c John Snow
2023-02-15 0:00 ` [PATCH v4 1/6] qapi: Update flake8 config John Snow
2023-02-15 0:00 ` [PATCH v4 2/6] qapi: update pylint configuration John Snow
2023-02-15 0:00 ` John Snow [this message]
2023-02-15 7:15 ` [PATCH v4 3/6] qapi: Add minor typing workaround for 3.6 Markus Armbruster
2023-02-15 13:36 ` Markus Armbruster
2023-02-15 14:46 ` John Snow
2023-02-15 0:00 ` [PATCH v4 4/6] qapi/parser: add QAPIExpression type John Snow
2023-02-15 9:43 ` Markus Armbruster
2023-02-15 19:05 ` John Snow
2023-02-15 0:00 ` [PATCH v4 5/6] qapi: remove _JSONObject John Snow
2023-02-15 9:44 ` Markus Armbruster
2023-02-15 0:00 ` [PATCH v4 6/6] qapi: remove JSON value FIXME John Snow
2023-02-15 11:13 ` Markus Armbruster
2023-02-15 13:39 ` [PATCH v4 0/6] qapi: static typing conversion, pt5c Markus Armbruster
2023-02-21 1:26 ` John Snow
2023-02-21 6:42 ` Markus Armbruster
2023-02-21 17:32 ` John Snow
2023-02-22 9:16 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215000011.1725012-4-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).