qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Paul Durrant" <paul@xen.org>,
	"Joao Martins" <joao.m.martins@oracle.com>,
	"Ankur Arora" <ankur.a.arora@oracle.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Juan Quintela" <quintela@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Julien Grall" <julien@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	armbru@redhat.com
Subject: [PATCH v11 04/59] i386/kvm: Add xen-version KVM accelerator property and init KVM Xen support
Date: Thu, 16 Feb 2023 06:23:49 +0000	[thread overview]
Message-ID: <20230216062444.2129371-5-dwmw2@infradead.org> (raw)
In-Reply-To: <20230216062444.2129371-1-dwmw2@infradead.org>

From: David Woodhouse <dwmw@amazon.co.uk>

This just initializes the basic Xen support in KVM for now. Only permitted
on TYPE_PC_MACHINE because that's where the sysbus devices for Xen heap
overlay, event channel, grant tables and other stuff will exist. There's
no point having the basic hypercall support if nothing else works.

Provide sysemu/kvm_xen.h and a kvm_xen_get_caps() which will be used
later by support devices.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Paul Durrant <paul@xen.org>
---
 accel/kvm/kvm-all.c         |  1 +
 include/sysemu/kvm_int.h    |  2 ++
 include/sysemu/kvm_xen.h    | 20 +++++++++++++
 target/i386/kvm/kvm.c       | 59 +++++++++++++++++++++++++++++++++++++
 target/i386/kvm/meson.build |  2 ++
 target/i386/kvm/xen-emu.c   | 58 ++++++++++++++++++++++++++++++++++++
 target/i386/kvm/xen-emu.h   | 19 ++++++++++++
 7 files changed, 161 insertions(+)
 create mode 100644 include/sysemu/kvm_xen.h
 create mode 100644 target/i386/kvm/xen-emu.c
 create mode 100644 target/i386/kvm/xen-emu.h

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 9b26582655..f242e36316 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -3703,6 +3703,7 @@ static void kvm_accel_instance_init(Object *obj)
     s->kvm_dirty_ring_size = 0;
     s->notify_vmexit = NOTIFY_VMEXIT_OPTION_RUN;
     s->notify_window = 0;
+    s->xen_version = 0;
 }
 
 /**
diff --git a/include/sysemu/kvm_int.h b/include/sysemu/kvm_int.h
index 60b520a13e..7f945bc763 100644
--- a/include/sysemu/kvm_int.h
+++ b/include/sysemu/kvm_int.h
@@ -118,6 +118,8 @@ struct KVMState
     struct KVMDirtyRingReaper reaper;
     NotifyVmexitOption notify_vmexit;
     uint32_t notify_window;
+    uint32_t xen_version;
+    uint32_t xen_caps;
 };
 
 void kvm_memory_listener_register(KVMState *s, KVMMemoryListener *kml,
diff --git a/include/sysemu/kvm_xen.h b/include/sysemu/kvm_xen.h
new file mode 100644
index 0000000000..296533f2d5
--- /dev/null
+++ b/include/sysemu/kvm_xen.h
@@ -0,0 +1,20 @@
+/*
+ * Xen HVM emulation support in KVM
+ *
+ * Copyright © 2019 Oracle and/or its affiliates. All rights reserved.
+ * Copyright © 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ *
+ */
+
+#ifndef QEMU_SYSEMU_KVM_XEN_H
+#define QEMU_SYSEMU_KVM_XEN_H
+
+uint32_t kvm_xen_get_caps(void);
+
+#define kvm_xen_has_cap(cap) (!!(kvm_xen_get_caps() &           \
+                                 KVM_XEN_HVM_CONFIG_ ## cap))
+
+#endif /* QEMU_SYSEMU_KVM_XEN_H */
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 5870301991..aa6eac7cad 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -31,6 +31,7 @@
 #include "sysemu/runstate.h"
 #include "kvm_i386.h"
 #include "sev.h"
+#include "xen-emu.h"
 #include "hyperv.h"
 #include "hyperv-proto.h"
 
@@ -42,6 +43,7 @@
 #include "qemu/error-report.h"
 #include "qemu/memalign.h"
 #include "hw/i386/x86.h"
+#include "hw/i386/pc.h"
 #include "hw/i386/apic.h"
 #include "hw/i386/apic_internal.h"
 #include "hw/i386/apic-msidef.h"
@@ -49,6 +51,8 @@
 #include "hw/i386/x86-iommu.h"
 #include "hw/i386/e820_memory_layout.h"
 
+#include "hw/xen/xen.h"
+
 #include "hw/pci/pci.h"
 #include "hw/pci/msi.h"
 #include "hw/pci/msix.h"
@@ -2514,6 +2518,22 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
         }
     }
 
+    if (s->xen_version) {
+#ifdef CONFIG_XEN_EMU
+        if (!object_dynamic_cast(OBJECT(ms), TYPE_PC_MACHINE)) {
+            error_report("kvm: Xen support only available in PC machine");
+            return -ENOTSUP;
+        }
+        ret = kvm_xen_init(s);
+        if (ret < 0) {
+            return ret;
+        }
+#else
+        error_report("kvm: Xen support not enabled in qemu");
+        return -ENOTSUP;
+#endif
+    }
+
     ret = kvm_get_supported_msrs(s);
     if (ret < 0) {
         return ret;
@@ -5704,6 +5724,36 @@ static void kvm_arch_set_notify_window(Object *obj, Visitor *v,
     s->notify_window = value;
 }
 
+static void kvm_arch_get_xen_version(Object *obj, Visitor *v,
+                                     const char *name, void *opaque,
+                                     Error **errp)
+{
+    KVMState *s = KVM_STATE(obj);
+    uint32_t value = s->xen_version;
+
+    visit_type_uint32(v, name, &value, errp);
+}
+
+static void kvm_arch_set_xen_version(Object *obj, Visitor *v,
+                                     const char *name, void *opaque,
+                                     Error **errp)
+{
+    KVMState *s = KVM_STATE(obj);
+    Error *error = NULL;
+    uint32_t value;
+
+    visit_type_uint32(v, name, &value, &error);
+    if (error) {
+        error_propagate(errp, error);
+        return;
+    }
+
+    s->xen_version = value;
+    if (value && xen_mode == XEN_DISABLED) {
+        xen_mode = XEN_EMULATE;
+    }
+}
+
 void kvm_arch_accel_class_init(ObjectClass *oc)
 {
     object_class_property_add_enum(oc, "notify-vmexit", "NotifyVMexitOption",
@@ -5720,6 +5770,15 @@ void kvm_arch_accel_class_init(ObjectClass *oc)
     object_class_property_set_description(oc, "notify-window",
                                           "Clock cycles without an event window "
                                           "after which a notification VM exit occurs");
+
+    object_class_property_add(oc, "xen-version", "uint32",
+                              kvm_arch_get_xen_version,
+                              kvm_arch_set_xen_version,
+                              NULL, NULL);
+    object_class_property_set_description(oc, "xen-version",
+                                          "Xen version to be emulated "
+                                          "(in XENVER_version form "
+                                          "e.g. 0x4000a for 4.10)");
 }
 
 void kvm_set_max_apic_id(uint32_t max_apic_id)
diff --git a/target/i386/kvm/meson.build b/target/i386/kvm/meson.build
index 736df8b72e..322272091b 100644
--- a/target/i386/kvm/meson.build
+++ b/target/i386/kvm/meson.build
@@ -7,6 +7,8 @@ i386_softmmu_kvm_ss.add(files(
   'kvm-cpu.c',
 ))
 
+i386_softmmu_kvm_ss.add(when: 'CONFIG_XEN_EMU', if_true: files('xen-emu.c'))
+
 i386_softmmu_kvm_ss.add(when: 'CONFIG_SEV', if_false: files('sev-stub.c'))
 
 i386_softmmu_ss.add(when: 'CONFIG_HYPERV', if_true: files('hyperv.c'), if_false: files('hyperv-stub.c'))
diff --git a/target/i386/kvm/xen-emu.c b/target/i386/kvm/xen-emu.c
new file mode 100644
index 0000000000..b556d903aa
--- /dev/null
+++ b/target/i386/kvm/xen-emu.c
@@ -0,0 +1,58 @@
+/*
+ * Xen HVM emulation support in KVM
+ *
+ * Copyright © 2019 Oracle and/or its affiliates. All rights reserved.
+ * Copyright © 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ *
+ */
+
+#include "qemu/osdep.h"
+#include "sysemu/kvm_int.h"
+#include "sysemu/kvm_xen.h"
+#include "kvm/kvm_i386.h"
+#include "xen-emu.h"
+
+int kvm_xen_init(KVMState *s)
+{
+    const int required_caps = KVM_XEN_HVM_CONFIG_HYPERCALL_MSR |
+        KVM_XEN_HVM_CONFIG_INTERCEPT_HCALL | KVM_XEN_HVM_CONFIG_SHARED_INFO;
+    struct kvm_xen_hvm_config cfg = {
+        .msr = XEN_HYPERCALL_MSR,
+        .flags = KVM_XEN_HVM_CONFIG_INTERCEPT_HCALL,
+    };
+    int xen_caps, ret;
+
+    xen_caps = kvm_check_extension(s, KVM_CAP_XEN_HVM);
+    if (required_caps & ~xen_caps) {
+        error_report("kvm: Xen HVM guest support not present or insufficient");
+        return -ENOSYS;
+    }
+
+    if (xen_caps & KVM_XEN_HVM_CONFIG_EVTCHN_SEND) {
+        struct kvm_xen_hvm_attr ha = {
+            .type = KVM_XEN_ATTR_TYPE_XEN_VERSION,
+            .u.xen_version = s->xen_version,
+        };
+        (void)kvm_vm_ioctl(s, KVM_XEN_HVM_SET_ATTR, &ha);
+
+        cfg.flags |= KVM_XEN_HVM_CONFIG_EVTCHN_SEND;
+    }
+
+    ret = kvm_vm_ioctl(s, KVM_XEN_HVM_CONFIG, &cfg);
+    if (ret < 0) {
+        error_report("kvm: Failed to enable Xen HVM support: %s",
+                     strerror(-ret));
+        return ret;
+    }
+
+    s->xen_caps = xen_caps;
+    return 0;
+}
+
+uint32_t kvm_xen_get_caps(void)
+{
+    return kvm_state->xen_caps;
+}
diff --git a/target/i386/kvm/xen-emu.h b/target/i386/kvm/xen-emu.h
new file mode 100644
index 0000000000..4f31bd96cb
--- /dev/null
+++ b/target/i386/kvm/xen-emu.h
@@ -0,0 +1,19 @@
+/*
+ * Xen HVM emulation support in KVM
+ *
+ * Copyright © 2019 Oracle and/or its affiliates. All rights reserved.
+ * Copyright © 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ *
+ */
+
+#ifndef QEMU_I386_KVM_XEN_EMU_H
+#define QEMU_I386_KVM_XEN_EMU_H
+
+#define XEN_HYPERCALL_MSR 0x40000000
+
+int kvm_xen_init(KVMState *s);
+
+#endif /* QEMU_I386_KVM_XEN_EMU_H */
-- 
2.39.0



  parent reply	other threads:[~2023-02-16  6:31 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  6:23 [PATCH v11 00/59] Xen HVM support under KVM David Woodhouse
2023-02-16  6:23 ` [PATCH v11 01/59] include: import Xen public headers to hw/xen/interface David Woodhouse
2023-02-16  6:23 ` [PATCH v11 02/59] xen: add CONFIG_XEN_BUS and CONFIG_XEN_EMU options for Xen emulation David Woodhouse
2023-02-16  6:23 ` [PATCH v11 03/59] xen: Add XEN_DISABLED mode and make it default David Woodhouse
2023-02-16  6:23 ` David Woodhouse [this message]
2023-02-16  6:23 ` [PATCH v11 05/59] i386/kvm: handle Xen HVM cpuid leaves David Woodhouse
2023-02-16  6:23 ` [PATCH v11 06/59] i386/hvm: Set Xen vCPU ID in KVM David Woodhouse
2023-02-16  6:23 ` [PATCH v11 07/59] xen-platform: exclude vfio-pci from the PCI platform unplug David Woodhouse
2023-02-16  6:23 ` [PATCH v11 08/59] xen-platform: allow its creation with XEN_EMULATE mode David Woodhouse
2023-02-16  6:23 ` [PATCH v11 09/59] i386/xen: handle guest hypercalls David Woodhouse
2023-02-20 14:17   ` Paul Durrant
2023-02-16  6:23 ` [PATCH v11 10/59] i386/xen: implement HYPERVISOR_xen_version David Woodhouse
2023-02-16  6:23 ` [PATCH v11 11/59] i386/xen: implement HYPERVISOR_sched_op, SCHEDOP_shutdown David Woodhouse
2023-02-16  6:23 ` [PATCH v11 12/59] i386/xen: Implement SCHEDOP_poll and SCHEDOP_yield David Woodhouse
2023-02-16  6:23 ` [PATCH v11 13/59] hw/xen: Add xen_overlay device for emulating shared xenheap pages David Woodhouse
2023-02-16  6:23 ` [PATCH v11 14/59] xen: Permit --xen-domid argument when accel is KVM David Woodhouse
2023-02-16  6:24 ` [PATCH v11 15/59] i386/xen: add pc_machine_kvm_type to initialize XEN_EMULATE mode David Woodhouse
2023-02-16  6:24 ` [PATCH v11 16/59] i386/xen: manage and save/restore Xen guest long_mode setting David Woodhouse
2023-02-16  6:24 ` [PATCH v11 17/59] i386/xen: implement HYPERVISOR_memory_op David Woodhouse
2023-02-16  6:24 ` [PATCH v11 18/59] i386/xen: implement XENMEM_add_to_physmap_batch David Woodhouse
2023-02-16  6:24 ` [PATCH v11 19/59] i386/xen: implement HYPERVISOR_hvm_op David Woodhouse
2023-02-16  6:24 ` [PATCH v11 20/59] i386/xen: implement HYPERVISOR_vcpu_op David Woodhouse
2023-02-16  6:24 ` [PATCH v11 21/59] i386/xen: handle VCPUOP_register_vcpu_info David Woodhouse
2023-02-16  6:24 ` [PATCH v11 22/59] i386/xen: handle VCPUOP_register_vcpu_time_info David Woodhouse
2023-02-16  6:24 ` [PATCH v11 23/59] i386/xen: handle VCPUOP_register_runstate_memory_area David Woodhouse
2023-02-16  6:24 ` [PATCH v11 24/59] i386/xen: implement HYPERVISOR_event_channel_op David Woodhouse
2023-02-16  6:24 ` [PATCH v11 25/59] i386/xen: implement HVMOP_set_evtchn_upcall_vector David Woodhouse
2023-02-16  6:24 ` [PATCH v11 26/59] i386/xen: implement HVMOP_set_param David Woodhouse
2023-02-16  6:24 ` [PATCH v11 27/59] hw/xen: Add xen_evtchn device for event channel emulation David Woodhouse
2023-02-16  6:24 ` [PATCH v11 28/59] i386/xen: Add support for Xen event channel delivery to vCPU David Woodhouse
2023-02-16  6:24 ` [PATCH v11 29/59] hw/xen: Implement EVTCHNOP_status David Woodhouse
2023-02-16  6:24 ` [PATCH v11 30/59] hw/xen: Implement EVTCHNOP_close David Woodhouse
2023-02-16  6:24 ` [PATCH v11 31/59] hw/xen: Implement EVTCHNOP_unmask David Woodhouse
2023-02-16  6:24 ` [PATCH v11 32/59] hw/xen: Implement EVTCHNOP_bind_virq David Woodhouse
2023-02-16  6:24 ` [PATCH v11 33/59] hw/xen: Implement EVTCHNOP_bind_ipi David Woodhouse
2023-02-16  6:24 ` [PATCH v11 34/59] hw/xen: Implement EVTCHNOP_send David Woodhouse
2023-02-16  6:24 ` [PATCH v11 35/59] hw/xen: Implement EVTCHNOP_alloc_unbound David Woodhouse
2023-02-16  6:24 ` [PATCH v11 36/59] hw/xen: Implement EVTCHNOP_bind_interdomain David Woodhouse
2023-02-16  6:24 ` [PATCH v11 37/59] hw/xen: Implement EVTCHNOP_bind_vcpu David Woodhouse
2023-02-16  6:24 ` [PATCH v11 38/59] hw/xen: Implement EVTCHNOP_reset David Woodhouse
2023-02-16  6:24 ` [PATCH v11 39/59] i386/xen: add monitor commands to test event injection David Woodhouse
2023-02-16  6:24 ` [PATCH v11 40/59] hw/xen: Support HVM_PARAM_CALLBACK_TYPE_GSI callback David Woodhouse
2023-02-16  6:24 ` [PATCH v11 41/59] hw/xen: Support HVM_PARAM_CALLBACK_TYPE_PCI_INTX callback David Woodhouse
2023-02-16  6:24 ` [PATCH v11 42/59] kvm/i386: Add xen-gnttab-max-frames property David Woodhouse
2023-02-16  6:24 ` [PATCH v11 43/59] hw/xen: Add xen_gnttab device for grant table emulation David Woodhouse
2023-02-16  6:24 ` [PATCH v11 44/59] hw/xen: Support mapping grant frames David Woodhouse
2023-02-20 14:20   ` Paul Durrant
2023-02-16  6:24 ` [PATCH v11 45/59] i386/xen: Implement HYPERVISOR_grant_table_op and GNTTABOP_[gs]et_verson David Woodhouse
2023-02-16  6:24 ` [PATCH v11 46/59] hw/xen: Implement GNTTABOP_query_size David Woodhouse
2023-02-16  6:24 ` [PATCH v11 47/59] i386/xen: handle PV timer hypercalls David Woodhouse
2023-02-20 14:29   ` Paul Durrant
2023-02-20 15:49     ` David Woodhouse
2023-02-16  6:24 ` [PATCH v11 48/59] i386/xen: Reserve Xen special pages for console, xenstore rings David Woodhouse
2023-02-16  6:24 ` [PATCH v11 49/59] i386/xen: handle HVMOP_get_param David Woodhouse
2023-02-16  6:24 ` [PATCH v11 50/59] hw/xen: Add backend implementation of interdomain event channel support David Woodhouse
2023-02-16  6:24 ` [PATCH v11 51/59] hw/xen: Add xen_xenstore device for xenstore emulation David Woodhouse
2023-02-16  6:24 ` [PATCH v11 52/59] hw/xen: Add basic ring handling to xenstore David Woodhouse
2023-02-16  6:24 ` [PATCH v11 53/59] hw/xen: Automatically add xen-platform PCI device for emulated Xen guests David Woodhouse
2023-02-16  6:24 ` [PATCH v11 54/59] i386/xen: Implement HYPERVISOR_physdev_op David Woodhouse
2023-02-16  6:24 ` [PATCH v11 55/59] hw/xen: Implement emulated PIRQ hypercall support David Woodhouse
2023-02-16  6:24 ` [PATCH v11 56/59] hw/xen: Support GSI mapping to PIRQ David Woodhouse
2023-02-16  6:24 ` [PATCH v11 57/59] hw/xen: Support MSI " David Woodhouse
2023-02-16  6:24 ` [PATCH v11 58/59] kvm/i386: Add xen-evtchn-max-pirq property David Woodhouse
2023-02-16  6:24 ` [PATCH v11 59/59] i386/xen: Document Xen HVM emulation David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230216062444.2129371-5-dwmw2@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=alex.bennee@linaro.org \
    --cc=ankur.a.arora@oracle.com \
    --cc=armbru@redhat.com \
    --cc=cfontana@suse.de \
    --cc=dgilbert@redhat.com \
    --cc=joao.m.martins@oracle.com \
    --cc=julien@xen.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).