From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Dapeng Mi" <dapeng1.mi@intel.com>,
"Sean Christopherson" <seanjc@google.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Zhuocheng Ding" <zhuocheng.ding@intel.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Zhenyu Wang" <zhenyu.z.wang@intel.com>,
qemu-riscv@nongnu.org,
"Alistair Francis" <alistair.francis@wdc.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Robert Hoo" <robert.hu@linux.intel.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Like Xu" <like.xu.linux@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Zhao Liu" <zhao1.liu@linux.intel.com>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: [PATCH 4/5] hw/arm: Restrict CPU clusters to the expected type
Date: Thu, 16 Feb 2023 15:23:37 +0100 [thread overview]
Message-ID: <20230216142338.82982-5-philmd@linaro.org> (raw)
In-Reply-To: <20230216142338.82982-1-philmd@linaro.org>
ARM SSE expects v7-M cores; the ZynqMP SoC expects Cortex-A53/R5F.
Do not allow any other CPU type by setting the cluster 'cpu-type'
property.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/armsse.c | 1 +
hw/arm/xlnx-zynqmp.c | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/hw/arm/armsse.c b/hw/arm/armsse.c
index 0202bad787..1132fdcbe2 100644
--- a/hw/arm/armsse.c
+++ b/hw/arm/armsse.c
@@ -715,6 +715,7 @@ static void armsse_init(Object *obj)
name = g_strdup_printf("cluster%d", i);
object_initialize_child(obj, name, &s->cluster[i], TYPE_CPU_CLUSTER);
qdev_prop_set_uint32(DEVICE(&s->cluster[i]), "cluster-id", i);
+ qdev_prop_set_string(DEVICE(&s->cluster[i]), "cpu-type", TYPE_ARMV7M);
g_free(name);
name = g_strdup_printf("armv7m%d", i);
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index 335cfc417d..e45cf88625 100644
--- a/hw/arm/xlnx-zynqmp.c
+++ b/hw/arm/xlnx-zynqmp.c
@@ -224,6 +224,8 @@ static void xlnx_zynqmp_create_rpu(MachineState *ms, XlnxZynqMPState *s,
object_initialize_child(OBJECT(s), "rpu-cluster", &s->rpu_cluster,
TYPE_CPU_CLUSTER);
qdev_prop_set_uint32(DEVICE(&s->rpu_cluster), "cluster-id", 1);
+ qdev_prop_set_string(DEVICE(&s->rpu_cluster), "cpu-type",
+ ARM_CPU_TYPE_NAME("cortex-r5f"));
for (i = 0; i < num_rpus; i++) {
const char *name;
@@ -381,6 +383,8 @@ static void xlnx_zynqmp_init(Object *obj)
object_initialize_child(obj, "apu-cluster", &s->apu_cluster,
TYPE_CPU_CLUSTER);
qdev_prop_set_uint32(DEVICE(&s->apu_cluster), "cluster-id", 0);
+ qdev_prop_set_string(DEVICE(&s->apu_cluster), "cpu-type",
+ ARM_CPU_TYPE_NAME("cortex-a53"));
for (i = 0; i < num_apus; i++) {
object_initialize_child(OBJECT(&s->apu_cluster), "apu-cpu[*]",
--
2.38.1
next prev parent reply other threads:[~2023-02-16 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 14:23 [PATCH 0/5] hw/cpu/cluster: Restrict CPU cluster to a particular CPU type Philippe Mathieu-Daudé
2023-02-16 14:23 ` [PATCH 1/5] hw/cpu: Extend CPUState::cluster_index documentation Philippe Mathieu-Daudé
2023-02-21 17:47 ` Peter Maydell
2023-02-16 14:23 ` [PATCH 2/5] hw/cpu/cluster: Only add CPU objects to CPU cluster Philippe Mathieu-Daudé
2023-02-21 17:56 ` Peter Maydell
2023-02-16 14:23 ` [PATCH 3/5] hw/cpu/cluster: Restrict CPU cluster to a particular CPU type Philippe Mathieu-Daudé
2023-02-21 17:59 ` Peter Maydell
2023-02-16 14:23 ` Philippe Mathieu-Daudé [this message]
2023-02-16 14:23 ` [PATCH 5/5] hw/riscv: Restrict CPU clusters to the expected type Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216142338.82982-5-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair@alistair23.me \
--cc=bin.meng@windriver.com \
--cc=dapeng1.mi@intel.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=like.xu.linux@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robert.hu@linux.intel.com \
--cc=seanjc@google.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
--cc=zhenyu.z.wang@intel.com \
--cc=zhuocheng.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).